Changeset 158827 in webkit
- Timestamp:
- Nov 7, 2013 12:05:06 AM (10 years ago)
- Location:
- trunk/Source/WebKit2
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit2/ChangeLog
r158819 r158827 1 2013-11-07 Brendan Long <b.long@cablelabs.com> 2 3 [Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as OVERRIDE 4 https://bugs.webkit.org/show_bug.cgi?id=123919 5 6 Reviewed by Carlos Garcia Campos. 7 8 * UIProcess/API/gtk/PageClientImpl.cpp: Remove takeFocus(). 9 * UIProcess/API/gtk/PageClientImpl.h: Remove takeFocus() and mark methods as OVERRIDE. 10 1 11 2013-11-06 Dan Bernstein <mitz@apple.com> 2 12 -
trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp
r158782 r158827 127 127 } 128 128 129 void PageClientImpl::takeFocus(bool)130 {131 notImplemented();132 }133 134 129 void PageClientImpl::toolTipChanged(const String&, const String& newToolTip) 135 130 { -
trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h
r158782 r158827 55 55 explicit PageClientImpl(GtkWidget*); 56 56 57 virtual std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy(); 58 virtual void setViewNeedsDisplay(const WebCore::IntRect&); 59 virtual void displayView(); 60 virtual bool canScrollView() { return false; } 61 virtual void scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset); 62 virtual WebCore::IntSize viewSize(); 63 virtual bool isViewWindowActive(); 64 virtual bool isViewFocused(); 65 virtual bool isViewVisible(); 66 virtual bool isViewInWindow(); 67 virtual void processDidCrash(); 68 virtual void didRelaunchProcess(); 69 virtual void pageClosed(); 70 virtual void preferencesDidChange(); 71 virtual void takeFocus(bool direction); 72 virtual void toolTipChanged(const WTF::String&, const WTF::String&); 73 virtual void setCursor(const WebCore::Cursor&); 74 virtual void setCursorHiddenUntilMouseMoves(bool); 75 virtual void didChangeViewportProperties(const WebCore::ViewportAttributes&); 76 virtual void registerEditCommand(PassRefPtr<WebEditCommandProxy>, WebPageProxy::UndoOrRedo); 77 virtual void clearAllEditCommands(); 78 virtual bool canUndoRedo(WebPageProxy::UndoOrRedo); 79 virtual void executeUndoRedo(WebPageProxy::UndoOrRedo); 80 virtual WebCore::FloatRect convertToDeviceSpace(const WebCore::FloatRect&); 81 virtual WebCore::FloatRect convertToUserSpace(const WebCore::FloatRect&); 82 virtual WebCore::IntPoint screenToWindow(const WebCore::IntPoint&); 83 virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&); 84 virtual void doneWithKeyEvent(const NativeWebKeyboardEvent&, bool wasEventHandled); 85 virtual PassRefPtr<WebPopupMenuProxy> createPopupMenuProxy(WebPageProxy*); 86 virtual PassRefPtr<WebContextMenuProxy> createContextMenuProxy(WebPageProxy*); 57 virtual std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy() OVERRIDE; 58 virtual void setViewNeedsDisplay(const WebCore::IntRect&) OVERRIDE; 59 virtual void displayView() OVERRIDE; 60 virtual bool canScrollView() OVERRIDE { return false; } 61 virtual void scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset) OVERRIDE; 62 virtual WebCore::IntSize viewSize() OVERRIDE; 63 virtual bool isViewWindowActive() OVERRIDE; 64 virtual bool isViewFocused() OVERRIDE; 65 virtual bool isViewVisible() OVERRIDE; 66 virtual bool isViewInWindow() OVERRIDE; 67 virtual void processDidCrash() OVERRIDE; 68 virtual void didRelaunchProcess() OVERRIDE; 69 virtual void pageClosed() OVERRIDE; 70 virtual void preferencesDidChange() OVERRIDE; 71 virtual void toolTipChanged(const WTF::String&, const WTF::String&) OVERRIDE; 72 virtual void setCursor(const WebCore::Cursor&) OVERRIDE; 73 virtual void setCursorHiddenUntilMouseMoves(bool) OVERRIDE; 74 virtual void didChangeViewportProperties(const WebCore::ViewportAttributes&) OVERRIDE; 75 virtual void registerEditCommand(PassRefPtr<WebEditCommandProxy>, WebPageProxy::UndoOrRedo) OVERRIDE; 76 virtual void clearAllEditCommands() OVERRIDE; 77 virtual bool canUndoRedo(WebPageProxy::UndoOrRedo) OVERRIDE; 78 virtual void executeUndoRedo(WebPageProxy::UndoOrRedo) OVERRIDE; 79 virtual WebCore::FloatRect convertToDeviceSpace(const WebCore::FloatRect&) OVERRIDE; 80 virtual WebCore::FloatRect convertToUserSpace(const WebCore::FloatRect&) OVERRIDE; 81 virtual WebCore::IntPoint screenToWindow(const WebCore::IntPoint&) OVERRIDE; 82 virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&) OVERRIDE; 83 virtual void doneWithKeyEvent(const NativeWebKeyboardEvent&, bool wasEventHandled) OVERRIDE; 84 virtual PassRefPtr<WebPopupMenuProxy> createPopupMenuProxy(WebPageProxy*) OVERRIDE; 85 virtual PassRefPtr<WebContextMenuProxy> createContextMenuProxy(WebPageProxy*) OVERRIDE; 87 86 #if ENABLE(INPUT_TYPE_COLOR) 88 virtual PassRefPtr<WebColorPicker> createColorPicker(WebPageProxy*, const WebCore::Color& intialColor, const WebCore::IntRect&) ;87 virtual PassRefPtr<WebColorPicker> createColorPicker(WebPageProxy*, const WebCore::Color& intialColor, const WebCore::IntRect&) OVERRIDE; 89 88 #endif 90 virtual void setFindIndicator(PassRefPtr<FindIndicator>, bool fadeOut, bool animate) ;91 virtual void getEditorCommandsForKeyEvent(const NativeWebKeyboardEvent&, const AtomicString&, Vector<WTF::String>&) ;92 virtual void updateTextInputState() ;93 virtual void startDrag(const WebCore::DragData&, PassRefPtr<ShareableBitmap> dragImage) ;94 virtual bool isWindowVisible() ;89 virtual void setFindIndicator(PassRefPtr<FindIndicator>, bool fadeOut, bool animate) OVERRIDE; 90 virtual void getEditorCommandsForKeyEvent(const NativeWebKeyboardEvent&, const AtomicString&, Vector<WTF::String>&) OVERRIDE; 91 virtual void updateTextInputState() OVERRIDE; 92 virtual void startDrag(const WebCore::DragData&, PassRefPtr<ShareableBitmap> dragImage) OVERRIDE; 93 virtual bool isWindowVisible() OVERRIDE; 95 94 96 95 #if USE(ACCELERATED_COMPOSITING) 97 virtual void enterAcceleratedCompositingMode(const LayerTreeContext&) ;98 virtual void exitAcceleratedCompositingMode() ;99 virtual void updateAcceleratedCompositingMode(const LayerTreeContext&) ;96 virtual void enterAcceleratedCompositingMode(const LayerTreeContext&) OVERRIDE; 97 virtual void exitAcceleratedCompositingMode() OVERRIDE; 98 virtual void updateAcceleratedCompositingMode(const LayerTreeContext&) OVERRIDE; 100 99 #endif 101 100 102 virtual void handleDownloadRequest(DownloadProxy*) ;101 virtual void handleDownloadRequest(DownloadProxy*) OVERRIDE; 103 102 104 103 // Members of PageClientImpl class
Note: See TracChangeset
for help on using the changeset viewer.