Changeset 158880 in webkit

Timestamp:

Nov 7, 2013 3:31:08 PM (10 years ago)

Author:

andersca@apple.com

Message:

Remove more dead code
​https://bugs.webkit.org/show_bug.cgi?id=124016

Reviewed by Beth Dakin.

We're always layer backed now so we never scroll using the PageClient.

• UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::canScrollView):
(WebKit::PageClientImpl::scrollView):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/mac/PageClientImpl.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-11-07  Anders Carlsson  <andersca@apple.com>
+
+        Remove more dead code
+        https://bugs.webkit.org/show_bug.cgi?id=124016
+
+        Reviewed by Beth Dakin.
+
+        We're always layer backed now so we never scroll using the PageClient.
+
+        * UIProcess/API/mac/PageClientImpl.mm:
+        (WebKit::PageClientImpl::canScrollView):
+        (WebKit::PageClientImpl::scrollView):
+
 2013-11-07  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm

@@ -151 +151 @@
 bool PageClientImpl::canScrollView()
 {
-    // -scrollRect:by: does nothing in layer-backed views <rdar://problem/12961719>.
-    return ![m_wkView layer];
+    return false;
 }
 
 void PageClientImpl::scrollView(const IntRect& scrollRect, const IntSize& scrollOffset)
 {
-    NSRect clippedScrollRect = NSIntersectionRect(scrollRect, NSOffsetRect(scrollRect, -scrollOffset.width(), -scrollOffset.height()));
-
-    [m_wkView _cacheWindowBottomCornerRect];
-
-    [m_wkView translateRectsNeedingDisplayInRect:clippedScrollRect by:scrollOffset];
-    [m_wkView scrollRect:clippedScrollRect by:scrollOffset];
+    ASSERT_NOT_REACHED();
 }