Changeset 158978 in webkit

Timestamp:

Nov 8, 2013 4:51:54 PM (10 years ago)

Author:

andersca@apple.com

Message:

KeyedEncoder should be able to encoder objects
​https://bugs.webkit.org/show_bug.cgi?id=124085

Reviewed by Sam Weinig.

Source/WebCore:

• history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTree):
Encode the root object.

(WebCore::HistoryItem::encodeBackForwardTreeNode):
Encode the target.

• history/HistoryItem.h:

Add new members.

• platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeObject):
Call beginObject, call the functor and then call endObject().

Source/WebKit2:

Add a dictionary stack to KeyedEncoder that's pushed and popped by
beginObject/endObject.

• Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::KeyedEncoder):
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeString):
(WebKit::KeyedEncoder::beginObject):
(WebKit::KeyedEncoder::endObject):

• Shared/cf/KeyedEncoder.h:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/history/HistoryItem.cpp (modified) (2 diffs)
• WebCore/history/HistoryItem.h (modified) (1 diff)
• WebCore/platform/KeyedCoding.h (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/Shared/cf/KeyedEncoder.cpp (modified) (2 diffs)
• WebKit2/Shared/cf/KeyedEncoder.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-11-08  Anders Carlsson  <andersca@apple.com>
+
+        KeyedEncoder should be able to encoder objects
+        https://bugs.webkit.org/show_bug.cgi?id=124085
+
+        Reviewed by Sam Weinig.
+
+        * history/HistoryItem.cpp:
+        (WebCore::HistoryItem::encodeBackForwardTree):
+        Encode the root object.
+
+        (WebCore::HistoryItem::encodeBackForwardTreeNode):
+        Encode the target.
+
+        * history/HistoryItem.h:
+        Add new members.
+
+        * platform/KeyedCoding.h:
+        (WebCore::KeyedEncoder::encodeObject):
+        Call beginObject, call the functor and then call endObject().
+
 2013-11-08  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebCore/history/HistoryItem.cpp

@@ -688 +688 @@
     encoder.encodeUInt32("version", backForwardTreeEncodingVersion);
 
-    // FIXME: Encode the tree.
+    encoder.encodeObject("root", *this, [](KeyedEncoder& encoder, const HistoryItem& item) {
+        item.encodeBackForwardTreeNode(encoder);
+    });
 }
 
@@ -732 +734 @@
 
     encoder.encodeString(m_target);
+}
+
+void HistoryItem::encodeBackForwardTreeNode(KeyedEncoder& encoder) const
+{
+    // FIXME: Implement.
+
+    encoder.encodeString("target", m_target);
 }
 

trunk/Source/WebCore/history/HistoryItem.h

@@ -224 +224 @@
 
     void encodeBackForwardTreeNode(Encoder&) const;
-
-    /* When adding new member variables to this class, please notify the Qt team.
-     * qt/HistoryItemQt.cpp contains code to serialize history items.
-     */
+    void encodeBackForwardTreeNode(KeyedEncoder&) const;
 
     String m_urlString;

trunk/Source/WebCore/platform/KeyedCoding.h

@@ -37 +37 @@
 public:
     virtual void encodeUInt32(const String& key, uint32_t) = 0;
+
+    virtual void encodeString(const String& key, const String&) = 0;
+
+    template<typename T, typename F>
+    void encodeObject(const String& key, const T& object, F function)
+    {
+        this->beginObject(key);
+        function(*this, object);
+        this->endObject();
+    }
+
+private:
+    virtual void beginObject(const String& key) = 0;
+    virtual void endObject() = 0;
 };
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-11-08  Anders Carlsson  <andersca@apple.com>
+
+        KeyedEncoder should be able to encoder objects
+        https://bugs.webkit.org/show_bug.cgi?id=124085
+
+        Reviewed by Sam Weinig.
+
+        Add a dictionary stack to KeyedEncoder that's pushed and popped by
+        beginObject/endObject.
+
+        * Shared/cf/KeyedEncoder.cpp:
+        (WebKit::KeyedEncoder::KeyedEncoder):
+        (WebKit::KeyedEncoder::~KeyedEncoder):
+        (WebKit::KeyedEncoder::encodeUInt32):
+        (WebKit::KeyedEncoder::encodeString):
+        (WebKit::KeyedEncoder::beginObject):
+        (WebKit::KeyedEncoder::endObject):
+        * Shared/cf/KeyedEncoder.h:
+
 2013-11-08  Alexandru Chiculita  <achicu@adobe.com>
 

trunk/Source/WebKit2/Shared/cf/KeyedEncoder.cpp

@@ -40 +40 @@
     : m_rootDictionary(createDictionary())
 {
+    m_dictionaryStack.append(m_rootDictionary.get());
 }
     
 KeyedEncoder::~KeyedEncoder()
 {
+    ASSERT(m_dictionaryStack.size() == 1);
+    ASSERT(m_dictionaryStack.last() == m_rootDictionary);
 }
 
@@ -49 +52 @@
 {
     RetainPtr<CFNumberRef> number = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberSInt32Type, &value));
-    CFDictionarySetValue(m_rootDictionary.get(), key.createCFString().get(), number.get());
+    CFDictionarySetValue(m_dictionaryStack.last(), key.createCFString().get(), number.get());
+}
+
+void KeyedEncoder::encodeString(const String& key, const String& value)
+{
+    CFDictionarySetValue(m_dictionaryStack.last(), key.createCFString().get(), value.createCFString().get());
+}
+
+void KeyedEncoder::beginObject(const String& key)
+{
+    auto dictionary = createDictionary();
+    CFDictionarySetValue(m_dictionaryStack.last(), key.createCFString().get(), dictionary.get());
+
+    m_dictionaryStack.append(dictionary.get());
+}
+
+void KeyedEncoder::endObject()
+{
+    m_dictionaryStack.removeLast();
 }
 

trunk/Source/WebKit2/Shared/cf/KeyedEncoder.h

@@ -29 +29 @@
 #include <WebCore/KeyedCoding.h>
 #include <wtf/RetainPtr.h>
+#include <wtf/Vector.h>
 
 namespace WebKit {
@@ -39 +40 @@
 private:
     virtual void encodeUInt32(const String& key, uint32_t) OVERRIDE;
+    virtual void encodeString(const String& key, const String&) OVERRIDE;
+
+    virtual void beginObject(const String& key) OVERRIDE;
+    virtual void endObject() OVERRIDE;
 
     RetainPtr<CFMutableDictionaryRef> m_rootDictionary;
+    Vector<CFMutableDictionaryRef, 16> m_dictionaryStack;
 };