Changeset 159041 in webkit

Timestamp:

Nov 11, 2013 12:24:32 AM (10 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] [WebKit2] Crash when printing to a file via javascript
​https://bugs.webkit.org/show_bug.cgi?id=122801

Reviewed by Martin Robinson.

This crash is caused by a GTK+ bug, but we can work around it by
ensuring the print dialog is always shown with a valid
GtkPrintSettings object.

• UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialog):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitPrintOperation.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-11-10  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] [WebKit2] Crash when printing to a file via javascript
+        https://bugs.webkit.org/show_bug.cgi?id=122801
+
+        Reviewed by Martin Robinson.
+
+        This crash is caused by a GTK+ bug, but we can work around it by
+        ensuring the print dialog is always shown with a valid
+        GtkPrintSettings object.
+
+        * UIProcess/API/gtk/WebKitPrintOperation.cpp:
+        (webkitPrintOperationRunDialog):
+
 2013-11-09  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp

@@ -229 +229 @@
 
     WebKitPrintOperationPrivate* priv = printOperation->priv;
-    if (priv->printSettings)
-        gtk_print_unix_dialog_set_settings(printDialog, priv->printSettings.get());
+    // Make sure the initial settings of the GtkPrintUnixDialog is a valid
+    // GtkPrintSettings object to work around a crash happening in the GTK+
+    // file print backend. https://bugzilla.gnome.org/show_bug.cgi?id=703784.
+    if (!priv->printSettings)
+        priv->printSettings = adoptGRef(gtk_print_settings_new());
+    gtk_print_unix_dialog_set_settings(printDialog, priv->printSettings.get());
 
     if (priv->pageSetup)