Changeset 159051 in webkit

Timestamp:

Nov 11, 2013 9:33:19 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Do not shut down ImageDiff server after every diff during the tests.
​https://bugs.webkit.org/show_bug.cgi?id=124140

Patch by Tamas Gergely <​gertom@inf.u-szeged.hu> on 2013-11-11
Reviewed by Csaba Osztrogonác.

There was a FIXME: There is no need to shut down the ImageDiff
server after every diff. Shutdown is removed from that point.

• Scripts/webkitpy/port/image_diff.py:

(ImageDiffer._read):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/image_diff.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
+
+        Do not shut down ImageDiff server after every diff during the tests.
+        https://bugs.webkit.org/show_bug.cgi?id=124140
+
+        Reviewed by Csaba Osztrogonác.
+
+        There was a FIXME: There is no need to shut down the ImageDiff
+        server after every diff. Shutdown is removed from that point.
+
+        * Scripts/webkitpy/port/image_diff.py:
+        (ImageDiffer._read):
+
 2013-11-08  Matthew Hanson  <matthew_hanson@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/image_diff.py

@@ -101 +101 @@
             err_str += "ImageDiff crashed\n"
 
-        # FIXME: There is no need to shut down the ImageDiff server after every diff.
-        self._process.stop()
-
         diff_percent = 0
         if output and output.startswith('diff'):