Changeset 159093 in webkit

Timestamp:

Nov 11, 2013 8:39:59 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Remove some unused generated code
​https://bugs.webkit.org/show_bug.cgi?id=124179

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-11
Reviewed by Timothy Hatcher.

• inspector/CodeGeneratorInspectorStrings.py:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/CodeGeneratorInspectorStrings.py (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-11-11  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Remove some unused generated code
+        https://bugs.webkit.org/show_bug.cgi?id=124179
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/CodeGeneratorInspectorStrings.py:
+
 2013-11-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Source/WebCore/inspector/CodeGeneratorInspectorStrings.py

@@ -34 +34 @@
     public:
         $domainClassName(InspectorFrontendChannel* inspectorFrontendChannel) : m_inspectorFrontendChannel(inspectorFrontendChannel) { }
-${frontendDomainMethodDeclarations}        void setInspectorFrontendChannel(InspectorFrontendChannel* inspectorFrontendChannel) { m_inspectorFrontendChannel = inspectorFrontendChannel; }
-        InspectorFrontendChannel* getInspectorFrontendChannel() { return m_inspectorFrontendChannel; }
-    private:
+${frontendDomainMethodDeclarations}
+    protected:
         InspectorFrontendChannel* m_inspectorFrontendChannel;
     };
@@ -68 +67 @@
     RefPtr<InspectorObject> jsonMessage = InspectorObject::create();
     jsonMessage->setString("method", "$domainName.$eventName");
-$code    if (m_inspectorFrontendChannel)
-        m_inspectorFrontendChannel->sendMessageToFrontend(jsonMessage->toJSONString());
+$code
+    m_inspectorFrontendChannel->sendMessageToFrontend(jsonMessage->toJSONString());
 }
 """)
@@ -183 +182 @@
     virtual void reportProtocolError(const long* const callId, CommonErrorCode, const String& errorMessage, PassRefPtr<InspectorArray> data) const = 0;
     virtual void dispatch(const String& message) = 0;
-    static bool getCommandName(const String& message, String* result);
 
     enum MethodNames {
@@ -461 +459 @@
 }
 
-bool InspectorBackendDispatcher::getCommandName(const String& message, String* result)
-{
-    RefPtr<InspectorValue> value = InspectorValue::parseJSON(message);
-    if (!value)
-        return false;
-
-    RefPtr<InspectorObject> object = value->asObject();
-    if (!object)
-        return false;
-
-    if (!object->getString("method", result))
-        return false;
-
-    return true;
-}
-
 InspectorBackendDispatcher::CallbackBase::CallbackBase(PassRefPtr<InspectorBackendDispatcherImpl> backendImpl, int id)
     : m_backendImpl(backendImpl), m_id(id), m_alreadySent(false) {}