Changeset 159441 in webkit


Ignore:
Timestamp:
Nov 18, 2013 11:44:31 AM (10 years ago)
Author:
dfarler@apple.com
Message:

[ASAN] WebKit2: Remove calls to dead DownloadAuthenticationClient code
​https://bugs.webkit.org/show_bug.cgi?id=124367

Reviewed by Alexey Proskuryakov.

  • Shared/Downloads/DownloadAuthenticationClient.cpp:

(WebKit::DownloadAuthenticationClient::receivedCredential):
(WebKit::DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential):
(WebKit::DownloadAuthenticationClient::receivedCancellation):
Remove calls to nowhere:
WebKit::Download::cancelAuthenticationChallenge(WebCore::AuthenticationChallenge const&)
WebKit::Download::continueWithoutCredential(WebCore::AuthenticationChallenge const&)
WebKit::Download::useCredential(WebCore::AuthenticationChallenge const&, WebCore::Credential const&)

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r159439 r159441  
     12013-11-14  David Farler  <dfarler@apple.com>
     2
     3        [ASAN] WebKit2: Remove calls to dead DownloadAuthenticationClient code
     4        https://bugs.webkit.org/show_bug.cgi?id=124367
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        * Shared/Downloads/DownloadAuthenticationClient.cpp:
     9        (WebKit::DownloadAuthenticationClient::receivedCredential):
     10        (WebKit::DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential):
     11        (WebKit::DownloadAuthenticationClient::receivedCancellation):
     12        Remove calls to nowhere:
     13        WebKit::Download::cancelAuthenticationChallenge(WebCore::AuthenticationChallenge const&)
     14        WebKit::Download::continueWithoutCredential(WebCore::AuthenticationChallenge const&)
     15        WebKit::Download::useCredential(WebCore::AuthenticationChallenge const&, WebCore::Credential const&)
     16
    1172013-11-18  Anders Carlsson  <andersca@apple.com>
    218

  • trunk/Source/WebKit2/Shared/Downloads/DownloadAuthenticationClient.cpp

    r140752 r159441  
    4141void DownloadAuthenticationClient::receivedCredential(const AuthenticationChallenge& challenge, const Credential& credential)
    4242{
    43     if (!m_download)
    44         return;
    45     m_download->useCredential(challenge, credential);
     43    // FIXME (119667): This can probably be just removed.
    4644}
    4745
    4846void DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential(const AuthenticationChallenge& challenge)
    4947{
    50     if (!m_download)
    51         return;
    52     m_download->continueWithoutCredential(challenge);
     48    // FIXME (119667): This can probably be just removed.
    5349}
    5450
    5551void DownloadAuthenticationClient::receivedCancellation(const AuthenticationChallenge& challenge)
    5652{
    57     if (!m_download)
    58         return;
    59     m_download->cancelAuthenticationChallenge(challenge);
     53    // FIXME (119667): This can probably be just removed.
    6054}
    6155
Note: See TracChangeset for help on using the changeset viewer.