Changeset 159453 in webkit


Ignore:
Timestamp:
Nov 18, 2013 1:48:18 PM (10 years ago)
Author:
timothy_horton@apple.com
Message:

Occasionally, hundreds of tests fail with small text diffs on Mavericks
https://bugs.webkit.org/show_bug.cgi?id=124312

Reviewed by Simon Fraser.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._set_up_run):

  • Scripts/webkitpy/port/base.py:

(Port.to.reset_preferences):

  • Scripts/webkitpy/port/mac.py:

(MacPort.reset_preferences):
Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
returning some of the functionality of 158652 after 159364 removed it.

Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r159440 r159453  
     12013-11-18  Tim Horton  <timothy_horton@apple.com>
     2
     3        Occasionally, hundreds of tests fail with small text diffs on Mavericks
     4        https://bugs.webkit.org/show_bug.cgi?id=124312
     5
     6        Reviewed by Simon Fraser.
     7
     8        * Scripts/webkitpy/layout_tests/controllers/manager.py:
     9        (Manager._set_up_run):
     10        * Scripts/webkitpy/port/base.py:
     11        (Port.to.reset_preferences):
     12        * Scripts/webkitpy/port/mac.py:
     13        (MacPort.reset_preferences):
     14        Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
     15        returning some of the functionality of 158652 after 159364 removed it.
     16
    1172013-11-18  Tim Horton  <timothy_horton@apple.com>
    218
  • trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

    r158373 r159453  
    154154        self._port.start_helper(self._options.pixel_tests)
    155155
     156        self._port.reset_preferences()
     157
    156158        # Check that the system dependencies (themes, fonts, ...) are correct.
    157159        if not self._options.nocheck_sys_deps:
  • trunk/Tools/Scripts/webkitpy/port/base.py

    r157995 r159453  
    931931        pass
    932932
     933    def reset_preferences(self):
     934        """If a port needs to reset platform-specific persistent preference
     935        storage, it should override this method."""
     936        pass
     937
    933938    def start_http_server(self, additional_dirs=None, number_of_servers=None):
    934939        """Start a web server. Raise an error if it can't start or is already running.
  • trunk/Tools/Scripts/webkitpy/port/mac.py

    r157831 r159453  
    285285                _log.error("LayoutTestHelper failed to be ready")
    286286
     287    def reset_preferences(self):
     288        _log.debug("Resetting persistent preferences")
     289
     290        for domain in ["DumpRenderTree", "WebKitTestRunner"]:
     291            try:
     292                self._executive.run_command(["defaults", "delete", domain])
     293            except ScriptError, e:
     294                # 'defaults' returns 1 if the domain did not exist
     295                if e.exit_code != 1:
     296                    raise e
     297
    287298    def stop_helper(self):
    288299        if self._helper:
Note: See TracChangeset for help on using the changeset viewer.