Changeset 159559 in webkit

Timestamp:

Nov 20, 2013 6:55:24 AM (10 years ago)

Author:

Antoine Quint

Message:

Cannot animate "points" attribute for <svg:polygon>
​https://bugs.webkit.org/show_bug.cgi?id=21371

Reviewed by Antti Koivisto.

Source/WebCore:

Ensure we use animated list of points for SVG <polygon> and <polyline> elements
when we build the path used to draw them, otherwise the animated changes won't
be rendered and the base value will be used.

Tests: svg/animations/polygon-set.svg

svg/animations/polyline-set.svg

• rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromPolygonElement):
(WebCore::updatePathFromPolylineElement):

LayoutTests:

New tests covering the actual application of the animated value
for the "points" attribute of the SVG <polygon> and <polyline> elements.

• svg/animations/polygon-set-expected.svg: Added.
• svg/animations/polygon-set.svg: Added.
• svg/animations/polyline-set-expected.svg: Added.
• svg/animations/polyline-set.svg: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/animations/polygon-set-expected.svg (added)
• LayoutTests/svg/animations/polygon-set.svg (added)
• LayoutTests/svg/animations/polyline-set-expected.svg (added)
• LayoutTests/svg/animations/polyline-set.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/svg/SVGPathData.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-11-20  Antoine Quint  <graouts@apple.com>
+
+        Cannot animate "points" attribute for <svg:polygon>
+        https://bugs.webkit.org/show_bug.cgi?id=21371
+
+        Reviewed by Antti Koivisto.
+
+        New tests covering the actual application of the animated value
+        for the "points" attribute of the SVG <polygon> and <polyline> elements.
+
+        * svg/animations/polygon-set-expected.svg: Added.
+        * svg/animations/polygon-set.svg: Added.
+        * svg/animations/polyline-set-expected.svg: Added.
+        * svg/animations/polyline-set.svg: Added.
+
 2013-11-20  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-11-20  Antoine Quint  <graouts@apple.com>
+
+        Cannot animate "points" attribute for <svg:polygon>
+        https://bugs.webkit.org/show_bug.cgi?id=21371
+
+        Reviewed by Antti Koivisto.
+
+        Ensure we use animated list of points for SVG <polygon> and <polyline> elements
+        when we build the path used to draw them, otherwise the animated changes won't
+        be rendered and the base value will be used.
+
+        Tests: svg/animations/polygon-set.svg
+               svg/animations/polyline-set.svg
+
+        * rendering/svg/SVGPathData.cpp:
+        (WebCore::updatePathFromPolygonElement):
+        (WebCore::updatePathFromPolylineElement):
+
 2013-11-20  Andrei Bucur  <abucur@adobe.com>
 

trunk/Source/WebCore/rendering/svg/SVGPathData.cpp

@@ -77 +77 @@
 static void updatePathFromPolygonElement(SVGElement* element, Path& path)
 {
-    SVGPointList& points = toSVGPolygonElement(element)->pointList();
+    SVGPointList& points = toSVGPolygonElement(element)->animatedPoints()->values();
     if (points.isEmpty())
         return;
@@ -92 +92 @@
 static void updatePathFromPolylineElement(SVGElement* element, Path& path)
 {
-    SVGPointList& points = toSVGPolylineElement(element)->pointList();
+    SVGPointList& points = toSVGPolylineElement(element)->animatedPoints()->values();
     if (points.isEmpty())
         return;