Changeset 159821 in webkit


Ignore:
Timestamp:
Nov 27, 2013 12:17:06 PM (10 years ago)
Author:
hmuller@adobe.com
Message:

[CSS Shapes] shape-inside rectangle layout can fail
https://bugs.webkit.org/show_bug.cgi?id=124784

Reviewed by Andreas Kling.

Source/WebCore:

Apply LayoutUnit::fromFloatCeil() consistently in RectangleShape::firstIncludedIntervalLogicalTop().

Test: fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html

  • rendering/shapes/RectangleShape.cpp:

(WebCore::RectangleShape::firstIncludedIntervalLogicalTop):

LayoutTests:

Regression test.

  • fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.html: Added.
  • fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r159812 r159821  
     12013-11-27  Hans Muller  <hmuller@adobe.com>
     2
     3        [CSS Shapes] shape-inside rectangle layout can fail
     4        https://bugs.webkit.org/show_bug.cgi?id=124784
     5
     6        Reviewed by Andreas Kling.
     7
     8        Regression test.
     9
     10        * fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.html: Added.
     11        * fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html: Added.
     12
    1132013-11-27  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
    214
  • trunk/Source/WebCore/ChangeLog

    r159820 r159821  
     12013-11-27  Hans Muller  <hmuller@adobe.com>
     2
     3        [CSS Shapes] shape-inside rectangle layout can fail
     4        https://bugs.webkit.org/show_bug.cgi?id=124784
     5
     6        Reviewed by Andreas Kling.
     7
     8        Apply LayoutUnit::fromFloatCeil() consistently in RectangleShape::firstIncludedIntervalLogicalTop().
     9
     10        Test: fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html
     11
     12        * rendering/shapes/RectangleShape.cpp:
     13        (WebCore::RectangleShape::firstIncludedIntervalLogicalTop):
     14
    1152013-11-27  Nick Diego Yamane  <nick.yamane@openbossa.org>
    216
  • trunk/Source/WebCore/rendering/shapes/RectangleShape.cpp

    r159671 r159821  
    189189        return false;
    190190
    191     float minY = std::max(bounds.y(), minIntervalTop);
     191    float minY = LayoutUnit::fromFloatCeil(std::max(bounds.y(), minIntervalTop));
    192192    float maxY = minY + minIntervalHeight;
    193193
     
    214214        }
    215215        if (minIntervalHeight < bounds.height() - (2 * cornerIntercept.y())) {
    216             result = ceiledLayoutUnit(bounds.y() + cornerIntercept.y());
     216            result = LayoutUnit::fromFloatCeil(bounds.y() + cornerIntercept.y());
    217217            return true;
    218218        }
Note: See TracChangeset for help on using the changeset viewer.