Changeset 159865 in webkit


Ignore:
Timestamp:
Nov 29, 2013 12:37:31 AM (10 years ago)
Author:
commit-queue@webkit.org
Message:

[EFL] viewport must be same with the size of webview
https://bugs.webkit.org/show_bug.cgi?id=124965

Patch by Hunseop Jeong <Hunseop Jeong> on 2013-11-29
Reviewed by Gyuyoung Kim.

Currently, size of the viewport is larger than size of webview.
Changed the size of viewport with size of webview, because viewport is translated by wrong calculation.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::displayTimerFired): Changed to use the (0,0).
(EwkView::createGLSurface): Modified to use the viewSize instead of the boundsEnd.
(EwkView::handleEvasObjectCalculate): Removed the WKViewSetUserViewportTranslation.

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r159864 r159865  
     12013-11-29  Hunseop Jeong  <hs85.jeong@samsung.com>
     2
     3        [EFL] viewport must be same with the size of webview
     4        https://bugs.webkit.org/show_bug.cgi?id=124965
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        Currently, size of the viewport is larger than size of webview.
     9        Changed the size of viewport with size of webview, because viewport is translated by wrong calculation.
     10
     11        * UIProcess/API/efl/EwkView.cpp:
     12        (EwkView::displayTimerFired): Changed to use the (0,0).
     13        (EwkView::createGLSurface): Modified to use the viewSize instead of the boundsEnd.
     14        (EwkView::handleEvasObjectCalculate): Removed the WKViewSetUserViewportTranslation.
     15
    1162013-11-28  Eunmi Lee  <eunmi15.lee@samsung.com>
    217
  • trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp

    r159863 r159865  
    579579#endif
    580580    // sd->image is tied to a native surface, which is in the parent's coordinates.
    581     evas_object_image_data_update_add(sd->image, sd->view.x, sd->view.y, sd->view.w, sd->view.h);
     581    evas_object_image_data_update_add(sd->image, 0, 0, sd->view.w, sd->view.h);
    582582}
    583583
     
    819819    };
    820820
     821    Ewk_View_Smart_Data* sd = smartData();
     822    IntSize viewSize(sd->view.w, sd->view.h);
     823
    821824    // Recreate to current size: Replaces if non-null, and frees existing surface after (OwnPtr).
    822     m_evasGLSurface = EvasGLSurface::create(m_evasGL.get(), &evasGLConfig, deviceSize());
     825    m_evasGLSurface = EvasGLSurface::create(m_evasGL.get(), &evasGLConfig, viewSize);
    823826    if (!m_evasGLSurface)
    824827        return false;
     
    832835    Evas_GL_API* gl = evas_gl_api_get(m_evasGL.get());
    833836
    834     WKPoint boundsEnd = WKViewUserViewportToScene(wkView(), WKPointMake(deviceSize().width(), deviceSize().height()));
    835     gl->glViewport(0, 0, boundsEnd.x, boundsEnd.y);
     837    gl->glViewport(0, 0, viewSize.width(), viewSize.height());
    836838    gl->glClearColor(1.0, 1.0, 1.0, 0);
    837839    gl->glClear(GL_COLOR_BUFFER_BIT);
     
    11951197        smartData->view.y = y;
    11961198        evas_object_move(smartData->image, x, y);
    1197         WKViewSetUserViewportTranslation(self->wkView(), x, y);
    11981199    }
    11991200
Note: See TracChangeset for help on using the changeset viewer.