Changeset 159901 in webkit


Ignore:
Timestamp:
Dec 1, 2013 3:40:27 PM (10 years ago)
Author:
ryuan.choi@samsung.com
Message:

[EFL][CoordinatedGraphics] Clear m_contentsSize when new contents are loaded
https://bugs.webkit.org/show_bug.cgi?id=125033

Reviewed by Gyuyoung Kim.

m_contentsSize should be cleared when new contents are loaded so that PageViewportController
would take care of newly loaded contents with same size as previous one.
It's because PageViewportController is cleared not to make wrong behaviour
while loading when new contents are committed.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):
Improve tests to check contents,size,changed signal when loaded contents having
same size with previous one.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::didCommitLoadForMainFrame): Cleared m_contentsSize.

Location:
trunk/Source/WebKit2
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r159899 r159901  
     12013-12-01  Ryuan Choi  <ryuan.choi@samsung.com>
     2
     3        [EFL][CoordinatedGraphics] Clear m_contentsSize when new contents are loaded
     4        https://bugs.webkit.org/show_bug.cgi?id=125033
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        m_contentsSize should be cleared when new contents are loaded so that PageViewportController
     9        would take care of newly loaded contents with same size as previous one.
     10        It's because PageViewportController is cleared not to make wrong behaviour
     11        while loading when new contents are committed.
     12
     13        * UIProcess/API/efl/tests/test_ewk2_view.cpp:
     14        (TEST_F):
     15        Improve tests to check contents,size,changed signal when loaded contents having
     16        same size with previous one.
     17        * UIProcess/CoordinatedGraphics/WebView.cpp:
     18        (WebKit::WebView::didCommitLoadForMainFrame): Cleared m_contentsSize.
     19
    1202013-12-01  Philippe Normand  <pnormand@igalia.com>
    221
  • trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp

    r159190 r159901  
    987987    while (!sizeChanged)
    988988        ecore_main_loop_iterate();
     989
     990    // Make sure we get signal after loaded the contents having same size with previous one.
     991    sizeChanged = false;
     992    ewk_view_html_string_load(webView(), contentsSizeHTMLPortrait, 0, 0);
     993    while (!sizeChanged)
     994        ecore_main_loop_iterate();
     995
    989996    evas_object_smart_callback_del(webView(), "contents,size,changed", onContentsSizeChangedPortrait);
    990997}
  • trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp

    r159898 r159901  
    374374void WebView::didCommitLoadForMainFrame()
    375375{
    376     notImplemented();
     376    m_contentsSize = IntSize();
    377377}
    378378
Note: See TracChangeset for help on using the changeset viewer.