Changeset 159910 in webkit

Timestamp:

Dec 1, 2013 9:41:37 PM (10 years ago)

Author:

akling@apple.com

Message:

CSSFunctionValue constructors should return PassRef.
<​https://webkit.org/b/125054>

Make CSSFunctionValue::create() helpers return PassRef instead of
PassRefPtr since they will never return null.

Reviewed by Anders Carlsson.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSFunctionValue.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-12-01  Andreas Kling  <akling@apple.com>
+
+        CSSFunctionValue constructors should return PassRef.
+        <https://webkit.org/b/125054>
+
+        Make CSSFunctionValue::create() helpers return PassRef instead of
+        PassRefPtr since they will never return null.
+
+        Reviewed by Anders Carlsson.
+
 2013-12-01  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/css/CSSFunctionValue.h

@@ -36 +36 @@
 class CSSFunctionValue : public CSSValue {
 public:
-    static PassRefPtr<CSSFunctionValue> create(CSSParserFunction* function)
+    static PassRef<CSSFunctionValue> create(CSSParserFunction* function)
     {
-        return adoptRef(new CSSFunctionValue(function));
+        return adoptRef(*new CSSFunctionValue(function));
     }
 
-    static PassRefPtr<CSSFunctionValue> create(String name, PassRefPtr<CSSValueList> args)
+    static PassRef<CSSFunctionValue> create(String name, PassRefPtr<CSSValueList> args)
     {
-        return adoptRef(new CSSFunctionValue(name, args));
+        return adoptRef(*new CSSFunctionValue(name, args));
     }