Changeset 159911 in webkit


Ignore:
Timestamp:
Dec 1, 2013 9:43:03 PM (10 years ago)
Author:
akling@apple.com
Message:

Remove unreachable labels for -webkit-margin-*-collapse properties.
<https://webkit.org/b/125057>

The following properties are implemented in DeprecatedStyleBuilder
and should not have case labels in the applyProperty() switch:

-webkit-margin-before-collapse
-webkit-margin-top-collapse
-webkit-margin-after-collapse
-webkit-margin-bottom-collapse

This seems counter-intuitive, but they are actually *not* like other
directional properties. In this case, before/after are only aliases
for top/bottom, and do not depend on writing-mode or text-direction.
See also r68561, where the aliases were originally added.

Reviewed by Anders Carlsson.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r159910 r159911  
     12013-12-01  Andreas Kling  <akling@apple.com>
     2
     3        Remove unreachable labels for -webkit-margin-*-collapse properties.
     4        <https://webkit.org/b/125057>
     5
     6        The following properties are implemented in DeprecatedStyleBuilder
     7        and should not have case labels in the applyProperty() switch:
     8
     9            -webkit-margin-before-collapse
     10            -webkit-margin-top-collapse
     11            -webkit-margin-after-collapse
     12            -webkit-margin-bottom-collapse
     13
     14        This seems counter-intuitive, but they are actually *not* like other
     15        directional properties. In this case, before/after are only aliases
     16        for top/bottom, and do not depend on writing-mode or text-direction.
     17        See also r68561, where the aliases were originally added.
     18
     19        Reviewed by Anders Carlsson.
     20
    1212013-12-01  Andreas Kling  <akling@apple.com>
    222
  • trunk/Source/WebCore/css/StyleResolver.cpp

    r159856 r159911  
    25752575    case CSSPropertyWebkitMarginBefore:
    25762576    case CSSPropertyWebkitMarginAfter:
    2577     case CSSPropertyWebkitMarginBeforeCollapse:
    2578     case CSSPropertyWebkitMarginTopCollapse:
    2579     case CSSPropertyWebkitMarginAfterCollapse:
    2580     case CSSPropertyWebkitMarginBottomCollapse:
    25812577    case CSSPropertyWebkitPaddingEnd:
    25822578    case CSSPropertyWebkitPaddingStart:
Note: See TracChangeset for help on using the changeset viewer.