Changeset 159915 in webkit


Ignore:
Timestamp:
Dec 2, 2013 1:08:31 AM (10 years ago)
Author:
commit-queue@webkit.org
Message:

HTML5 required attribute validation messages implemented.
https://bugs.webkit.org/show_bug.cgi?id=125003

Patch by Attila Dusnoki <adusnoki@inf.u-szeged.hu> on 2013-12-02
Reviewed by Gyuyoung Kim.

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageValueMissingForCheckboxText):
(WebCore::validationMessageValueMissingForFileText):
(WebCore::validationMessageValueMissingForMultipleFileText):
(WebCore::validationMessageValueMissingForRadioText):
(WebCore::validationMessageValueMissingForSelectText):
(WebCore::validationMessageBadInputForNumberText):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r159912 r159915  
     12013-12-02  Attila Dusnoki  <adusnoki@inf.u-szeged.hu>
     2
     3        HTML5 required attribute validation messages implemented.
     4        https://bugs.webkit.org/show_bug.cgi?id=125003
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        * platform/efl/LocalizedStringsEfl.cpp:
     9        (WebCore::validationMessagePatternMismatchText):
     10        (WebCore::validationMessageValueMissingText):
     11        (WebCore::validationMessageValueMissingForCheckboxText):
     12        (WebCore::validationMessageValueMissingForFileText):
     13        (WebCore::validationMessageValueMissingForMultipleFileText):
     14        (WebCore::validationMessageValueMissingForRadioText):
     15        (WebCore::validationMessageValueMissingForSelectText):
     16        (WebCore::validationMessageBadInputForNumberText):
     17
    1182013-12-01  Andreas Kling  <akling@apple.com>
    219
  • trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp

    r159561 r159915  
    529529String validationMessagePatternMismatchText()
    530530{
    531     return String::fromUTF8("pattern mismatch");
     531    return ASCIILiteral("Please match the requested format:");
    532532}
    533533
     
    574574String validationMessageValueMissingText()
    575575{
    576     return String::fromUTF8("value missing");
     576    return ASCIILiteral("Please fill out this field.");
    577577}
    578578
    579579String validationMessageValueMissingForCheckboxText()
    580580{
    581     notImplemented();
    582     return validationMessageValueMissingText();
     581    return ASCIILiteral("Please check this box if you want to proceed.");
    583582}
    584583
    585584String validationMessageValueMissingForFileText()
    586585{
    587     notImplemented();
    588     return validationMessageValueMissingText();
     586    return ASCIILiteral("Please select a file.");
    589587}
    590588
    591589String validationMessageValueMissingForMultipleFileText()
    592590{
    593     notImplemented();
    594     return validationMessageValueMissingText();
     591    return ASCIILiteral("Please select one or more files.");
    595592}
    596593
    597594String validationMessageValueMissingForRadioText()
    598595{
    599     notImplemented();
    600     return validationMessageValueMissingText();
     596    return ASCIILiteral("Please select one of these options.");
    601597}
    602598
    603599String validationMessageValueMissingForSelectText()
    604600{
    605     notImplemented();
    606     return validationMessageValueMissingText();
     601    return ASCIILiteral("Please select an item in the list.");
    607602}
    608603
    609604String validationMessageBadInputForNumberText()
    610605{
    611     notImplemented();
    612     return validationMessageTypeMismatchText();
     606    return ASCIILiteral("Please enter a number.");
    613607}
    614608
Note: See TracChangeset for help on using the changeset viewer.