Changeset 159938 in webkit


Ignore:
Timestamp:
Dec 2, 2013 9:20:52 AM (10 years ago)
Author:
lauro.neto@openbossa.org
Message:

[MediaStream] Update layout tests to newer spec.
https://bugs.webkit.org/show_bug.cgi?id=124985

Reviewed by Eric Carlson.

  • TestExpectations:
  • fast/mediastream/MediaStream-onended-expected.txt: Removed.
  • fast/mediastream/MediaStreamTrack-onended-expected.txt: Added.
  • fast/mediastream/MediaStreamTrack-onended.html: Renamed from LayoutTests/fast/mediastream/MediaStream-onended.html.
  • fast/mediastream/RTCPeerConnection-ice-expected.txt:
  • fast/mediastream/RTCPeerConnection-state-expected.txt:
  • fast/mediastream/RTCSessionDescription-expected.txt:
Location:
trunk/LayoutTests
Files:
1 added
1 deleted
5 edited
1 moved

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r159932 r159938  
     12013-12-02  Lauro Neto  <lauro.neto@openbossa.org>
     2
     3        [MediaStream] Update layout tests to newer spec.
     4        https://bugs.webkit.org/show_bug.cgi?id=124985
     5
     6        Reviewed by Eric Carlson.
     7
     8        * TestExpectations:
     9        * fast/mediastream/MediaStream-onended-expected.txt: Removed.
     10        * fast/mediastream/MediaStreamTrack-onended-expected.txt: Added.
     11        * fast/mediastream/MediaStreamTrack-onended.html: Renamed from LayoutTests/fast/mediastream/MediaStream-onended.html.
     12        * fast/mediastream/RTCPeerConnection-ice-expected.txt:
     13        * fast/mediastream/RTCPeerConnection-state-expected.txt:
     14        * fast/mediastream/RTCSessionDescription-expected.txt:
     15
    1162013-12-02  Chris Fleizach  <cfleizach@apple.com>
    217
  • trunk/LayoutTests/TestExpectations

    r159848 r159938  
    6666fast/mediastream/MediaStream-construct-with-ended-tracks.html [ Skip ]
    6767fast/mediastream/MediaStream-clone.html [ Skip ]
    68 
    69 # The spec is not clear if the MediaStream ended event should be fired if stop is called on each MediaStream's track
    70 # Skipping it for now, then put it again when the spec decides it
    71 fast/mediastream/MediaStream-onended.html [ Skip ]
  • trunk/LayoutTests/fast/mediastream/MediaStreamTrack-onended.html

    r159937 r159938  
    88        <div id="console"></div>
    99        <script>
    10             description("Tests MediaStream::onended callback.");
     10            description("Tests MediaStreamTrack::onended callback.");
    1111
    1212            function error() {
     
    2929                debug("");
    3030                testPassed('streamEnded2 was called.');
    31                 shouldBeTrue('stream.ended');
     31                shouldBeTrue('track.readyState == "ended"');
     32                shouldBeTrue('trackClone.readyState == "ended"');
    3233                finishJSTest();
    3334            }
     
    3738                testPassed('gotStream2 was called.');
    3839                stream = new webkitMediaStream(s);
    39                 shouldBeFalse('stream.ended');
     40                track = stream.getAudioTracks()[0];
     41                trackClone = track.clone();
     42                shouldBeFalse('track.readyState == "ended"');
     43                shouldBeFalse('trackClone.readyState == "ended"');
    4044                try {
    41                     stream.onended = streamEnded2;
    42                     stream.stop();
     45                    trackClone.onended = streamEnded2;
     46                    track.stop();
    4347                } catch (e) {
    4448                    testFailed('MediaStream threw exception :' + e);
     
    5054                debug("");
    5155                testPassed('streamEnded was called.');
    52                 shouldBeTrue('stream.ended');
     56                shouldBeTrue('track.readyState == "ended"');
     57                shouldBeTrue('trackClone.readyState == "ended"');
    5358
    5459                getUserMedia({audio:true, video:true}, gotStream2);
     
    5964                testPassed('gotStream was called.');
    6065                stream = s;
    61                 shouldBeFalse('stream.ended');
     66                // A second track is required as calling stop will not fire the ended
     67                // event on the object it was called.
     68                track = stream.getAudioTracks()[0];
     69                trackClone = track.clone();
     70                shouldBeFalse('track.readyState == "ended"');
     71                shouldBeFalse('trackClone.readyState == "ended"');
    6272                try {
    63                     stream.onended = streamEnded;
    64                     stream.stop();
     73                    trackClone.onended = streamEnded;
     74                    track.stop();
    6575                } catch (e) {
    6676                    testFailed('MediaStream threw exception :' + e);
  • trunk/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt

    r158964 r159938  
    44
    55
    6 PASS pc = new webkitRTCPeerConnection({iceServers:[]}, null); did not throw exception.
     6PASS pc = new webkitRTCPeerConnection({iceServers:[]}); did not throw exception.
    77PASS iceConnectionState is completed
    88PASS pc.addIceCandidate(null, null, null); threw exception TypeError: Type error.
  • trunk/LayoutTests/fast/mediastream/RTCPeerConnection-state-expected.txt

    r146582 r159938  
    44
    55
    6 PASS pc = new webkitRTCPeerConnection({iceServers:[]}, null); did not throw exception.
     6PASS pc = new webkitRTCPeerConnection({iceServers:[]}); did not throw exception.
    77PASS pc.signalingState is "stable"
    88PASS stateChanged was called
  • trunk/LayoutTests/fast/mediastream/RTCSessionDescription-expected.txt

    r159230 r159938  
    1212PASS sessionDescription.type is "offer"
    1313PASS sessionDescription.sdp is "foobar"
    14 PASS new RTCSessionDescription(null); threw exception TypeError: Optional description init argument of RTCSessionDescription must be a valid Dictionary.
    15 PASS new RTCSessionDescription(5); threw exception TypeError: Optional description init argument of RTCSessionDescription must be a valid Dictionary.
    16 PASS new RTCSessionDescription('foobar'); threw exception TypeError: Optional description init argument of RTCSessionDescription must be a valid Dictionary.
     14PASS new RTCSessionDescription(null); threw exception TypeError: Optional RTCSessionDescription constructor argument must be a valid Dictionary.
     15PASS new RTCSessionDescription(5); threw exception TypeError: Optional RTCSessionDescription constructor argument must be a valid Dictionary.
     16PASS new RTCSessionDescription('foobar'); threw exception TypeError: Optional RTCSessionDescription constructor argument must be a valid Dictionary.
    1717PASS new RTCSessionDescription({type:'foobar', sdp:'x'}); threw exception TypeError: Invalid RTCSessionDescription constructor arguments.
    1818PASS new RTCSessionDescription({type:'offer', sdp:''}); threw exception TypeError: Invalid RTCSessionDescription constructor arguments.
Note: See TracChangeset for help on using the changeset viewer.