Changeset 159996 in webkit

Timestamp:

Dec 3, 2013 2:29:47 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Add spatial navigation API in EFL port
​https://bugs.webkit.org/show_bug.cgi?id=125002

Patch by Dariusz Frankiewicz <Dariusz Frankiewicz> on 2013-12-03
Reviewed by Gyuyoung Kim.

API enables capability of turning on and off spatial navigation
and check is state.
Spatial navigation is the ability to navigate between focusable
elements by keyboard.

• UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_spatial_navigation_enabled_set):
(ewk_settings_spatial_navigation_enabled_get):

• UIProcess/API/efl/ewk_settings.h:
• UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/efl/ewk_settings.cpp (modified) (1 diff)
• UIProcess/API/efl/ewk_settings.h (modified) (1 diff)
• UIProcess/API/efl/tests/test_ewk2_settings.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-12-03  Dariusz Frankiewicz  <d.frankiewic@samsung.com>
+
+        Add spatial navigation API in EFL port
+        https://bugs.webkit.org/show_bug.cgi?id=125002
+
+        Reviewed by Gyuyoung Kim.
+
+        API enables capability of turning on and off spatial navigation
+        and check is state.
+        Spatial navigation is the ability to navigate between focusable
+        elements by keyboard.
+
+        * UIProcess/API/efl/ewk_settings.cpp:
+        (ewk_settings_spatial_navigation_enabled_set):
+        (ewk_settings_spatial_navigation_enabled_get):
+        * UIProcess/API/efl/ewk_settings.h:
+        * UIProcess/API/efl/tests/test_ewk2_settings.cpp:
+        (TEST_F):
+
 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp

@@ -319 +319 @@
 }
 
+Eina_Bool ewk_settings_spatial_navigation_enabled_set(Ewk_Settings* settings, Eina_Bool enable)
+{
+    EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
+
+    settings->preferences()->setSpatialNavigationEnabled(enable);
+
+    return true;
+}
+
+Eina_Bool ewk_settings_spatial_navigation_enabled_get(const Ewk_Settings* settings)
+{
+    EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
+
+    return settings->preferences()->spatialNavigationEnabled();
+}

trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h

@@ -445 +445 @@
 EAPI Eina_Bool ewk_settings_text_autosizing_enabled_get(const Ewk_Settings *settings);
 
+/**
+ * Changes spatial navigation state.
+ *
+ * @param settings settings object to enable/disable spatial navigation
+ * @param enabled @c EINA_TRUE to enable spatial navigation
+ *                @c EINA_FALSE to disable spatial navigation
+ *
+ * @return @c EINA_TRUE on success or @c EINA_FALSE on failure
+ */
+EAPI Eina_Bool ewk_settings_spatial_navigation_enabled_set(Ewk_Settings *settings, Eina_Bool enable);
+
+/**
+ * Returns current state of spatial navigation.
+ *
+ * @param settings settings object to get whether spatial navigation is enabled
+ *
+ * @return @c EINA_TRUE if spatial navigation is enabled
+ *         @c EINA_FALSE if spatial navigation is disabled
+ */
+EAPI Eina_Bool ewk_settings_spatial_navigation_enabled_get(const Ewk_Settings *settings);
+
 #ifdef __cplusplus
 }

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp

@@ -288 +288 @@
 #endif
 }
+
+TEST_F(EWK2UnitTestBase, ewk_settings_spatial_navigation_enabled)
+{
+    Ewk_Settings* settings = ewk_view_settings_get(webView());
+
+    // Spatial navigation is disabled by default.
+    ASSERT_FALSE(ewk_settings_spatial_navigation_enabled_get(settings));
+
+    ASSERT_TRUE(ewk_settings_spatial_navigation_enabled_set(settings, true));
+    ASSERT_TRUE(ewk_settings_spatial_navigation_enabled_get(settings));
+
+    ASSERT_TRUE(ewk_settings_spatial_navigation_enabled_set(settings, false));
+    ASSERT_FALSE(ewk_settings_spatial_navigation_enabled_get(settings));
+}