Changeset 160006 in webkit

Timestamp:

Dec 3, 2013 9:15:18 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Remove function from TextChecker
​https://bugs.webkit.org/show_bug.cgi?id=125148

Patch by Tamas Gergely <​tgergely.u-szeged@partner.samsung.com> on 2013-12-03
Reviewed by Darin Adler.

The process_file_data is used only from the unit tests, so it is simply moved there.

• Scripts/webkitpy/style/checkers/text.py:

(TextChecker.check):

• Scripts/webkitpy/style/checkers/text_unittest.py:

(TextStyleTestCase.process_file_data):
(TextStyleTestCase.assertNoError):
(TextStyleTestCase.assertError):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checkers/text.py (modified) (1 diff)
• Scripts/webkitpy/style/checkers/text_unittest.py (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
+
+        Remove function from TextChecker
+        https://bugs.webkit.org/show_bug.cgi?id=125148
+
+        Reviewed by Darin Adler.
+
+        The process_file_data is used only from the unit tests, so it is simply moved there.
+
+        * Scripts/webkitpy/style/checkers/text.py:
+        (TextChecker.check):
+        * Scripts/webkitpy/style/checkers/text_unittest.py:
+        (TextStyleTestCase.process_file_data):
+        (TextStyleTestCase.assertNoError):
+        (TextStyleTestCase.assertError):
+
 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
 

trunk/Tools/Scripts/webkitpy/style/checkers/text.py

@@ -43 +43 @@
     def check(self, lines):
         self._tab_checker.check(lines)
-
-
-# FIXME: Remove this function (requires refactoring unit tests).
-def process_file_data(filename, lines, error):
-    checker = TextChecker(filename, error)
-    checker.check(lines)
-

trunk/Tools/Scripts/webkitpy/style/checkers/text_unittest.py

@@ -37 +37 @@
     """TestCase for text_style.py"""
 
+    def process_file_data(self, filename, lines, error):
+        checker = TextChecker(filename, error)
+        checker.check(lines)
+
     def assertNoError(self, lines):
         """Asserts that the specified lines has no errors."""
@@ -45 +49 @@
             self.had_error = True
 
-        text_style.process_file_data('', lines, error_for_test)
+        self.process_file_data('', lines, error_for_test)
         self.assertFalse(self.had_error, '%s should not have any errors.' % lines)
 
@@ -58 +62 @@
             self.had_error = True
 
-        text_style.process_file_data('', lines, error_for_test)
+        self.process_file_data('', lines, error_for_test)
         self.assertTrue(self.had_error, '%s should have an error [whitespace/tab].' % lines)