Changeset 160093 in webkit

Timestamp:

Dec 4, 2013 8:13:53 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Style checker for .messages.in files (WTF:: prefix)
​https://bugs.webkit.org/show_bug.cgi?id=125142

Patch by Tamas Gergely <​tgergely.u-szeged@partner.samsung.com> on 2013-12-04
Reviewed by Anders Carlsson.

A new style checker for .messages.in files, that checks for the use of WTF::
prefix in these files. (Also checks for tabs as these files were previously
handled as text files.)

• Scripts/webkitpy/style/checker.py:

(CheckerDispatcher._create_checker):

New checker is returned for .messages.in files.

• Scripts/webkitpy/style/checkers/messagesin.py: Added. The new style checker class.

(MessagesInChecker):
(MessagesInChecker.init):
(MessagesInChecker.check):
(MessagesInChecker.check_WTF_prefix):

• Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added. Unit test for the new style checker class.

(MessagesInCheckerStyleTestCase):
(test_checker):
(test_checker.error_handler_for_test):
(MessagesInCheckerTestCase):
(MessagesInCheckerTestCase.test_init):
(MessagesInCheckerTestCase.test_init.error_handler_for_test):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checker.py (modified) (2 diffs)
• Scripts/webkitpy/style/checkers/messagesin.py (added)
• Scripts/webkitpy/style/checkers/messagesin_unittest.py (added)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
+
+        Style checker for .messages.in files (WTF:: prefix)
+        https://bugs.webkit.org/show_bug.cgi?id=125142
+
+        Reviewed by Anders Carlsson.
+
+        A new style checker for .messages.in files, that checks for the use of WTF::
+        prefix in these files. (Also checks for tabs as these files were previously
+        handled as text files.)
+
+        * Scripts/webkitpy/style/checker.py:
+        (CheckerDispatcher._create_checker):
+          New checker is returned for .messages.in files.
+        * Scripts/webkitpy/style/checkers/messagesin.py: Added.
+          The new style checker class.
+        (MessagesInChecker):
+        (MessagesInChecker.__init__):
+        (MessagesInChecker.check):
+        (MessagesInChecker.check_WTF_prefix):
+        * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
+          Unit test for the new style  checker class.
+        (MessagesInCheckerStyleTestCase):
+        (test_checker):
+        (test_checker.error_handler_for_test):
+        (MessagesInCheckerTestCase):
+        (MessagesInCheckerTestCase.test_init):
+        (MessagesInCheckerTestCase.test_init.error_handler_for_test):
+
 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
 

trunk/Tools/Scripts/webkitpy/style/checker.py

@@ -45 +45 @@
 from checkers.jsonchecker import JSONChecker
 from checkers.jsonchecker import JSONContributorsChecker
+from checkers.messagesin import MessagesInChecker
 from checkers.png import PNGChecker
 from checkers.python import PythonChecker
@@ -635 +636 @@
             if basename == 'TestExpectations':
                 checker = TestExpectationsChecker(file_path, handle_style_error)
+            elif file_path.endswith('.messages.in'):
+                checker = MessagesInChecker(file_path, handle_style_error)
             else:
                 checker = TextChecker(file_path, handle_style_error)