Changeset 160116 in webkit

Timestamp:

Dec 4, 2013 12:43:21 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Use ThreadingOnce class to encapsulate pthread_once functionality.
​https://bugs.webkit.org/show_bug.cgi?id=125228

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-12-04
Reviewed by Brent Fulgham.

• runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/InitializeThreading.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-12-04  peavo@outlook.com  <peavo@outlook.com>
+
+        Use ThreadingOnce class to encapsulate pthread_once functionality.
+        https://bugs.webkit.org/show_bug.cgi?id=125228
+
+        Reviewed by Brent Fulgham.
+
+        * runtime/InitializeThreading.cpp:
+        (JSC::initializeThreading):
+
 2013-12-04  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/runtime/InitializeThreading.cpp

@@ -42 +42 @@
 #include <wtf/dtoa.h>
 #include <wtf/Threading.h>
+#include <wtf/ThreadingOnce.h>
 #include <wtf/dtoa/cached-powers.h>
 
@@ -47 +48 @@
 
 namespace JSC {
-
-#if OS(DARWIN)
-static pthread_once_t initializeThreadingKeyOnce = PTHREAD_ONCE_INIT;
-#endif
 
 static void initializeThreadingOnce()
@@ -77 +74 @@
 void initializeThreading()
 {
-#if OS(DARWIN)
-    pthread_once(&initializeThreadingKeyOnce, initializeThreadingOnce);
-#else
-    static bool initializedThreading = false;
-    if (!initializedThreading) {
-        initializeThreadingOnce();
-        initializedThreading = true;
-    }
-#endif
+    static WTF::ThreadingOnce initializeThreadingKeyOnce;
+    initializeThreadingKeyOnce.callOnce(initializeThreadingOnce);
 }