Changeset 160146 in webkit


Ignore:
Timestamp:
Dec 4, 2013 5:26:14 PM (10 years ago)
Author:
andersca@apple.com
Message:

Add a WeakObjCPtr class
​https://bugs.webkit.org/show_bug.cgi?id=125267

Reviewed by Geoffrey Garen.

Source/WebKit2:

WeakObjCPtr is a zeroing weak reference class template that will be used for delegates.

  • Shared/mac/WeakObjCPtr.h: Added.

(WebKit::WeakObjCPtr::WeakObjCPtr):
(WebKit::WeakObjCPtr::~WeakObjCPtr):
(WebKit::WeakObjCPtr::operator=):
(WebKit::WeakObjCPtr::get):

  • WebKit2.xcodeproj/project.pbxproj:

Tools:

Add API tests for WeakObjCPtr.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.

(TEST):

Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r160141 r160146  
     12013-12-04  Anders Carlsson  <andersca@apple.com>
     2
     3        Add a WeakObjCPtr class
     4        https://bugs.webkit.org/show_bug.cgi?id=125267
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        WeakObjCPtr is a zeroing weak reference class template that will be used for delegates.
     9
     10        * Shared/mac/WeakObjCPtr.h: Added.
     11        (WebKit::WeakObjCPtr::WeakObjCPtr):
     12        (WebKit::WeakObjCPtr::~WeakObjCPtr):
     13        (WebKit::WeakObjCPtr::operator=):
     14        (WebKit::WeakObjCPtr::get):
     15        * WebKit2.xcodeproj/project.pbxproj:
     16
    1172013-12-04  Ryuan Choi  <ryuan.choi@samsung.com>
    218

  • trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj

    r160117 r160146  
    224224                1AA5889211EE70400061B882 /* NetscapePluginStream.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AA5889011EE70400061B882 /* NetscapePluginStream.h */; };
    225225                1AA5889311EE70400061B882 /* NetscapePluginStream.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AA5889111EE70400061B882 /* NetscapePluginStream.cpp */; };
     226                1AA9BAE1184FFAC7003B6BC6 /* WeakObjCPtr.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AA9BAE0184FFAC7003B6BC6 /* WeakObjCPtr.h */; settings = {ATTRIBUTES = (Private, ); }; };
    226227                1AAB4A8D1296F0A20023952F /* SandboxExtension.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AAB4A8C1296F0A20023952F /* SandboxExtension.h */; };
    227228                1AAB4AAA1296F1540023952F /* SandboxExtensionMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1AAB4AA91296F1540023952F /* SandboxExtensionMac.mm */; };
    … …  
    17411742                1AA5889011EE70400061B882 /* NetscapePluginStream.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NetscapePluginStream.h; sourceTree = "<group>"; };
    17421743                1AA5889111EE70400061B882 /* NetscapePluginStream.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = NetscapePluginStream.cpp; sourceTree = "<group>"; };
     1744                1AA9BAE0184FFAC7003B6BC6 /* WeakObjCPtr.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WeakObjCPtr.h; sourceTree = "<group>"; };
    17431745                1AAB4A8C1296F0A20023952F /* SandboxExtension.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SandboxExtension.h; sourceTree = "<group>"; };
    17441746                1AAB4AA91296F1540023952F /* SandboxExtensionMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = SandboxExtensionMac.mm; sourceTree = "<group>"; };
    … …  
    47584760                                511F8A77138B460900A95F44 /* SecItemShimLibrary.h */,
    47594761                                511F8A78138B460900A95F44 /* SecItemShimLibrary.mm */,
     4762                                1AA9BAE0184FFAC7003B6BC6 /* WeakObjCPtr.h */,
    47604763                                BCE23262122C6CF300D5C35A /* WebCoreArgumentCodersMac.mm */,
    47614764                                BC111B5B112F629800337BAB /* WebEventFactory.h */,
    … …  
    56655668                                84477853176FCC0800CDC7BB /* InjectedBundleHitTestResultMediaType.h in Headers */,
    56665669                                BC8147D512F66D31007B2C32 /* InjectedBundleNavigationAction.h in Headers */,
     5670                                1AA9BAE1184FFAC7003B6BC6 /* WeakObjCPtr.h in Headers */,
    56675671                                BC4BEEAB120A0A5F00FBA0C7 /* InjectedBundleNodeHandle.h in Headers */,
    56685672                                378E1A4E18208D700031007A /* WKNSURL.h in Headers */,

  • trunk/Tools/ChangeLog

    r160137 r160146  
     12013-12-04  Anders Carlsson  <andersca@apple.com>
     2
     3        Add a WeakObjCPtr class
     4        https://bugs.webkit.org/show_bug.cgi?id=125267
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Add API tests for WeakObjCPtr.
     9
     10        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
     11        * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
     12        (TEST):
     13
    1142013-12-04  Anders Carlsson  <andersca@apple.com>
    215

  • trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

    r159586 r160146  
    2727                1A9E32941821945C00F5D04C /* WKRemoteObjectRegistry_Bundle.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A9E32921821945C00F5D04C /* WKRemoteObjectRegistry_Bundle.mm */; };
    2828                1A9E52C913E65EF4006917F5 /* 18-characters.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = C045F9461385C2F800C0F3CD /* 18-characters.html */; };
     29                1AA9BAE418500450003B6BC6 /* WeakObjCPtr.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1AA9BAE218500450003B6BC6 /* WeakObjCPtr.mm */; };
    2930                1AA9E55914980A9900001A8A /* Functional.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AA9E55714980A9900001A8A /* Functional.cpp */; };
    3031                1ADBEFAE130C689C00D61D19 /* ForceRepaint.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1ADBEFAD130C689C00D61D19 /* ForceRepaint.cpp */; };
    … …  
    351352                1A9E32921821945C00F5D04C /* WKRemoteObjectRegistry_Bundle.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = WKRemoteObjectRegistry_Bundle.mm; path = mac/WKRemoteObjectRegistry_Bundle.mm; sourceTree = "<group>"; };
    352353                1A9E329518219AE100F5D04C /* WKRemoteObjectRegistry_Shared.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = WKRemoteObjectRegistry_Shared.h; path = mac/WKRemoteObjectRegistry_Shared.h; sourceTree = "<group>"; };
     354                1AA9BAE218500450003B6BC6 /* WeakObjCPtr.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WeakObjCPtr.mm; sourceTree = "<group>"; };
    353355                1AA9E55714980A9900001A8A /* Functional.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Functional.cpp; sourceTree = "<group>"; };
    354356                1ADBEFAD130C689C00D61D19 /* ForceRepaint.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ForceRepaint.cpp; sourceTree = "<group>"; };
    … …  
    10451047                                C0C5D3BD14598B6F00A802A6 /* GetBackingScaleFactor_Bundle.mm */,
    10461048                                1AEF994817A09F5300998EF0 /* GetPIDAfterAbortedProcessLaunch.cpp */,
     1049                                1AA9BAE218500450003B6BC6 /* WeakObjCPtr.mm */,
    10471050                        );
    10481051                        path = mac;
    … …  
    12791282                                37E38C34169B7D010084C28C /* WebViewDidRemoveFrameFromHierarchy.mm in Sources */,
    12801283                                76E182DA1547550100F1FADD /* WillSendSubmitEvent.cpp in Sources */,
     1284                                1AA9BAE418500450003B6BC6 /* WeakObjCPtr.mm in Sources */,
    12811285                                A5E2027315B2181900C13E14 /* WindowlessWebViewWithMedia.mm in Sources */,
    12821286                                F6B7BE9417469209008A3445 /* DidAssociateFormControls.cpp in Sources */,
Note: See TracChangeset for help on using the changeset viewer.