Changeset 160160 in webkit

Timestamp:

Dec 4, 2013 10:44:39 PM (10 years ago)

Author:

Samuel White

Message:

Layout Test platform/mac/accessibility/search-predicate-element-count.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=125195

Reviewed by Chris Fleizach.

Our test checks for AccessibilityObject::isOnscreen which makes sure an element is currently scrolled to a visible
location onscreen. This test was flaky because sometimes elements we thought would be visible weren't. To resolve
this I've moved the elements that are tested for visibility to the very top of the document so they have a tiny
vertical offset and will ALWAYS be visible.

• platform/mac/TestExpectations:
• platform/mac/accessibility/search-predicate-element-count-expected.txt:
• platform/mac/accessibility/search-predicate-element-count.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)
• platform/mac/accessibility/search-predicate-element-count-expected.txt (modified) (1 diff)
• platform/mac/accessibility/search-predicate-element-count.html (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-12-04  Samuel White  <samuel_white@apple.com>
+
+        Layout Test platform/mac/accessibility/search-predicate-element-count.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=125195
+
+        Reviewed by Chris Fleizach.
+
+        Our test checks for AccessibilityObject::isOnscreen which makes sure an element is currently scrolled to a visible
+        location onscreen. This test was flaky because sometimes elements we thought would be visible weren't. To resolve
+        this I've moved the elements that are tested for visibility to the very top of the document so they have a tiny
+        vertical offset and will ALWAYS be visible.
+
+        * platform/mac/TestExpectations:
+        * platform/mac/accessibility/search-predicate-element-count-expected.txt:
+        * platform/mac/accessibility/search-predicate-element-count.html:
+
 2013-12-04  Gurpreet Kaur  <k.gurpreet@samsung.com>
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1308 +1308 @@
 
 webkit.org/b/124593 fast/forms/form-associated-element-crash.html [ Pass Timeout ]
-
-webkit.org/b/125195 platform/mac/accessibility/search-predicate-element-count.html [ Pass Failure ]

trunk/LayoutTests/platform/mac/accessibility/search-predicate-element-count-expected.txt

@@ -4 +4 @@
 
 
-PASS elementCount is 2
-PASS elementCount is 3
-PASS elementCount is 4
-PASS elementCount is 5
-PASS elementCount is 6
-PASS elementCount is 6
-PASS elementCount is 4
+PASS tableCount is 2
+PASS linkCount is 3
+PASS imageCount is 4
+PASS inputCount is 5
+PASS headingCount is 6
+PASS onscreenCount is 6
+PASS offscreenCount is 4
 PASS successfullyParsed is true
 

trunk/LayoutTests/platform/mac/accessibility/search-predicate-element-count.html

@@ -15 +15 @@
 <div id="container">
 <p id="start">Start</p>
+<!-- Headings. -->
+<h1>Heading 1</h1>
+<h2>Heading 2</h2>
+<h3>Heading 3</h3>
+<h4>Heading 4</h4>
+<h5 class="offscreen">Heading 5</h5>
+<h6 class="offscreen">Heading 6</h6>
+<br>
 <!-- Tables. -->
 <table border="1">
@@ -42 +50 @@
 <input type="submit" value="Submit">
 <input type="submit" value="Submit">
-<br>
-<!-- Headings. -->
-<h1>Heading 1</h1>
-<h2>Heading 2</h2>
-<h3>Heading 3</h3>
-<h4>Heading 4</h4>
-<h5 class="offscreen">Heading 5</h5>
-<h6 class="offscreen">Heading 6</h6>
 </div>
 
@@ -61 +61 @@
         document.getElementById("container").focus();
         var containerElement = accessibilityController.focusedElement;
-        var elementCount = 0;
         var startElement = accessibilityController.accessibleElementById("start");
         
         // Tables.
-        elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXTableSearchKey", "", false);
-        shouldBe("elementCount", "2");
+        var tableCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXTableSearchKey", "", false);
+        shouldBe("tableCount", "2");
         
         // Links.
-        elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXLinkSearchKey", "", false);
-        shouldBe("elementCount", "3");
+        var linkCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXLinkSearchKey", "", false);
+        shouldBe("linkCount", "3");
         
         // Images.
-        elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXGraphicSearchKey", "", false);
-        shouldBe("elementCount", "4");
+        var imageCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXGraphicSearchKey", "", false);
+        shouldBe("imageCount", "4");
         
         // Inputs.
-        elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXButtonSearchKey", "", false);
-        shouldBe("elementCount", "5");
+        var inputCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXButtonSearchKey", "", false);
+        shouldBe("inputCount", "5");
         
         // Headings.
-        elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXHeadingSearchKey", "", false);
-        shouldBe("elementCount", "6");
+        var headingCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXHeadingSearchKey", "", false);
+        shouldBe("headingCount", "6");
         
         // Onscreen
-        elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXHeadingSearchKey", "", false);
-        shouldBe("elementCount", "6");
+        var onscreenCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXHeadingSearchKey", "", false);
+        shouldBe("onscreenCount", "6");
         
         // Offscreen
-        elementCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXHeadingSearchKey", "", true);
-        shouldBe("elementCount", "4");
+        var offscreenCount = containerElement.uiElementCountForSearchPredicate(startElement, true, "AXHeadingSearchKey", "", true);
+        shouldBe("offscreenCount", "4");
         
         // Hide superfluous text.