Changeset 160202 in webkit

Timestamp:

Dec 5, 2013 4:57:43 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: expose node and frame snapshot capabilities.
​https://bugs.webkit.org/show_bug.cgi?id=124326

Patch by Brian J. Burg <Brian Burg> on 2013-12-05
Reviewed by Joseph Pecoraro.

Source/WebCore:

This adds snapshotRect() and snapshotNode() to the Page domain.
Both methods create snapshots using FrameSnapshotting APIs
and send images to the inspector frontend as a data URL.

Remove the unimplemented Page.captureScreenshot API.

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::snapshotNode): Added.
(WebCore::InspectorPageAgent::snapshotRect): Added.

• inspector/InspectorPageAgent.h:
• inspector/protocol/Page.json: Added new protocol APIs.

Source/WebInspectorUI:

Add method signatures for snapshotNode() and snapshotRect().
Remove method signature for unimplemented Page.captureScreenshot.

• UserInterface/InspectorBackendCommands.js:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/inspector/InspectorPageAgent.cpp (modified) (3 diffs)
• WebCore/inspector/InspectorPageAgent.h (modified) (1 diff)
• WebCore/inspector/protocol/Page.json (modified) (2 diffs)
• WebInspectorUI/ChangeLog (modified) (1 diff)
• WebInspectorUI/UserInterface/InspectorBackendCommands.js (modified) (3 diffs)
• WebInspectorUI/UserInterface/Legacy/7.0/InspectorBackendCommands.js (modified) (2 diffs)
• WebInspectorUI/Versions/Inspector-iOS-7.0.json (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-12-05  Brian J. Burg  <burg@cs.washington.edu>
+
+        Web Inspector: expose node and frame snapshot capabilities.
+        https://bugs.webkit.org/show_bug.cgi?id=124326
+
+        Reviewed by Joseph Pecoraro.
+
+        This adds snapshotRect() and snapshotNode() to the Page domain.
+        Both methods create snapshots using FrameSnapshotting APIs
+        and send images to the inspector frontend as a data URL.
+
+        Remove the unimplemented Page.captureScreenshot API.
+
+        * inspector/InspectorPageAgent.cpp:
+        (WebCore::InspectorPageAgent::snapshotNode): Added.
+        (WebCore::InspectorPageAgent::snapshotRect): Added.
+        * inspector/InspectorPageAgent.h:
+        * inspector/protocol/Page.json: Added new protocol APIs.
+
 2013-12-04 Bear Travis <betravis@adobe.com>
 

trunk/Source/WebCore/inspector/InspectorPageAgent.cpp

@@ -52 +52 @@
 #include "Frame.h"
 #include "FrameLoader.h"
+#include "FrameSnapshotting.h"
 #include "FrameView.h"
 #include "GeolocationController.h"
@@ -58 +59 @@
 #include "HTMLNames.h"
 #include "IdentifiersFactory.h"
+#include "ImageBuffer.h"
 #include "InjectedScriptManager.h"
 #include "InspectorAgent.h"
 #include "InspectorClient.h"
+#include "InspectorDOMAgent.h"
 #include "InspectorFrontend.h"
 #include "InspectorInstrumentation.h"
@@ -1252 +1255 @@
 }
 
-void InspectorPageAgent::captureScreenshot(ErrorString* errorString, String* data)
-{
-    if (!m_client->captureScreenshot(data))
-        *errorString = "Could not capture screenshot";
+void InspectorPageAgent::snapshotNode(ErrorString* errorString, int nodeId, String* outDataURL)
+{
+    Frame* frame = mainFrame();
+    ASSERT(frame);
+
+    InspectorDOMAgent* domAgent = m_instrumentingAgents->inspectorDOMAgent();
+    ASSERT(domAgent);
+    Node* node = domAgent->assertNode(errorString, nodeId);
+    if (!node)
+        return;
+
+    std::unique_ptr<ImageBuffer> snapshot = WebCore::snapshotNode(*frame, *node);
+    if (!snapshot) {
+        *errorString = ASCIILiteral("Could not capture snapshot");
+        return;
+    }
+
+    *outDataURL = snapshot->toDataURL(ASCIILiteral("image/png"));
+}
+
+void InspectorPageAgent::snapshotRect(ErrorString* errorString, int x, int y, int width, int height, const String& coordinateSystem, String* outDataURL)
+{
+    Frame* frame = mainFrame();
+    ASSERT(frame);
+
+    SnapshotOptions options = SnapshotOptionsNone;
+    if (coordinateSystem == "Viewport")
+        options |= SnapshotOptionsInViewCoordinates;
+
+    IntRect rectangle(x, y, width, height);
+    std::unique_ptr<ImageBuffer> snapshot = snapshotFrameRect(*frame, rectangle, options);
+
+    if (!snapshot) {
+        *errorString = ASCIILiteral("Could not capture snapshot");
+        return;
+    }
+
+    *outDataURL = snapshot->toDataURL(ASCIILiteral("image/png"));
 }
 

trunk/Source/WebCore/inspector/InspectorPageAgent.h

@@ -130 +130 @@
     virtual void getCompositingBordersVisible(ErrorString*, bool* out_param);
     virtual void setCompositingBordersVisible(ErrorString*, bool);
-    virtual void captureScreenshot(ErrorString*, String* data);
+    virtual void snapshotNode(ErrorString*, int nodeId, String* outDataURL);
+    virtual void snapshotRect(ErrorString*, int x, int y, int width, int height, const String& coordinateSystem, String* outDataURL);
     virtual void handleJavaScriptDialog(ErrorString*, bool accept, const String* promptText);
     virtual void archive(ErrorString*, String* data);

trunk/Source/WebCore/inspector/protocol/Page.json

@@ -8 +8 @@
             "enum": ["Document", "Stylesheet", "Image", "Font", "Script", "XHR", "WebSocket", "Other"],
             "description": "Resource type as it was perceived by the rendering engine."
+        },
+        {
+            "id": "CoordinateSystem",
+            "type": "string",
+            "enum": ["Viewport", "Page"],
+            "description": "Coordinate system used by supplied coordinates."
         },
         {
@@ -345 +351 @@
         },
         {
-            "name": "captureScreenshot",
-            "description": "Capture page screenshot.",
-            "returns": [
-                { "name": "data", "type": "string", "description": "Base64-encoded image data (PNG)." }
+            "name": "snapshotNode",
+            "description": "Capture a snapshot of the specified node that does not include unrelated layers.",
+            "parameters": [
+                { "name": "nodeId", "$ref": "DOM.NodeId", "description": "Id of the node to snapshot." }
+            ],
+            "returns": [
+                { "name": "dataURL", "type": "string", "description": "Base64-encoded image data (PNG)." }
+            ]
+        },
+        {
+            "name": "snapshotRect",
+            "description": "Capture a snapshot of the page within the specified rectangle and coordinate system.",
+            "parameters": [
+                { "name": "x", "type": "integer", "description": "X coordinate" },
+                { "name": "y", "type": "integer", "description": "Y coordinate" },
+                { "name": "width", "type": "integer", "description": "Rectangle width" },
+                { "name": "height", "type": "integer", "description": "Rectangle height" },
+                { "name": "coordinateSystem", "$ref": "CoordinateSystem", "description": "Indicates the coordinate system of the supplied rectangle." }
+            ],
+            "returns": [
+                { "name": "dataURL", "type": "string", "description": "Base64-encoded image data (PNG)." }
             ]
         },

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2013-12-05  Brian J. Burg  <burg@cs.washington.edu>
+
+        Web Inspector: expose node and frame snapshot capabilities.
+        https://bugs.webkit.org/show_bug.cgi?id=124326
+
+        Reviewed by Joseph Pecoraro.
+
+        Add method signatures for snapshotNode() and snapshotRect().
+        Remove method signature for unimplemented Page.captureScreenshot.
+
+        * UserInterface/InspectorBackendCommands.js:
+
 2013-12-05  Alexandru Chiculita  <achicu@adobe.com>
 

trunk/Source/WebInspectorUI/UserInterface/InspectorBackendCommands.js

@@ -1 +1 @@
 // File is generated by Source/WebCore/inspector/CodeGeneratorInspector.py
 
+// Copyright (c) 2013 Apple Inc. All Rights Reserved.
 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
@@ -290 +291 @@
 InspectorBackend.registerPageDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "Page");
 InspectorBackend.registerEnum("Page.ResourceType", {Document: "Document", Stylesheet: "Stylesheet", Image: "Image", Font: "Font", Script: "Script", XHR: "XHR", WebSocket: "WebSocket", Other: "Other"});
+InspectorBackend.registerEnum("Page.CoordinateSystem", {Viewport: "Viewport", Page: "Page"});
 InspectorBackend.registerEvent("Page.domContentEventFired", ["timestamp"]);
 InspectorBackend.registerEvent("Page.loadEventFired", ["timestamp"]);
@@ -335 +337 @@
 InspectorBackend.registerCommand("Page.getCompositingBordersVisible", [], ["result"]);
 InspectorBackend.registerCommand("Page.setCompositingBordersVisible", [{"name": "visible", "type": "boolean", "optional": false}], []);
-InspectorBackend.registerCommand("Page.captureScreenshot", [], ["data"]);
+InspectorBackend.registerCommand("Page.snapshotNode", [{"name": "nodeId", "type": "number", "optional": false}], ["dataURL"]);
+InspectorBackend.registerCommand("Page.snapshotRect", [{"name": "x", "type": "number", "optional": false}, {"name": "y", "type": "number", "optional": false}, {"name": "width", "type": "number", "optional": false}, {"name": "height", "type": "number", "optional": false}, {"name": "coordinateSystem", "type": "string", "optional": false}], ["dataURL"]);
 InspectorBackend.registerCommand("Page.handleJavaScriptDialog", [{"name": "accept", "type": "boolean", "optional": false}, {"name": "promptText", "type": "string", "optional": true}], []);
 InspectorBackend.registerCommand("Page.archive", [], ["data"]);

trunk/Source/WebInspectorUI/UserInterface/Legacy/7.0/InspectorBackendCommands.js

@@ -1 +1 @@
 // File is generated by Source/WebCore/inspector/CodeGeneratorInspector.py
 
+// Copyright (c) 2013 Apple Inc. All Rights Reserved.
 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
@@ -67 +68 @@
 InspectorBackend.registerCommand("Page.getCompositingBordersVisible", [], ["result"]);
 InspectorBackend.registerCommand("Page.setCompositingBordersVisible", [{"name": "visible", "type": "boolean", "optional": false}], []);
-InspectorBackend.registerCommand("Page.captureScreenshot", [], ["data"]);
 InspectorBackend.registerCommand("Page.handleJavaScriptDialog", [{"name": "accept", "type": "boolean", "optional": false}, {"name": "promptText", "type": "string", "optional": true}], []);
 

trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json

@@ -409 +409 @@
                 "parameters": [
                     { "name": "visible", "type": "boolean", "description": "True for showing compositing borders." }
-                ]
-            },
-            {
-                "name": "captureScreenshot",
-                "description": "Capture page screenshot.",
-                "returns": [
-                    { "name": "data", "type": "string", "description": "Base64-encoded image data (PNG)." }
                 ]
             },