Changeset 160203 in webkit


Ignore:
Timestamp:
Dec 5, 2013 5:09:09 PM (10 years ago)
Author:
Seokju Kwon
Message:

Web Inspector: Remove 'cookiesString' output from Page.getCookies
​https://bugs.webkit.org/show_bug.cgi?id=125268

Reviewed by Timothy Hatcher.

Remove 'cookiesString' output from Page.getCookies protocol.
It is no longer meaningful because it is an unused parameter.

Source/WebCore:

No new tests, no behavior change.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):

  • inspector/InspectorPageAgent.h:
  • inspector/protocol/Page.json:

Source/WebInspectorUI:

  • UserInterface/CookieStorageContentView.js:

(WebInspector.CookieStorageContentView.prototype.update):

  • UserInterface/InspectorBackendCommands.js:
Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r160202 r160203  
     12013-12-05  Seokju Kwon  <seokju@webkit.org>
     2
     3        Web Inspector: Remove 'cookiesString' output from Page.getCookies
     4        https://bugs.webkit.org/show_bug.cgi?id=125268
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        Remove 'cookiesString' output from Page.getCookies protocol.
     9        It is no longer meaningful because it is an unused parameter.
     10
     11        No new tests, no behavior change.
     12
     13        * inspector/InspectorPageAgent.cpp:
     14        (WebCore::InspectorPageAgent::getCookies):
     15        * inspector/InspectorPageAgent.h:
     16        * inspector/protocol/Page.json:
     17
    1182013-12-05  Brian J. Burg  <burg@cs.washington.edu>
    219

  • trunk/Source/WebCore/inspector/InspectorPageAgent.cpp

    r160202 r160203  
    529529}
    530530
    531 void InspectorPageAgent::getCookies(ErrorString*, RefPtr<TypeBuilder::Array<TypeBuilder::Page::Cookie>>& cookies, WTF::String* cookiesString)
     531void InspectorPageAgent::getCookies(ErrorString*, RefPtr<TypeBuilder::Array<TypeBuilder::Page::Cookie>>& cookies)
    532532{
    533533    // If we can get raw cookies.
    … …  
    565565
    566566    // FIXME: Do not return empty string/empty array. Make returns optional instead. https://bugs.webkit.org/show_bug.cgi?id=80855
    567     if (rawCookiesImplemented) {
     567    if (rawCookiesImplemented)
    568568        cookies = buildArrayForCookies(rawCookiesList);
    569         *cookiesString = "";
    570     } else {
     569    else
    571570        cookies = TypeBuilder::Array<TypeBuilder::Page::Cookie>::create();
    572         *cookiesString = stringCookiesList.toString();
    573     }
    574571}
    575572

  • trunk/Source/WebCore/inspector/InspectorPageAgent.h

    r160202 r160203  
    102102    virtual void reload(ErrorString*, const bool* optionalIgnoreCache, const String* optionalScriptToEvaluateOnLoad, const String* optionalScriptPreprocessor);
    103103    virtual void navigate(ErrorString*, const String& url);
    104     virtual void getCookies(ErrorString*, RefPtr<TypeBuilder::Array<TypeBuilder::Page::Cookie>>& cookies, WTF::String* cookiesString);
     104    virtual void getCookies(ErrorString*, RefPtr<TypeBuilder::Array<TypeBuilder::Page::Cookie>>& cookies);
    105105    virtual void deleteCookie(ErrorString*, const String& cookieName, const String& url);
    106106    virtual void getResourceTree(ErrorString*, RefPtr<TypeBuilder::Page::FrameResourceTree>&);

  • trunk/Source/WebCore/inspector/protocol/Page.json

    r160202 r160203  
    136136            "name": "getCookies",
    137137            "returns": [
    138                 { "name": "cookies", "type": "array", "items": { "$ref": "Cookie"}, "description": "Array of cookie objects." },
    139                 { "name": "cookiesString", "type": "string", "description": "document.cookie string representation of the cookies." }
    140             ],
    141             "description": "Returns all browser cookies. Depending on the backend support, will either return detailed cookie information in the <code>cookie</code> field or string cookie representation using <code>cookieString</code>."
     138                { "name": "cookies", "type": "array", "items": { "$ref": "Cookie"}, "description": "Array of cookie objects." }
     139            ],
     140            "description": "Returns all browser cookies. Depending on the backend support, will return detailed cookie information in the <code>cookies</code> field."
    142141        },
    143142        {

  • trunk/Source/WebInspectorUI/ChangeLog

    r160202 r160203  
     12013-12-05  Seokju Kwon  <seokju@webkit.org>
     2
     3        Web Inspector: Remove 'cookiesString' output from Page.getCookies
     4        https://bugs.webkit.org/show_bug.cgi?id=125268
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        Remove 'cookiesString' output from Page.getCookies protocol.
     9        It is no longer meaningful because it is an unused parameter.
     10
     11        * UserInterface/CookieStorageContentView.js:
     12        (WebInspector.CookieStorageContentView.prototype.update):
     13        * UserInterface/InspectorBackendCommands.js:
     14
    1152013-12-05  Brian J. Burg  <burg@cs.washington.edu>
    216

  • trunk/Source/WebInspectorUI/UserInterface/CookieStorageContentView.js

    r157269 r160203  
    4242    update: function()
    4343    {
    44         function callback(error, cookies, cookiesString)
     44        function callback(error, cookies)
    4545        {
    4646            if (error)

  • trunk/Source/WebInspectorUI/UserInterface/InspectorBackendCommands.js

    r160202 r160203  
    309309InspectorBackend.registerCommand("Page.reload", [{"name": "ignoreCache", "type": "boolean", "optional": true}, {"name": "scriptToEvaluateOnLoad", "type": "string", "optional": true}, {"name": "scriptPreprocessor", "type": "string", "optional": true}], []);
    310310InspectorBackend.registerCommand("Page.navigate", [{"name": "url", "type": "string", "optional": false}], []);
    311 InspectorBackend.registerCommand("Page.getCookies", [], ["cookies", "cookiesString"]);
     311InspectorBackend.registerCommand("Page.getCookies", [], ["cookies"]);
    312312InspectorBackend.registerCommand("Page.deleteCookie", [{"name": "cookieName", "type": "string", "optional": false}, {"name": "url", "type": "string", "optional": false}], []);
    313313InspectorBackend.registerCommand("Page.getResourceTree", [], ["frameTree"]);
Note: See TracChangeset for help on using the changeset viewer.