Changeset 160280 in webkit

Timestamp:

Dec 7, 2013 10:17:18 PM (10 years ago)

Author:

weinig@apple.com

Message:

[Cocoa] Make WKWebProcessPlugInController work with WKObject wrapping
​https://bugs.webkit.org/show_bug.cgi?id=125404

Reviewed by Dan Bernstein.

• Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

• Shared/mac/ObjCObjectGraphCoders.mm:
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

(-[WKWebProcessPlugInController dealloc]):
(didCreatePage):
(willDestroyPage):
(-[WKWebProcessPlugInController _setPrincipalClassInstance:]):
(-[WKWebProcessPlugInController API::]):

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h:

(WebKit::wrapper):

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h:
• WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (2 diffs)
• Shared/Cocoa/APIObject.mm (modified) (2 diffs)
• Shared/mac/ObjCObjectGraphCoders.mm (modified) (1 diff)
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm (modified) (6 diffs)
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h (modified) (1 diff)
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h (modified) (1 diff)
• WebProcess/InjectedBundle/mac/InjectedBundleMac.mm (modified) (3 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-12-07  Sam Weinig  <sam@webkit.org>
+
+        [Cocoa] Make WKWebProcessPlugInController work with WKObject wrapping
+        https://bugs.webkit.org/show_bug.cgi?id=125404
+
+        Reviewed by Dan Bernstein.
+
+        * Shared/Cocoa/APIObject.mm:
+        (API::Object::newObject):
+        * Shared/mac/ObjCObjectGraphCoders.mm:
+        * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
+        (-[WKWebProcessPlugInController dealloc]):
+        (didCreatePage):
+        (willDestroyPage):
+        (-[WKWebProcessPlugInController _setPrincipalClassInstance:]):
+        (-[WKWebProcessPlugInController API::]):
+        * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h:
+        (WebKit::wrapper):
+        * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h:
+        * WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
+        (WebKit::InjectedBundle::load):
+
 2013-12-07  Dan Bernstein  <mitz@apple.com>
 
@@ -6 +28 @@
         Reviewed by Sam Weinig.
 
-        Added WKNSData, an NSData subclass that confroms to WKObject and wraps a WebData.
+        Added WKNSData, an NSData subclass that conforms to WKObject and wraps a WebData.
 
         * Shared/Cocoa/APIObject.mm:

trunk/Source/WebKit2/Shared/Cocoa/APIObject.mm

@@ -45 +45 @@
 #import "WKProcessGroupInternal.h"
 #import "WKWebProcessPlugInBrowserContextControllerInternal.h"
+#import "WKWebProcessPlugInInternal.h"
 
 namespace API {
@@ -81 +82 @@
     case Type::BackForwardListItem:
         wrapper = [WKBackForwardListItem alloc];
+        break;
+
+    case Type::Bundle:
+        wrapper = [WKWebProcessPlugInController alloc];
         break;
 

trunk/Source/WebKit2/Shared/mac/ObjCObjectGraphCoders.mm

@@ -41 +41 @@
 #import "WKBundleAPICast.h"
 #import "WKWebProcessPlugInBrowserContextControllerInternal.h"
-#import "WKWebProcessPlugInBrowserContextControllerPrivate.h"
 #import "WKWebProcessPlugInInternal.h"
 #import "WebPage.h"

trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm

@@ -29 +29 @@
 #if WK_API_ENABLED
 
-#import "InjectedBundle.h"
 #import "WKConnectionInternal.h"
 #import "WKBundle.h"
@@ -40 +39 @@
 
 @interface WKWebProcessPlugInController () {
+    API::ObjectStorage<InjectedBundle> _bundle;
     RetainPtr<id <WKWebProcessPlugIn>> _principalClassInstance;
-    RefPtr<InjectedBundle> _bundle;
-    RetainPtr<WKConnection *> _connectionWrapper;
 }
 @end
@@ -48 +46 @@
 @implementation WKWebProcessPlugInController
 
+- (void)dealloc
+{
+    _bundle->~InjectedBundle();
+
+    [super dealloc];
+}
+
 static void didCreatePage(WKBundleRef bundle, WKBundlePageRef page, const void* clientInfo)
 {
     WKWebProcessPlugInController *plugInController = (WKWebProcessPlugInController *)clientInfo;
-    id<WKWebProcessPlugIn> principalClassInstance = plugInController->_principalClassInstance.get();
+    id <WKWebProcessPlugIn> principalClassInstance = plugInController->_principalClassInstance.get();
 
     if ([principalClassInstance respondsToSelector:@selector(webProcessPlugIn:didCreateBrowserContextController:)])
@@ -60 +65 @@
 {
     WKWebProcessPlugInController *plugInController = (WKWebProcessPlugInController *)clientInfo;
-    id<WKWebProcessPlugIn> principalClassInstance = plugInController->_principalClassInstance.get();
+    id <WKWebProcessPlugIn> principalClassInstance = plugInController->_principalClassInstance.get();
 
     if ([principalClassInstance respondsToSelector:@selector(webProcessPlugIn:willDestroyBrowserContextController:)])
@@ -79 +84 @@
 }
 
-static WKWebProcessPlugInController *sharedInstance;
-
-+ (WKWebProcessPlugInController *)_shared
+- (void)_setPrincipalClassInstance:(id <WKWebProcessPlugIn>)principalClassInstance
 {
-    ASSERT_WITH_MESSAGE(sharedInstance, "+[WKWebProcessPlugIn _shared] called without first initializing it.");
-    return sharedInstance;
-}
-
-- (id)_initWithPrincipalClassInstance:(id<WKWebProcessPlugIn>)principalClassInstance bundle:(InjectedBundle&)bundle
-{
-    self = [super init];
-    if (!self)
-        return nil;
-
+    ASSERT(!_principalClassInstance);
     _principalClassInstance = principalClassInstance;
-    _bundle = &bundle;
-
-    ASSERT_WITH_MESSAGE(!sharedInstance, "WKWebProcessPlugInController initialized multiple times.");
-    sharedInstance = self;
 
     setUpBundleClient(self, *_bundle);
-
-    return self;
 }
 
@@ -107 +95 @@
 {
     return wrapper(*_bundle->webConnectionToUIProcess());
+}
+
+#pragma mark WKObject protocol implementation
+
+- (API::Object&)_apiObject
+{
+    return *_bundle;
 }
 

trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h

@@ -24 +24 @@
  */
 
-#import "WKWebProcessPlugIn.h"
+#import "WKWebProcessPlugInPrivate.h"
 
 #if WK_API_ENABLED
 
 #import "InjectedBundle.h"
+#import "WKObject.h"
 
-@interface WKWebProcessPlugInController ()
+namespace WebKit {
 
-+ (WKWebProcessPlugInController *)_shared;
-- (id)_initWithPrincipalClassInstance:(id<WKWebProcessPlugIn>)principalClassInstance bundle:(WebKit::InjectedBundle&)bundle;
+inline WKWebProcessPlugInController *wrapper(InjectedBundle& bundle)
+{
+    ASSERT([bundle.wrapper() isKindOfClass:[WKWebProcessPlugInController class]]);
+    return (WKWebProcessPlugInController *)bundle.wrapper();
+}
 
+}
+
+@interface WKWebProcessPlugInController () <WKObject>
+- (void)_setPrincipalClassInstance:(id <WKWebProcessPlugIn>)principalClassInstance;
 @end
 

trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h

@@ -30 +30 @@
 @interface WKWebProcessPlugInController (Private)
 
-@property(readonly) WKBundleRef _bundleRef;
+@property (readonly) WKBundleRef _bundleRef;
 
 @end

trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm

@@ -99 +99 @@
     }
 
-    id<WKWebProcessPlugIn> instance = (id<WKWebProcessPlugIn>)[[principalClass alloc] init];
+    id <WKWebProcessPlugIn> instance = (id <WKWebProcessPlugIn>)[[principalClass alloc] init];
     if (!instance) {
         WTFLogAlways("InjectedBundle::load failed - Could not initialize an instance of the principal class.\n");
@@ -105 +105 @@
     }
 
-    // Create the shared WKWebProcessPlugInController.
-    [[WKWebProcessPlugInController alloc] _initWithPrincipalClassInstance:instance bundle:*this];
+    WKWebProcessPlugInController* plugInController = WebKit::wrapper(*this);
+    [plugInController _setPrincipalClassInstance:instance];
 
     if ([instance respondsToSelector:@selector(webProcessPlugIn:initializeWithObject:)]) {
@@ -112 +112 @@
         if (initializationUserData && initializationUserData->type() == API::Object::Type::ObjCObjectGraph)
             objCInitializationUserData = static_cast<ObjCObjectGraph*>(initializationUserData)->rootObject();
-        [instance webProcessPlugIn:[WKWebProcessPlugInController _shared] initializeWithObject:objCInitializationUserData.get()];
+        [instance webProcessPlugIn:plugInController initializeWithObject:objCInitializationUserData.get()];
     } else if ([instance respondsToSelector:@selector(webProcessPlugInInitialize:)]) {
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wdeprecated-declarations"
-        [instance webProcessPlugInInitialize:[WKWebProcessPlugInController _shared]];
+        [instance webProcessPlugInInitialize:plugInController];
 #pragma clang diagnostic pop
     }