Changeset 160323 in webkit


Ignore:
Timestamp:
Dec 9, 2013 12:16:50 PM (10 years ago)
Author:
mario.prada@samsung.com
Message:

[ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
​https://bugs.webkit.org/show_bug.cgi?id=125456

Reviewed by Chris Fleizach.

Tools:

Return 'AXSection' for section roles instead of 'AXDiv'.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Update expectations for GTK and EFL that were expecting AXDiv for
section roles, so they now expect AXSection.

  • accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
  • accessibility/div-within-anchors-causes-crash-expected.txt:
  • platform/efl-wk1/accessibility/image-map2-expected.txt:
  • platform/efl-wk1/accessibility/transformed-element-expected.txt:
  • platform/efl-wk2/accessibility/image-map2-expected.txt:
  • platform/efl-wk2/accessibility/transformed-element-expected.txt:
  • platform/efl/accessibility/media-emits-object-replacement-expected.txt:
  • platform/gtk/accessibility/aria-roles-unignored-expected.txt:
  • platform/gtk/accessibility/aria-roles-unignored.html:
  • platform/gtk/accessibility/entry-and-password-expected.txt:
  • platform/gtk/accessibility/image-map2-expected.txt:
  • platform/gtk/accessibility/media-emits-object-replacement-expected.txt:
  • platform/gtk/accessibility/object-with-title-expected.txt:
  • platform/gtk/accessibility/object-with-title.html:
  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
  • platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt:
  • platform/gtk/accessibility/spans-paragraphs-and-divs.html:
  • platform/gtk/accessibility/transformed-element-expected.txt:
Location:
trunk
Files:
22 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r160322 r160323  
     12013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
     2
     3        [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
     4        https://bugs.webkit.org/show_bug.cgi?id=125456
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Update expectations for GTK and EFL that were expecting AXDiv for
     9        section roles, so they now expect AXSection.
     10
     11        * accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
     12        * accessibility/div-within-anchors-causes-crash-expected.txt:
     13        * platform/efl-wk1/accessibility/image-map2-expected.txt:
     14        * platform/efl-wk1/accessibility/transformed-element-expected.txt:
     15        * platform/efl-wk2/accessibility/image-map2-expected.txt:
     16        * platform/efl-wk2/accessibility/transformed-element-expected.txt:
     17        * platform/efl/accessibility/media-emits-object-replacement-expected.txt:
     18        * platform/gtk/accessibility/aria-roles-unignored-expected.txt:
     19        * platform/gtk/accessibility/aria-roles-unignored.html:
     20        * platform/gtk/accessibility/entry-and-password-expected.txt:
     21        * platform/gtk/accessibility/image-map2-expected.txt:
     22        * platform/gtk/accessibility/media-emits-object-replacement-expected.txt:
     23        * platform/gtk/accessibility/object-with-title-expected.txt:
     24        * platform/gtk/accessibility/object-with-title.html:
     25        * platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
     26        * platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt:
     27        * platform/gtk/accessibility/spans-paragraphs-and-divs.html:
     28        * platform/gtk/accessibility/transformed-element-expected.txt:
     29
    1302013-12-09  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
    231

  • trunk/LayoutTests/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt

    r158810 r160323  
    99
    1010AXRole: AXWebArea
    11     AXRole: AXDiv AXValue: y
    12     AXRole: AXDiv AXValue: End of test
     11    AXRole: AXSection AXValue: y
     12    AXRole: AXSection AXValue: End of test
    1313PASS successfullyParsed is true
    1414

  • trunk/LayoutTests/accessibility/div-within-anchors-causes-crash-expected.txt

    r158810 r160323  
    33AXRole: AXWebArea
    44    AXRole: AXLink AXValue:
    5     AXRole: AXDiv AXValue: End of test
     5    AXRole: AXSection AXValue: End of test
    66After:
    77AXRole: AXWebArea
    8     AXRole: AXDiv AXValue: End of test
     8    AXRole: AXSection AXValue: End of test
    99This can cause a crash.
    1010

  • trunk/LayoutTests/platform/efl-wk1/accessibility/image-map2-expected.txt

    r157859 r160323  
    11Image map - test 2 - 2 Links (alt tags)
    22----------------------
    3 AXRole: AXDiv
     3AXRole: AXSection
    44AXParent: AXWebArea
    55AXChildren: 0

  • trunk/LayoutTests/platform/efl-wk1/accessibility/transformed-element-expected.txt

    r156033 r160323  
    11hello
    2 AXRole: AXDiv
     2AXRole: AXSection
    33AXParent: AXWebArea
    44AXChildren: 1

  • trunk/LayoutTests/platform/efl-wk2/accessibility/image-map2-expected.txt

    r157859 r160323  
    11Image map - test 2 - 2 Links (alt tags)
    22----------------------
    3 AXRole: AXDiv
     3AXRole: AXSection
    44AXParent: AXWebArea
    55AXChildren: 0

  • trunk/LayoutTests/platform/efl-wk2/accessibility/transformed-element-expected.txt

    r156033 r160323  
    11hello
    2 AXRole: AXDiv
     2AXRole: AXSection
    33AXParent: AXWebArea
    44AXChildren: 1

  • trunk/LayoutTests/platform/efl/accessibility/media-emits-object-replacement-expected.txt

    r158841 r160323  
    44End of test
    55AXRole: AXWebArea
    6     AXRole: AXDiv AXValue: a <obj> b
     6    AXRole: AXSection AXValue: a <obj> b
    77        AXRole: AXEmbedded
    88            AXRole: AXToolbar
    … …  
    1111                    AXRole: AXSlider
    1212    AXRole: AXGroup AXValue: <\n>
    13     AXRole: AXDiv AXValue: a <obj> b
     13    AXRole: AXSection AXValue: a <obj> b
    1414        AXRole: AXEmbedded
    1515            AXRole: AXToolbar
    … …  
    1717                    AXRole: AXButton
    1818                    AXRole: AXSlider
    19     AXRole: AXDiv AXValue: End of test
     19    AXRole: AXSection AXValue: End of test
    2020This tests ensures that if video or audio tags are used, they will emit an object replacement character in a range for string operation.
    2121

  • trunk/LayoutTests/platform/gtk/accessibility/aria-roles-unignored-expected.txt

    r131674 r160323  
    1919PASS element.role is 'AXRole: AXForm'
    2020PASS element.role is 'AXRole: AXButton'
    21 PASS element.role is 'AXRole: AXDiv'
     21PASS element.role is 'AXRole: AXSection'
    2222PASS element.role is 'AXRole: AXTextField'
    2323PASS successfullyParsed is true

  • trunk/LayoutTests/platform/gtk/accessibility/aria-roles-unignored.html

    r155282 r160323  
    5252    // Divs
    5353    element = webArea.childAtIndex(5);
    54     shouldBe("element.role", "'AXRole: AXDiv'");
     54    shouldBe("element.role", "'AXRole: AXSection'");
    5555    element = webArea.childAtIndex(6);
    5656    shouldBe("element.role", "'AXRole: AXTextField'");

  • trunk/LayoutTests/platform/gtk/accessibility/entry-and-password-expected.txt

    r131674 r160323  
    55        AXRole: AXTextField AXValue: 123
    66        AXRole: AXPasswordField AXValue: •••
    7     AXRole: AXDiv AXValue: End of test
     7    AXRole: AXSection AXValue: End of test
    88This tests that the text associated with entry and password fields is correct.
    99

  • trunk/LayoutTests/platform/gtk/accessibility/image-map2-expected.txt

    r157859 r160323  
    11Image map - test 2 - 2 Links (alt tags)
    22----------------------
    3 AXRole: AXDiv
     3AXRole: AXSection
    44AXParent: AXWebArea
    55AXChildren: 0

  • trunk/LayoutTests/platform/gtk/accessibility/media-emits-object-replacement-expected.txt

    r158841 r160323  
    44End of test
    55AXRole: AXWebArea
    6     AXRole: AXDiv AXValue: a <obj> b
     6    AXRole: AXSection AXValue: a <obj> b
    77        AXRole: AXEmbedded
    88            AXRole: AXToolbar
    … …  
    1111                    AXRole: AXSlider
    1212    AXRole: AXGroup AXValue: <\n>
    13     AXRole: AXDiv AXValue: a <obj> b
     13    AXRole: AXSection AXValue: a <obj> b
    1414        AXRole: AXEmbedded
    1515            AXRole: AXToolbar
    … …  
    1717                    AXRole: AXButton
    1818                    AXRole: AXSlider
    19     AXRole: AXDiv AXValue: End of test
     19    AXRole: AXSection AXValue: End of test
    2020This tests ensures that if video or audio tags are used, they will emit an object replacement character in a range for string operation.
    2121

  • trunk/LayoutTests/platform/gtk/accessibility/object-with-title-expected.txt

    r131674 r160323  
    99
    1010PASS child.role is 'AXRole: AXList'
    11 PASS child.role is 'AXRole: AXDiv'
     11PASS child.role is 'AXRole: AXSection'
    1212PASS child.role is 'AXRole: AXList'
    1313PASS successfullyParsed is true

  • trunk/LayoutTests/platform/gtk/accessibility/object-with-title.html

    r155282 r160323  
    2424
    2525        child = webArea.childAtIndex(1);
    26         shouldBe("child.role", "'AXRole: AXDiv'");
     26        shouldBe("child.role", "'AXRole: AXSection'");
    2727
    2828        child = child.childAtIndex(0);

  • trunk/LayoutTests/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt

    r158428 r160323  
    2121    AXRole: AXGroup AXValue: <obj>
    2222        AXRole: AXTextField AXValue: text area
    23     AXRole: AXDiv AXValue: Div<\n><obj>
     23    AXRole: AXSection AXValue: Div<\n><obj>
    2424        AXRole: AXButton
    2525    AXRole: AXHeading AXValue: Heading<\n><obj><\n><obj>
    2626        AXRole: AXButton
    2727        AXRole: AXImage
    28     AXRole: AXDiv AXValue: End of test
     28    AXRole: AXSection AXValue: End of test
    2929This tests that the text associated with replaced objects in an anonymous block is correct.
    3030

  • trunk/LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt

    r131674 r160323  
    3535PASS element.role is 'AXRole: AXParagraph'
    3636PASS element.childrenCount is 0
    37 PASS element.role is 'AXRole: AXDiv'
     37PASS element.role is 'AXRole: AXSection'
    3838PASS element.childrenCount is 1
    3939PASS link.role is 'AXRole: AXLink'
    4040PASS link.childrenCount is 0
    41 PASS element.role is 'AXRole: AXDiv'
     41PASS element.role is 'AXRole: AXSection'
    4242PASS element.childrenCount is 0
    43 PASS element.role is 'AXRole: AXDiv'
     43PASS element.role is 'AXRole: AXSection'
    4444PASS element.childrenCount is 1
    4545PASS link.role is 'AXRole: AXLink'
    4646PASS link.childrenCount is 0
    47 PASS element.role is 'AXRole: AXDiv'
     47PASS element.role is 'AXRole: AXSection'
    4848PASS element.childrenCount is 0
    4949PASS successfullyParsed is true

  • trunk/LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs.html

    r155282 r160323  
    8484
    8585    element = webArea.childAtIndex(4);
    86     shouldBe("element.role", "'AXRole: AXDiv'");
     86    shouldBe("element.role", "'AXRole: AXSection'");
    8787    shouldBe("element.childrenCount", "1");
    8888
    … …  
    9292
    9393    element = webArea.childAtIndex(5);
    94     shouldBe("element.role", "'AXRole: AXDiv'");
     94    shouldBe("element.role", "'AXRole: AXSection'");
    9595    shouldBe("element.childrenCount", "0");
    9696
    9797    element = webArea.childAtIndex(6);
    98     shouldBe("element.role", "'AXRole: AXDiv'");
     98    shouldBe("element.role", "'AXRole: AXSection'");
    9999    shouldBe("element.childrenCount", "1");
    100100
    … …  
    104104
    105105    element = webArea.childAtIndex(7);
    106     shouldBe("element.role", "'AXRole: AXDiv'");
     106    shouldBe("element.role", "'AXRole: AXSection'");
    107107    shouldBe("element.childrenCount", "0");
    108108}

  • trunk/LayoutTests/platform/gtk/accessibility/transformed-element-expected.txt

    r156033 r160323  
    11hello
    2 AXRole: AXDiv
     2AXRole: AXSection
    33AXParent: AXWebArea
    44AXChildren: 1

  • trunk/Tools/ChangeLog

    r160319 r160323  
     12013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
     2
     3        [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
     4        https://bugs.webkit.org/show_bug.cgi?id=125456
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Return 'AXSection' for section roles instead of 'AXDiv'.
     9
     10        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
     11        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
     12
    1132013-12-09  Brian J. Burg  <burg@cs.washington.edu>
    214

  • trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp

    r160316 r160323  
    259259        return "AXScrollArea";
    260260    case ATK_ROLE_SECTION:
    261         return "AXDiv";
     261        return "AXSection";
    262262    case ATK_ROLE_SEPARATOR:
    263263        return "AXHorizontalRule";

  • trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp

    r160316 r160323  
    348348        return "AXScrollArea";
    349349    case ATK_ROLE_SECTION:
    350         return "AXDiv";
     350        return "AXSection";
    351351    case ATK_ROLE_SEPARATOR:
    352352        return "AXHorizontalRule";
Note: See TracChangeset for help on using the changeset viewer.