Changeset 160683 in webkit


Ignore:
Timestamp:
Dec 16, 2013 6:00:06 PM (10 years ago)
Author:
commit-queue@webkit.org
Message:

Fix some whitespace issues in inspector code
​https://bugs.webkit.org/show_bug.cgi?id=125814

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-16
Reviewed by Darin Adler.

Source/JavaScriptCore:

  • inspector/protocol/Debugger.json:
  • inspector/protocol/Runtime.json:
  • inspector/scripts/CodeGeneratorInspector.py:

(Generator.process_command):

Source/WebCore:

  • inspector/protocol/DOM.json:
  • inspector/protocol/DOMStorage.json:
  • inspector/protocol/Timeline.json:
Location:
trunk/Source
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r160680 r160683  
     12013-12-16  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Fix some whitespace issues in inspector code
     4        https://bugs.webkit.org/show_bug.cgi?id=125814
     5
     6        Reviewed by Darin Adler.
     7
     8        * inspector/protocol/Debugger.json:
     9        * inspector/protocol/Runtime.json:
     10        * inspector/scripts/CodeGeneratorInspector.py:
     11        (Generator.process_command):
     12
    1132013-12-16  Mark Hahnenberg  <mhahnenberg@apple.com>
    214

  • trunk/Source/JavaScriptCore/inspector/protocol/Debugger.json

    r160588 r160683  
    241241                { "name": "doNotPauseOnExceptionsAndMuteConsole", "type": "boolean", "optional": true, "description": "Specifies whether evaluation should stop on exceptions and mute console. Overrides setPauseOnException state." },
    242242                { "name": "returnByValue", "type": "boolean", "optional": true, "description": "Whether the result is expected to be a JSON object that should be sent by value." },
    243                 { "name": "generatePreview", "type": "boolean", "optional": true,  "description": "Whether preview should be generated for the result." }
     243                { "name": "generatePreview", "type": "boolean", "optional": true, "description": "Whether preview should be generated for the result." }
    244244            ],
    245245            "returns": [

  • trunk/Source/JavaScriptCore/inspector/protocol/Runtime.json

    r160588 r160683  
    136136                { "name": "contextId", "$ref": "Runtime.ExecutionContextId", "optional": true, "description": "Specifies in which isolated context to perform evaluation. Each content script lives in an isolated context and this parameter may be used to specify one of those contexts. If the parameter is omitted or 0 the evaluation will be performed in the context of the inspected page." },
    137137                { "name": "returnByValue", "type": "boolean", "optional": true, "description": "Whether the result is expected to be a JSON object that should be sent by value." },
    138                 { "name": "generatePreview", "type": "boolean", "optional": true,  "description": "Whether preview should be generated for the result." }
     138                { "name": "generatePreview", "type": "boolean", "optional": true, "description": "Whether preview should be generated for the result." }
    139139            ],
    140140            "returns": [
    … …  
    152152                { "name": "doNotPauseOnExceptionsAndMuteConsole", "type": "boolean", "optional": true, "description": "Specifies whether function call should stop on exceptions and mute console. Overrides setPauseOnException state." },
    153153                { "name": "returnByValue", "type": "boolean", "optional": true, "description": "Whether the result is expected to be a JSON object which should be sent by value." },
    154                 { "name": "generatePreview", "type": "boolean", "optional": true,  "description": "Whether preview should be generated for the result." }
     154                { "name": "generatePreview", "type": "boolean", "optional": true, "description": "Whether preview should be generated for the result." }
    155155            ],
    156156            "returns": [

  • trunk/Source/JavaScriptCore/inspector/scripts/CodeGeneratorInspector.py

    r160588 r160683  
    20562056            dispatcher_if_chain.append("    else if (method == \"%s\")" % json_command_name)
    20572057        dispatcher_if_chain.append("        %s(callId, *message.get());" % json_command_name)
    2058         dispatcher_commands_list.append("            { \"%s\",  &%s::%s }," % (json_command_name, dispatcher_name, json_command_name))
     2058        dispatcher_commands_list.append("            { \"%s\", &%s::%s }," % (json_command_name, dispatcher_name, json_command_name))
    20592059
    20602060        method_in_params_handling = []

  • trunk/Source/WebCore/ChangeLog

    r160682 r160683  
     12013-12-16  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Fix some whitespace issues in inspector code
     4        https://bugs.webkit.org/show_bug.cgi?id=125814
     5
     6        Reviewed by Darin Adler.
     7
     8        * inspector/protocol/DOM.json:
     9        * inspector/protocol/DOMStorage.json:
     10        * inspector/protocol/Timeline.json:
     11
    1122013-12-16  Joseph Pecoraro  <pecoraro@apple.com>
    213

  • trunk/Source/WebCore/inspector/protocol/DOM.json

    r159357 r160683  
    281281            "name": "highlightNode",
    282282            "parameters": [
    283                 { "name": "highlightConfig", "$ref": "HighlightConfig",  "description": "A descriptor for the highlight appearance." },
     283                { "name": "highlightConfig", "$ref": "HighlightConfig", "description": "A descriptor for the highlight appearance." },
    284284                { "name": "nodeId", "$ref": "NodeId", "optional": true, "description": "Identifier of the node to highlight." },
    285285                { "name": "objectId", "$ref": "Runtime.RemoteObjectId", "optional": true, "description": "JavaScript object id of the node to be highlighted." }

  • trunk/Source/WebCore/inspector/protocol/DOMStorage.json

    r159233 r160683  
    5757            "name": "domStorageItemsCleared",
    5858            "parameters": [
    59                 { "name": "storageId",  "$ref": "StorageId" }
     59                { "name": "storageId", "$ref": "StorageId" }
    6060            ]
    6161        },
    … …  
    6363            "name": "domStorageItemRemoved",
    6464            "parameters": [
    65                 { "name": "storageId",  "$ref": "StorageId" },
     65                { "name": "storageId", "$ref": "StorageId" },
    6666                { "name": "key", "type": "string" }
    6767            ]
    … …  
    7070            "name": "domStorageItemAdded",
    7171            "parameters": [
    72                 { "name": "storageId",  "$ref": "StorageId" },
     72                { "name": "storageId", "$ref": "StorageId" },
    7373                { "name": "key", "type": "string" },
    7474                { "name": "newValue", "type": "string" }
    … …  
    7878            "name": "domStorageItemUpdated",
    7979            "parameters": [
    80                 { "name": "storageId",  "$ref": "StorageId" },
     80                { "name": "storageId", "$ref": "StorageId" },
    8181                { "name": "key", "type": "string" },
    8282                { "name": "oldValue", "type": "string" },

  • trunk/Source/WebCore/inspector/protocol/Timeline.json

    r159233 r160683  
    2727                { "name": "data", "type": "object", "description": "Event data." },
    2828                { "name": "children", "type": "array", "optional": true, "items": { "$ref": "TimelineEvent" }, "description": "Nested records." },
    29                 { "name": "counters", "$ref": "DOMCounters", "optional": true,  "description": "Current values of DOM counters." },
    30                 { "name": "usedHeapSize", "type": "integer", "optional": true,  "description": "Current size of JS heap." }
     29                { "name": "counters", "$ref": "DOMCounters", "optional": true, "description": "Current values of DOM counters." },
     30                { "name": "usedHeapSize", "type": "integer", "optional": true, "description": "Current size of JS heap." }
    3131            ],
    3232            "description": "Timeline record contains information about the recorded activity."
    … …  
    3838            "parameters": [
    3939                { "name": "maxCallStackDepth", "optional": true, "type": "integer", "description": "Samples JavaScript stack traces up to <code>maxCallStackDepth</code>, defaults to 5." },
    40                 { "name": "includeDomCounters", "optional": true, "type": "boolean",  "description": "Whether DOM counters data should be included into timeline events." }
     40                { "name": "includeDomCounters", "optional": true, "type": "boolean", "description": "Whether DOM counters data should be included into timeline events." }
    4141            ],
    4242            "description": "Starts capturing instrumentation events."
Note: See TracChangeset for help on using the changeset viewer.