Changeset 160909 in webkit

Timestamp:

Dec 20, 2013 6:58:40 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] The fullscreen API should be enabled by default
​https://bugs.webkit.org/show_bug.cgi?id=125993

Patch by Enrique Ocaña González <​eocanha@igalia.com> on 2013-12-20
Reviewed by Gustavo Noronha Silva.

Set the WebSettings property to TRUE

Source/WebKit/gtk:

• webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):

Source/WebKit2:

• UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_class_init):

Location:

trunk/Source

Files:

• WebKit/gtk/ChangeLog (modified) (1 diff)
• WebKit/gtk/webkit/webkitwebsettings.cpp (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (modified) (1 diff)

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2013-12-20  Enrique Ocaña González  <eocanha@igalia.com>
+
+        [GTK] The fullscreen API should be enabled by default
+        https://bugs.webkit.org/show_bug.cgi?id=125993
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Set the WebSettings property to TRUE
+
+        * webkit/webkitwebsettings.cpp:
+        (webkit_web_settings_class_init):
+
 2013-12-16  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp

@@ -827 +827 @@
                                                          flags));
 
-    /* Undocumented for now */
-    g_object_class_install_property(gobject_class,
-                                    PROP_ENABLE_FULLSCREEN,
-                                    g_param_spec_boolean("enable-fullscreen",
-                                                         _("Enable Fullscreen"),
-                                                         _("Whether the Mozilla style API should be enabled."),
-                                                         FALSE,
-                                                         flags));
+    /**
+    * WebKitWebSettings:enable-fullscreen:
+    *
+    *
+    * Whether to enable the Javascript Fullscreen API. The API
+    * allows any HTML element to request fullscreen display. See also
+    * the current draft of the spec:
+    * http://www.w3.org/TR/fullscreen/
+    *
+    * Since: 2.4
+    */
+    g_object_class_install_property(gobject_class,
+        PROP_ENABLE_FULLSCREEN,
+        g_param_spec_boolean("enable-fullscreen",
+            _("Enable Fullscreen"),
+            _("Whether to enable the Javascript Fullscreen API"),
+            TRUE,
+            flags));
+
     /**
     * WebKitWebSettings:enable-webgl:

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-12-20  Enrique Ocaña González  <eocanha@igalia.com>
+
+        [GTK] The fullscreen API should be enabled by default
+        https://bugs.webkit.org/show_bug.cgi?id=125993
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Set the WebSettings property to TRUE
+
+        * UIProcess/API/gtk/WebKitSettings.cpp:
+        (webkit_settings_class_init):
+
 2013-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp

@@ -899 +899 @@
      * allows any HTML element to request fullscreen display. See also
      * the current draft of the spec:
-     * http://dvcs.w3.org/hg/fullscreen/raw-file/tip/Overview.html
-     */
-    g_object_class_install_property(gObjectClass,
-                                    PROP_ENABLE_FULLSCREEN,
-                                    g_param_spec_boolean("enable-fullscreen",
-                                                         _("Enable Fullscreen"),
-                                                         _("Whether to enable the Javascriipt Fullscreen API"),
-                                                         FALSE,
-                                                         readWriteConstructParamFlags));
+     * http://www.w3.org/TR/fullscreen/
+     */
+    g_object_class_install_property(gObjectClass,
+        PROP_ENABLE_FULLSCREEN,
+        g_param_spec_boolean("enable-fullscreen",
+            _("Enable Fullscreen"),
+            _("Whether to enable the Javascript Fullscreen API"),
+            TRUE,
+            readWriteConstructParamFlags));
 
     /**