Changeset 160965 in webkit

Timestamp:

Dec 21, 2013 6:40:53 AM (10 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Test /webkit2/WebKitWebResource/mime-type fails when run after /webkit2/WebKitWebView/resources
​https://bugs.webkit.org/show_bug.cgi?id=126119

Reviewed by Martin Robinson.

The problem is that when the blank.ico resource is loaded from the
disk cache, the mime type is null, because the soup cache doesn't
cache sniffed mime types. This doesn't happen when a resource is
loaded form the memory cache, because the ResourceResponse is
cached, not only the headers. I think the disk cache should also
cache the sniffed content type, but that needs to be done in
soup. For now we can workaround the issue in the unit test by
making sure that resources that can be cached, also include the
Content-Type header, this way the mime type won't be sniffed and
it will be cached as a HTTP header in the disk cache.

• UIProcess/API/gtk/tests/TestResources.cpp:

(serverCallback): Add Content-Type header for resources that can
be cached.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/tests/TestResources.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Test /webkit2/WebKitWebResource/mime-type fails when run after /webkit2/WebKitWebView/resources
+        https://bugs.webkit.org/show_bug.cgi?id=126119
+
+        Reviewed by Martin Robinson.
+
+        The problem is that when the blank.ico resource is loaded from the
+        disk cache, the mime type is null, because the soup cache doesn't
+        cache sniffed mime types. This doesn't happen when a resource is
+        loaded form the memory cache, because the ResourceResponse is
+        cached, not only the headers. I think the disk cache should also
+        cache the sniffed content type, but that needs to be done in
+        soup. For now we can workaround the issue in the unit test by
+        making sure that resources that can be cached, also include the
+        Content-Type header, this way the mime type won't be sniffed and
+        it will be cached as a HTTP header in the disk cache.
+
+        * UIProcess/API/gtk/tests/TestResources.cpp:
+        (serverCallback): Add Content-Type header for resources that can
+        be cached.
+
 2013-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp

@@ -678 +678 @@
         soup_message_body_append(message->response_body, SOUP_MEMORY_STATIC, kStyleCSS, strlen(kStyleCSS));
         addCacheHTTPHeadersToResponse(message);
+        soup_message_headers_append(message->response_headers, "Content-Type", "text/css");
     } else if (g_str_equal(path, "/javascript.js")) {
         soup_message_body_append(message->response_body, SOUP_MEMORY_STATIC, kJavascript, strlen(kJavascript));
@@ -695 +696 @@
         soup_message_body_append(message->response_body, SOUP_MEMORY_TAKE, contents, contentsLength);
         addCacheHTTPHeadersToResponse(message);
+        soup_message_headers_append(message->response_headers, "Content-Type", "image/vnd.microsoft.icon");
     } else if (g_str_equal(path, "/simple-style.css")) {
         static const char* simpleCSS =