Changeset 161121 in webkit

Timestamp:

Dec 29, 2013 10:49:57 AM (10 years ago)

Author:

Martin Robinson

Message:

[GTK] [CMake] Convenience libraries that export API should be compiled with --whole-archive on Unix
​https://bugs.webkit.org/show_bug.cgi?id=126232

Reviewed by Gustavo Noronha Silva.

Source/WebKit:

• PlatformGTK.cmake: Prefix libGObjectDOMBindings with --whole-archive so that

symbols are not omitted during final linking.

Source/WebKit2:

• PlatformGTK.cmake: Prefix libGObjectDOMBindings with --whole-archive so that

symbols are not omitted during final linking.

Location:

trunk/Source

Files:

• WebKit/ChangeLog (modified) (1 diff)
• WebKit/PlatformGTK.cmake (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/PlatformGTK.cmake (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2013-12-29  Martin Robinson  <mrobinson@igalia.com>
+
+        [GTK] [CMake] Convenience libraries that export API should be compiled with --whole-archive on Unix
+        https://bugs.webkit.org/show_bug.cgi?id=126232
+
+        Reviewed by Gustavo Noronha Silva.
+
+        * PlatformGTK.cmake: Prefix libGObjectDOMBindings with --whole-archive so that
+        symbols are not omitted during final linking.
+
 2013-12-25  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebKit/PlatformGTK.cmake

@@ -130 +130 @@
 )
 
+# Since the GObjectDOMBindings convenience library exports API that is unused except
+# in embedding applications we need to instruct the linker to link all symbols explicitly.
 list(APPEND WebKit_LIBRARIES
-    GObjectDOMBindings
+    -Wl,--whole-archive GObjectDOMBindings -Wl,--no-whole-archive
     WebCorePlatformGTK
 )

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-12-29  Martin Robinson  <mrobinson@igalia.com>
+
+        [GTK] [CMake] Convenience libraries that export API should be compiled with --whole-archive on Unix
+        https://bugs.webkit.org/show_bug.cgi?id=126232
+
+        Reviewed by Gustavo Noronha Silva.
+
+        * PlatformGTK.cmake: Prefix libGObjectDOMBindings with --whole-archive so that
+        symbols are not omitted during final linking.
+
 2013-12-26  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebKit2/PlatformGTK.cmake

@@ -427 +427 @@
 )
 
+# Since the GObjectDOMBindings convenience library exports API that is unused except
+# in embedding applications we need to instruct the linker to link all symbols explicitly.
 list(APPEND WebKit2_LIBRARIES
-    GObjectDOMBindings
+    -Wl,--whole-archive GObjectDOMBindings -Wl,--no-whole-archive
     WebCorePlatformGTK
 )