Changeset 161254 in webkit


Ignore:
Timestamp:
Jan 2, 2014 11:48:05 PM (10 years ago)
Author:
ryuan.choi@samsung.com
Message:

[EFL][WK2] Remove defaultPageGroupIdentifier not to make the confusion
https://bugs.webkit.org/show_bug.cgi?id=126249

Reviewed by Gyuyoung Kim.

ewk_page_group_create always creates new page group,
but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "".
It is unnecessary and just makes the confusion.

This patch let WebPageGroup generate unique identifier if 0 or "" is passed as argument.

  • UIProcess/API/efl/ewk_page_group.cpp:

(EwkPageGroup::create):

  • UIProcess/API/efl/ewk_page_group_private.h:
Location:
trunk/Source/WebKit2
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r161253 r161254  
     12014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
     2
     3        [EFL][WK2] Remove defaultPageGroupIdentifier not to make the confusion
     4        https://bugs.webkit.org/show_bug.cgi?id=126249
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        ewk_page_group_create always creates new page group,
     9        but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "".
     10        It is unnecessary and just makes the confusion.
     11
     12        This patch let WebPageGroup generate unique identifier if 0 or "" is passed as argument.
     13
     14        * UIProcess/API/efl/ewk_page_group.cpp:
     15        (EwkPageGroup::create):
     16        * UIProcess/API/efl/ewk_page_group_private.h:
     17
    1182014-01-02  Zan Dobersek  <zdobersek@igalia.com>
    219
  • trunk/Source/WebKit2/UIProcess/API/efl/ewk_page_group.cpp

    r146075 r161254  
    3636using namespace WebKit;
    3737
    38 const char EwkPageGroup::defaultIdentifier[] = "defaultPageGroupIdentifier";
    39 
    4038typedef HashMap<WKPageGroupRef, EwkPageGroup*> PageGroupMap;
    4139
     
    5957}
    6058
    61 PassRefPtr<EwkPageGroup> EwkPageGroup::create(const String& identifier)
     59PassRefPtr<EwkPageGroup> EwkPageGroup::create(const char* identifier)
    6260{
    63     WKRetainPtr<WKStringRef> identifierRef = adoptWK(toCopiedAPI(identifier.isEmpty() ? defaultIdentifier : identifier));
     61    WKRetainPtr<WKStringRef> identifierRef = adoptWK(toCopiedAPI(identifier));
    6462    WKRetainPtr<WKPageGroupRef> pageGroupRef = adoptWK(WKPageGroupCreateWithIdentifier(identifierRef.get()));
    6563
  • trunk/Source/WebKit2/UIProcess/API/efl/ewk_page_group_private.h

    r146075 r161254  
    4242
    4343    static PassRefPtr<EwkPageGroup> findOrCreateWrapper(WKPageGroupRef pageGroupRef);
    44     static PassRefPtr<EwkPageGroup> create(const String& identifier = String());
     44    static PassRefPtr<EwkPageGroup> create(const char*);
    4545
    4646    ~EwkPageGroup();
     
    5454    explicit EwkPageGroup(WKPageGroupRef pageGroupRef);   
    5555
    56     static const char defaultIdentifier[];
    57 
    5856    WKRetainPtr<WKPageGroupRef> m_pageGroupRef;
    5957};
Note: See TracChangeset for help on using the changeset viewer.