Changeset 161254 in webkit
- Timestamp:
- Jan 2, 2014 11:48:05 PM (10 years ago)
- Location:
- trunk/Source/WebKit2
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit2/ChangeLog
r161253 r161254 1 2014-01-02 Ryuan Choi <ryuan.choi@samsung.com> 2 3 [EFL][WK2] Remove defaultPageGroupIdentifier not to make the confusion 4 https://bugs.webkit.org/show_bug.cgi?id=126249 5 6 Reviewed by Gyuyoung Kim. 7 8 ewk_page_group_create always creates new page group, 9 but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "". 10 It is unnecessary and just makes the confusion. 11 12 This patch let WebPageGroup generate unique identifier if 0 or "" is passed as argument. 13 14 * UIProcess/API/efl/ewk_page_group.cpp: 15 (EwkPageGroup::create): 16 * UIProcess/API/efl/ewk_page_group_private.h: 17 1 18 2014-01-02 Zan Dobersek <zdobersek@igalia.com> 2 19 -
trunk/Source/WebKit2/UIProcess/API/efl/ewk_page_group.cpp
r146075 r161254 36 36 using namespace WebKit; 37 37 38 const char EwkPageGroup::defaultIdentifier[] = "defaultPageGroupIdentifier";39 40 38 typedef HashMap<WKPageGroupRef, EwkPageGroup*> PageGroupMap; 41 39 … … 59 57 } 60 58 61 PassRefPtr<EwkPageGroup> EwkPageGroup::create(const String&identifier)59 PassRefPtr<EwkPageGroup> EwkPageGroup::create(const char* identifier) 62 60 { 63 WKRetainPtr<WKStringRef> identifierRef = adoptWK(toCopiedAPI(identifier .isEmpty() ? defaultIdentifier : identifier));61 WKRetainPtr<WKStringRef> identifierRef = adoptWK(toCopiedAPI(identifier)); 64 62 WKRetainPtr<WKPageGroupRef> pageGroupRef = adoptWK(WKPageGroupCreateWithIdentifier(identifierRef.get())); 65 63 -
trunk/Source/WebKit2/UIProcess/API/efl/ewk_page_group_private.h
r146075 r161254 42 42 43 43 static PassRefPtr<EwkPageGroup> findOrCreateWrapper(WKPageGroupRef pageGroupRef); 44 static PassRefPtr<EwkPageGroup> create(const String& identifier = String());44 static PassRefPtr<EwkPageGroup> create(const char*); 45 45 46 46 ~EwkPageGroup(); … … 54 54 explicit EwkPageGroup(WKPageGroupRef pageGroupRef); 55 55 56 static const char defaultIdentifier[];57 58 56 WKRetainPtr<WKPageGroupRef> m_pageGroupRef; 59 57 };
Note: See TracChangeset
for help on using the changeset viewer.