Changeset 161385 in webkit


Ignore:
Timestamp:
Jan 6, 2014 4:52:17 PM (10 years ago)
Author:
Seokju Kwon
Message:

Web Inspector: Remove support for FileSystem in Frontend.
​https://bugs.webkit.org/show_bug.cgi?id=126369

Reviewed by Joseph Pecoraro.

Source/WebCore:

No new tests, No change in behavior.

Remove leftover codes from protocol after r156692.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/protocol/FileSystem.json: Removed.

Source/WebInspectorUI:

Update InspectorWebBackendCommands after removing 'FileSystem' domain.

  • UserInterface/InspectorWebBackendCommands.js:
  • UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
  • UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
  • Versions/Inspector-iOS-6.0.json:
  • Versions/Inspector-iOS-7.0.json:
Location:
trunk/Source
Files:
1 deleted
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/CMakeLists.txt

    r161351 r161385  
    767767    inspector/protocol/DOMStorage.json
    768768    inspector/protocol/Database.json
    769     inspector/protocol/FileSystem.json
    770769    inspector/protocol/HeapProfiler.json
    771770    inspector/protocol/IndexedDB.json

  • trunk/Source/WebCore/ChangeLog

    r161384 r161385  
     12014-01-06  Seokju Kwon  <seokju@webkit.org>
     2
     3        Web Inspector: Remove support for FileSystem in Frontend.
     4        https://bugs.webkit.org/show_bug.cgi?id=126369
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        No new tests, No change in behavior.
     9
     10        Remove leftover codes from protocol after r156692.
     11
     12        * CMakeLists.txt:
     13        * DerivedSources.make:
     14        * GNUmakefile.am:
     15        * inspector/InspectorFrontendClient.h:
     16        * inspector/InspectorFrontendClientLocal.h:
     17        * inspector/InspectorFrontendHost.cpp:
     18        * inspector/InspectorFrontendHost.h:
     19        * inspector/InspectorFrontendHost.idl:
     20        * inspector/protocol/FileSystem.json: Removed.
     21
    1222014-01-06  Zoltan Horvath  <zoltan@webkit.org>
    223

  • trunk/Source/WebCore/DerivedSources.make

    r161280 r161385  
    10851085    $(WebCore)/inspector/protocol/DOMStorage.json \
    10861086    $(WebCore)/inspector/protocol/Database.json \
    1087     $(WebCore)/inspector/protocol/FileSystem.json \
    10881087    $(WebCore)/inspector/protocol/HeapProfiler.json \
    10891088    $(WebCore)/inspector/protocol/IndexedDB.json \

  • trunk/Source/WebCore/GNUmakefile.am

    r161267 r161385  
    344344    $(WebCore)/inspector/protocol/DOMStorage.json \
    345345    $(WebCore)/inspector/protocol/Database.json \
    346     $(WebCore)/inspector/protocol/FileSystem.json \
    347346    $(WebCore)/inspector/protocol/HeapProfiler.json \
    348347    $(WebCore)/inspector/protocol/IndexedDB.json \

  • trunk/Source/WebCore/inspector/InspectorFrontendClient.h

    r154828 r161385  
    7676    virtual void sendMessageToBackend(const String&) = 0;
    7777
    78     virtual bool supportsFileSystems() = 0;
    79     virtual void requestFileSystems() = 0;
    80     virtual void addFileSystem() = 0;
    81     virtual void removeFileSystem(const String& fileSystemPath) = 0;
    82 
    8378    virtual bool isUnderTest() = 0;
    8479};

  • trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h

    r154828 r161385  
    7777    virtual void sendMessageToBackend(const String& message);
    7878
    79     virtual bool supportsFileSystems() { return false; }
    80     virtual void requestFileSystems() { }
    81     virtual void addFileSystem() { }
    82     virtual void removeFileSystem(const String&) { }
    8379    virtual bool isUnderTest();
    8480

  • trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp

    r160887 r161385  
    314314}
    315315
    316 bool InspectorFrontendHost::supportsFileSystems()
    317 {
    318     if (m_client)
    319         return m_client->supportsFileSystems();
     316bool InspectorFrontendHost::isUnderTest()
     317{
     318    return m_client && m_client->isUnderTest();
     319}
     320
     321void InspectorFrontendHost::beep()
     322{
     323    systemBeep();
     324}
     325
     326bool InspectorFrontendHost::canSaveAs()
     327{
    320328    return false;
    321329}
    322330
    323 void InspectorFrontendHost::requestFileSystems()
    324 {
    325     if (m_client)
    326         m_client->requestFileSystems();
    327 }
    328 
    329 void InspectorFrontendHost::addFileSystem()
    330 {
    331     if (m_client)
    332         m_client->addFileSystem();
    333 }
    334 
    335 void InspectorFrontendHost::removeFileSystem(const String& fileSystemPath)
    336 {
    337     if (m_client)
    338         m_client->removeFileSystem(fileSystemPath);
    339 }
    340 
    341 bool InspectorFrontendHost::isUnderTest()
    342 {
    343     return m_client && m_client->isUnderTest();
    344 }
    345 
    346 void InspectorFrontendHost::beep()
    347 {
    348     systemBeep();
    349 }
    350 
    351 bool InspectorFrontendHost::canSaveAs()
     331bool InspectorFrontendHost::canInspectWorkers()
    352332{
    353333    return false;
    354334}
    355335
    356 bool InspectorFrontendHost::canInspectWorkers()
    357 {
    358     return false;
    359 }
    360 
    361336} // namespace WebCore
    362337

  • trunk/Source/WebCore/inspector/InspectorFrontendHost.h

    r160887 r161385  
    8585    String loadResourceSynchronously(const String& url);
    8686
    87     bool supportsFileSystems();
    88     void requestFileSystems();
    89     void addFileSystem();
    90     void removeFileSystem(const String& fileSystemPath);
    91 
    9287    bool isUnderTest();
    9388

  • trunk/Source/WebCore/inspector/InspectorFrontendHost.idl

    r160887 r161385  
    7272    DOMString loadResourceSynchronously(DOMString url);
    7373
    74     boolean supportsFileSystems();
    75     void requestFileSystems();
    76     void addFileSystem();
    77     void removeFileSystem(DOMString fileSystemPath);
    78 
    7974    boolean isUnderTest();
    8075

  • trunk/Source/WebInspectorUI/ChangeLog

    r161380 r161385  
     12014-01-06  Seokju Kwon  <seokju@webkit.org>
     2
     3        Web Inspector: Remove support for FileSystem in Frontend.
     4        https://bugs.webkit.org/show_bug.cgi?id=126369
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        Update InspectorWebBackendCommands after removing 'FileSystem' domain.
     9
     10        * UserInterface/InspectorWebBackendCommands.js:
     11        * UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
     12        * UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
     13        * Versions/Inspector-iOS-6.0.json:
     14        * Versions/Inspector-iOS-7.0.json:
     15
    1162014-01-06  Seokju Kwon  <seokju@webkit.org>
    217

  • trunk/Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js

    r161380 r161385  
    158158InspectorBackend.registerCommand("Database.getDatabaseTableNames", [{"name": "databaseId", "type": "string", "optional": false}], ["tableNames"]);
    159159InspectorBackend.registerCommand("Database.executeSQL", [{"name": "databaseId", "type": "string", "optional": false}, {"name": "query", "type": "string", "optional": false}], ["columnNames", "values", "sqlError"]);
    160 
    161 // FileSystem.
    162 InspectorBackend.registerFileSystemDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "FileSystem");
    163 InspectorBackend.registerCommand("FileSystem.enable", [], []);
    164 InspectorBackend.registerCommand("FileSystem.disable", [], []);
    165 InspectorBackend.registerCommand("FileSystem.requestFileSystemRoot", [{"name": "origin", "type": "string", "optional": false}, {"name": "type", "type": "string", "optional": false}], ["errorCode", "root"]);
    166 InspectorBackend.registerCommand("FileSystem.requestDirectoryContent", [{"name": "url", "type": "string", "optional": false}], ["errorCode", "entries"]);
    167 InspectorBackend.registerCommand("FileSystem.requestMetadata", [{"name": "url", "type": "string", "optional": false}], ["errorCode", "metadata"]);
    168 InspectorBackend.registerCommand("FileSystem.requestFileContent", [{"name": "url", "type": "string", "optional": false}, {"name": "readAsText", "type": "boolean", "optional": false}, {"name": "start", "type": "number", "optional": true}, {"name": "end", "type": "number", "optional": true}, {"name": "charset", "type": "string", "optional": true}], ["errorCode", "content", "charset"]);
    169 InspectorBackend.registerCommand("FileSystem.deleteEntry", [{"name": "url", "type": "string", "optional": false}], ["errorCode"]);
    170160
    171161// HeapProfiler.

  • trunk/Source/WebInspectorUI/UserInterface/Legacy/6.0/InspectorWebBackendCommands.js

    r160557 r161385  
    141141InspectorBackend.registerCommand("ApplicationCache.getManifestForFrame", [{"name": "frameId", "type": "string", "optional": false}], ["manifestURL"]);
    142142InspectorBackend.registerCommand("ApplicationCache.getApplicationCacheForFrame", [{"name": "frameId", "type": "string", "optional": false}], ["applicationCache"]);
    143 
    144 // FileSystem.
    145 InspectorBackend.registerFileSystemDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "FileSystem");
    146 InspectorBackend.registerCommand("FileSystem.enable", [], []);
    147 InspectorBackend.registerCommand("FileSystem.disable", [], []);
    148143
    149144// DOM.

  • trunk/Source/WebInspectorUI/UserInterface/Legacy/7.0/InspectorWebBackendCommands.js

    r160557 r161385  
    172172InspectorBackend.registerCommand("ApplicationCache.getApplicationCacheForFrame", [{"name": "frameId", "type": "string", "optional": false}], ["applicationCache"]);
    173173
    174 // FileSystem.
    175 InspectorBackend.registerFileSystemDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "FileSystem");
    176 InspectorBackend.registerCommand("FileSystem.enable", [], []);
    177 InspectorBackend.registerCommand("FileSystem.disable", [], []);
    178 InspectorBackend.registerCommand("FileSystem.requestFileSystemRoot", [{"name": "origin", "type": "string", "optional": false}, {"name": "type", "type": "string", "optional": false}], ["errorCode", "root"]);
    179 InspectorBackend.registerCommand("FileSystem.requestDirectoryContent", [{"name": "url", "type": "string", "optional": false}], ["errorCode", "entries"]);
    180 InspectorBackend.registerCommand("FileSystem.requestMetadata", [{"name": "url", "type": "string", "optional": false}], ["errorCode", "metadata"]);
    181 InspectorBackend.registerCommand("FileSystem.requestFileContent", [{"name": "url", "type": "string", "optional": false}, {"name": "readAsText", "type": "boolean", "optional": false}, {"name": "start", "type": "number", "optional": true}, {"name": "end", "type": "number", "optional": true}, {"name": "charset", "type": "string", "optional": true}], ["errorCode", "content", "charset"]);
    182 InspectorBackend.registerCommand("FileSystem.deleteEntry", [{"name": "url", "type": "string", "optional": false}], ["errorCode"]);
    183 
    184174// DOM.
    185175InspectorBackend.registerDOMDispatcher = InspectorBackend.registerDomainDispatcher.bind(InspectorBackend, "DOM");

  • trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json

    r155924 r161385  
    13371337                ]
    13381338            }
    1339         ]
    1340     },
    1341     {
    1342         "domain": "FileSystem",
    1343         "hidden": true,
    1344         "commands": [
    1345             {
    1346                 "name": "enable",
    1347                 "description": "Enables events from backend."
    1348             },
    1349             {
    1350                 "name": "disable",
    1351                 "description": "Disables events from backend.."
    1352             }
    1353         ],
    1354         "events": [
    13551339        ]
    13561340    },

  • trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json

    r160202 r161385  
    15211521                    { "name": "isNowOnline", "type": "boolean" }
    15221522                ]
    1523             }
    1524         ]
    1525     },
    1526     {
    1527         "domain": "FileSystem",
    1528         "types": [
    1529             {
    1530                 "id": "Entry",
    1531                 "type": "object",
    1532                 "properties": [
    1533                     { "name": "url", "type": "string", "description": "filesystem: URL for the entry." },
    1534                     { "name": "name", "type": "string", "description": "The name of the file or directory." },
    1535                     { "name": "isDirectory", "type": "boolean", "description": "True if the entry is a directory." },
    1536                     { "name": "mimeType", "type": "string", "optional": true, "description": "MIME type of the entry, available for a file only." },
    1537                     { "name": "resourceType", "$ref": "Page.ResourceType", "optional": true, "description": "ResourceType of the entry, available for a file only." },
    1538                     { "name": "isTextFile", "type": "boolean", "optional": true, "description": "True if the entry is a text file." }
    1539                 ],
    1540                 "description": "Represents a browser side file or directory."
    1541             },
    1542             {
    1543                 "id": "Metadata",
    1544                 "type": "object",
    1545                 "properties": [
    1546                     { "name": "modificationTime", "type": "number", "description": "Modification time." },
    1547                     { "name": "size", "type": "number", "description": "File size. This field is always zero for directories." }
    1548                 ],
    1549                 "description": "Represents metadata of a file or entry."
    1550             }
    1551         ],
    1552         "commands": [
    1553             {
    1554                 "name": "enable",
    1555                 "description": "Enables events from backend."
    1556             },
    1557             {
    1558                 "name": "disable",
    1559                 "description": "Disables events from backend."
    1560             },
    1561             {
    1562                 "name": "requestFileSystemRoot",
    1563                 "async": true,
    1564                 "parameters": [
    1565                     { "name": "origin", "type": "string", "description": "Security origin of requesting FileSystem. One of frames in current page needs to have this security origin." },
    1566                     { "name": "type", "type": "string", "enum": ["temporary", "persistent"], "description": "FileSystem type of requesting FileSystem." }
    1567                 ],
    1568                 "returns": [
    1569                     { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise, errorCode is set to FileError::ErrorCode value." },
    1570                     { "name": "root", "$ref": "Entry", "optional": true, "description": "Contains root of the requested FileSystem if the command completed successfully." }
    1571                 ],
    1572                 "description": "Returns root directory of the FileSystem, if exists."
    1573             },
    1574             {
    1575                 "name": "requestDirectoryContent",
    1576                 "async": true,
    1577                 "parameters": [
    1578                     { "name": "url", "type": "string", "description": "URL of the directory that the frontend is requesting to read from." }
    1579                 ],
    1580                 "returns": [
    1581                     { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise, errorCode is set to FileError::ErrorCode value." },
    1582                     { "name": "entries", "type": "array", "items": { "$ref": "Entry" }, "optional": true, "description": "Contains all entries on directory if the command completed successfully." }
    1583                 ],
    1584                 "description": "Returns content of the directory."
    1585             },
    1586             {
    1587                 "name": "requestMetadata",
    1588                 "async": true,
    1589                 "parameters": [
    1590                     { "name": "url", "type": "string", "description": "URL of the entry that the frontend is requesting to get metadata from." }
    1591                 ],
    1592                 "returns": [
    1593                     { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise, errorCode is set to FileError::ErrorCode value." },
    1594                     { "name": "metadata", "$ref": "Metadata", "optional": true, "description": "Contains metadata of the entry if the command completed successfully." }
    1595                 ],
    1596                 "description": "Returns metadata of the entry."
    1597             },
    1598             {
    1599                 "name": "requestFileContent",
    1600                 "async": true,
    1601                 "parameters": [
    1602                     { "name": "url", "type": "string", "description": "URL of the file that the frontend is requesting to read from." },
    1603                     { "name": "readAsText", "type": "boolean", "description": "True if the content should be read as text, otherwise the result will be returned as base64 encoded text." },
    1604                     { "name": "start", "type": "integer", "optional": true, "description": "Specifies the start of range to read." },
    1605                     { "name": "end", "type": "integer", "optional": true, "description": "Specifies the end of range to read exclusively." },
    1606                     { "name": "charset", "type": "string", "optional": true, "description": "Overrides charset of the content when content is served as text." }
    1607                 ],
    1608                 "returns": [
    1609                     { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise, errorCode is set to FileError::ErrorCode value." },
    1610                     { "name": "content", "type": "string", "optional": true, "description": "Content of the file." },
    1611                     { "name": "charset", "type": "string", "optional": true, "description": "Charset of the content if it is served as text." }
    1612                 ],
    1613                 "description": "Returns content of the file. Result should be sliced into [start, end)."
    1614             },
    1615             {
    1616                 "name": "deleteEntry",
    1617                 "async": true,
    1618                 "parameters": [
    1619                     { "name": "url", "type": "string", "description": "URL of the entry to delete." }
    1620                 ],
    1621                 "returns": [
    1622                     { "name": "errorCode", "type": "integer", "description": "0, if no error. Otherwise errorCode is set to FileError::ErrorCode value." }
    1623                 ],
    1624                 "description": "Deletes specified entry. If the entry is a directory, the agent deletes children recursively."
    16251523            }
    16261524        ]
Note: See TracChangeset for help on using the changeset viewer.