Changeset 161416 in webkit

Timestamp:

Jan 7, 2014 2:06:16 AM (10 years ago)

Author:

Carlos Garcia Campos

Message:

Crash when trying to register a custom scheme before network process has been launched
​https://bugs.webkit.org/show_bug.cgi?id=126385

Reviewed by Anders Carlsson.

WebContext::registerSchemeForCustomProtocol() uses
sendToNetworkingProcess() to send the message to the appropriate
networking process. In the case of using web process,
sendToNetworkingProcess() first checks if there's already a web
process, doing nothing otherwise, but when using the network
process it assumes there's already a network process. In both
cases it's safe to do nothing, because the schemes will be passed
as creation parameters to the process when launched.

• UIProcess/WebContext.h:

(WebKit::WebContext::sendToNetworkingProcess):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebContext.h (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-01-07  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Crash when trying to register a custom scheme before network process has been launched
+        https://bugs.webkit.org/show_bug.cgi?id=126385
+
+        Reviewed by Anders Carlsson.
+
+        WebContext::registerSchemeForCustomProtocol() uses
+        sendToNetworkingProcess() to send the message to the appropriate
+        networking process. In the case of using web process,
+        sendToNetworkingProcess() first checks if there's already a web
+        process, doing nothing otherwise, but when using the network
+        process it assumes there's already a network process. In both
+        cases it's safe to do nothing, because the schemes will be passed
+        as creation parameters to the process when launched.
+
+        * UIProcess/WebContext.h:
+        (WebKit::WebContext::sendToNetworkingProcess):
+
 2014-01-07  Jinwoo Song  <jinwoo7.song@samsung.com>
 

trunk/Source/WebKit2/UIProcess/WebContext.h

@@ -513 +513 @@
 #if ENABLE(NETWORK_PROCESS)
         if (m_usesNetworkProcess) {
-            if (m_networkProcess->canSendMessage())
+            if (m_networkProcess && m_networkProcess->canSendMessage())
                 m_networkProcess->send(std::forward<T>(message), 0);
             return;
@@ -523 +523 @@
     case ProcessModelMultipleSecondaryProcesses:
 #if ENABLE(NETWORK_PROCESS)
-        if (m_networkProcess->canSendMessage())
+        if (m_networkProcess && m_networkProcess->canSendMessage())
             m_networkProcess->send(std::forward<T>(message), 0);
         return;