Changeset 161454 in webkit


Ignore:
Timestamp:
Jan 7, 2014 2:06:08 PM (10 years ago)
Author:
ap@apple.com
Message:

Popovers at build.webkit.org/dashboard could have titles
​https://bugs.webkit.org/show_bug.cgi?id=126495

Reviewed by Timothy Hatcher.

Added titles to all popovers except for pending revisions one, which I would like
to improve more (probably add an ETA).

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:

(BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for
adding a title to base class.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
a divider to a separate function.
(BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
(BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
title from above function.
(BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
variable to "content" to match all other code.
(BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
(BuildbotQueueView.prototype._addDividerToPopover): Added.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
(BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
(BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
Location:
trunk/Tools
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js

    r161440 r161454  
    144144        }
    145145
    146         var title = document.createElement("div");
    147         title.className = "build-logs-popover-title";
    148         title.textContent = iteration.queue.id;
    149         content.appendChild(title);
     146        this._addIterationHeadingToPopover(iteration, content);
     147        this._addDividerToPopover(content);
    150148       
    151         var builderPageLine = document.createElement("a");
    152         builderPageLine.className = "build-page-link";
    153         builderPageLine.href = iteration.queue.buildbot.buildPageURLForIteration(iteration);
    154         builderPageLine.textContent = "build #" + iteration.id;
    155         builderPageLine.target = "_blank";
    156         content.appendChild(builderPageLine);
    157 
    158149        var logsHeadingLine = document.createElement("div");
    159150        logsHeadingLine.className = "build-logs-heading";

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js

    r161277 r161454  
    167167            var linesForInternal = this._popoverLinesForCommitRange(internalTrac, latestProductiveIteration.internalRevision + 1, internalTrac.latestRecordedRevisionNumber);
    168168
    169         if (linesForOpenSource.length && linesForInternal.length) {
    170             var divider = document.createElement("div");
    171             divider.className = "divider";
    172             content.appendChild(divider);
    173         }
     169        if (linesForOpenSource.length && linesForInternal.length)
     170            this._addDividerToPopover(content);
    174171
    175172        for (var i = 0; i != linesForInternal.length; ++i)
    … …  
    192189            return false;
    193190
     191        var line = document.createElement("div");
     192        line.className = "title";
     193        line.textContent = "new commits in this build";
     194        content.appendChild(line);
     195        this._addDividerToPopover(content);
     196
    194197        for (var i = 0; i != linesForCommits.length; ++i)
    195198            content.appendChild(linesForCommits[i]);
    … …  
    209212        var line = document.createElement("div");
    210213        line.className = "no-commits";
    211         line.textContent = "no new commits in this buildbot queue iteration";
     214        line.textContent = "no new commits in this build";
    212215       
    213216        content.appendChild(line);
    … …  
    222225    _revisionPopoverContentForIteration: function(iteration, internal)
    223226    {
    224         var contentElement = document.createElement("span");
    225         contentElement.textContent = "r" + (internal ? iteration.internalRevision : iteration.openSourceRevision);
    226         contentElement.classList.add("revision-number");
     227        var content = document.createElement("span");
     228        content.textContent = "r" + (internal ? iteration.internalRevision : iteration.openSourceRevision);
     229        content.classList.add("revision-number");
    227230
    228231        var previousIteration = iteration.previousProductiveIteration;
    … …  
    234237            };
    235238            if (context.firstRevision <= context.lastRevision)
    236                 new PopoverTracker(contentElement, this._presentPopoverForRevisionRange.bind(this), context);
     239                new PopoverTracker(content, this._presentPopoverForRevisionRange.bind(this), context);
    237240            else
    238                 new PopoverTracker(contentElement, this._presentNoChangePopover.bind(this), context);
    239         }
    240 
    241         return contentElement;
     241                new PopoverTracker(content, this._presentNoChangePopover.bind(this), context);
     242        }
     243
     244        return content;
     245    },
     246
     247    _addIterationHeadingToPopover: function(iteration, content, additionalText)
     248    {
     249        var title = document.createElement("div");
     250        title.className = "popover-iteration-heading";
     251
     252        var queueName = document.createElement("span");
     253        queueName.className = "queue-name";
     254        queueName.textContent = iteration.queue.id;
     255        title.appendChild(queueName);
     256
     257        var buildbotLink = document.createElement("a");
     258        buildbotLink.className = "buildbot-link";
     259        buildbotLink.textContent = "build #" + iteration.id;
     260        buildbotLink.href = iteration.queue.buildbot.buildPageURLForIteration(iteration);
     261        buildbotLink.target = "_blank";
     262        title.appendChild(buildbotLink);
     263
     264        if (additionalText) {
     265            var additionalTextElement = document.createElement("span");
     266            additionalTextElement.className = "additional-text";
     267            additionalTextElement.textContent = additionalText;
     268            title.appendChild(additionalTextElement);
     269        }
     270
     271        content.appendChild(title);
     272    },
     273
     274    _addDividerToPopover: function(content)
     275    {
     276        var divider = document.createElement("div");
     277        divider.className = "divider";
     278        content.appendChild(divider);
    242279    },
    243280

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js

    r161440 r161454  
    141141        content.className = "test-results-popover";
    142142
     143        this._addIterationHeadingToPopover(iteration, content, "layout test failures");
     144        this._addDividerToPopover(content);
     145
    143146        if (!iteration.layoutTestResults.regressions) {
    144147            var message = document.createElement("div");
    … …  
    200203            content.className = "test-results-popover";
    201204
     205            this._addIterationHeadingToPopover(iteration, content, "layout test failures");
     206            this._addDividerToPopover(content);
     207
    202208            var loadingIndicator = document.createElement("div");
    203209            loadingIndicator.className = "loading-indicator";
    … …  
    237243        content.className = "test-results-popover";
    238244
     245        this._addIterationHeadingToPopover(iteration, content);
     246        this._addDividerToPopover(content);
     247
    239248        if (layoutTestResults.failureCount) {
    240249            var message = (layoutTestResults.tooManyFailures ? layoutTestResults.failureCount + "\uff0b" : layoutTestResults.failureCount) + "\u00a0" +

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css

    r161440 r161454  
    4141}
    4242
    43 .commit-history-popover > .pending-commit,
    44 .commit-history-popover > .no-commits {
     43.popover .divider {
     44    height: 7px;
     45}
     46
     47.popover .popover-iteration-heading .buildbot-link,
     48.popover .popover-iteration-heading .additional-text {
     49    padding-left: 5px;
     50}
     51
     52.commit-history-popover {
    4553    font-family: "HelveticaNeue-Light", "Helvetica Neue", sans-serif;
    4654    color: rgb(145, 135, 95);
    … …  
    6068}
    6169
    62 .commit-history-popover > .divider {
    63     height: 7px;
     70.build-logs-popover {
     71    font-family: "HelveticaNeue-Light", "Helvetica Neue", sans-serif;
     72    color: rgb(145, 135, 95);
     73    font-size: 12px;
     74    text-align: left;
     75    padding: 1px 6px 1px 6px;
    6476}
    6577

  • trunk/Tools/ChangeLog

    r161441 r161454  
     12014-01-07  Alexey Proskuryakov  <ap@apple.com>
     2
     3        Popovers at build.webkit.org/dashboard could have titles
     4        https://bugs.webkit.org/show_bug.cgi?id=126495
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        Added titles to all popovers except for pending revisions one, which I would like
     9        to improve more (probably add an ETA).
     10
     11        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
     12        (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for
     13        adding a title to base class.
     14
     15        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
     16        (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
     17        a divider to a separate function.
     18        (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
     19        (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
     20        title from above function.
     21        (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
     22        variable to "content" to match all other code.
     23        (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
     24        (BuildbotQueueView.prototype._addDividerToPopover): Added.
     25
     26        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
     27        (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
     28        (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
     29        (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
     30
     31        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
     32
    1332014-01-07  Alexey Proskuryakov  <ap@apple.com>
    234
Note: See TracChangeset for help on using the changeset viewer.