Changeset 161496 in webkit


Ignore:
Timestamp:
Jan 8, 2014 6:35:12 AM (10 years ago)
Author:
berto@igalia.com
Message:

REGRESSION(r160304): [GTK] Disable libtool fast install
https://bugs.webkit.org/show_bug.cgi?id=126381

Reviewed by Gustavo Noronha Silva.

.:

Don't disable the libtool fast-install mode unconditionally by
default.

If the fast-install mode is disabled, binaries are generated ready
to use the libraries directly from the build tree. If we use the
GNU linker, those binaries are then relinked when they are
installed.

However, libtool fails to do it properly when an installation
prefix is set with DESTDIR, and ends up installing the libtool
wrappers instead of the actual binaries.

  • Source/autotools/SetupLibtool.m4:

Tools:

Disable the libtool fast-install mode in developer/test builds.

In this mode binaries are generated ready to be used directly from
the build tree. Otherwise they would need to be relinked when they
are executed, which can take a lot of resources, particularly in
debug builds.

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary):

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/ChangeLog

    r161426 r161496  
     12014-01-08  Alberto Garcia  <berto@igalia.com>
     2
     3        REGRESSION(r160304): [GTK] Disable libtool fast install
     4        https://bugs.webkit.org/show_bug.cgi?id=126381
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        Don't disable the libtool fast-install mode unconditionally by
     9        default.
     10
     11        If the fast-install mode is disabled, binaries are generated ready
     12        to use the libraries directly from the build tree. If we use the
     13        GNU linker, those binaries are then relinked when they are
     14        installed.
     15
     16        However, libtool fails to do it properly when an installation
     17        prefix is set with DESTDIR, and ends up installing the libtool
     18        wrappers instead of the actual binaries.
     19
     20        * Source/autotools/SetupLibtool.m4:
     21
    1222014-01-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
    223
  • trunk/Source/autotools/SetupLibtool.m4

    r161255 r161496  
    1313DOLT
    1414AC_DISABLE_STATIC
    15 AC_DISABLE_FAST_INSTALL
    1615AC_LIBTOOL_WIN32_DLL
    1716AC_PROG_LIBTOOL
  • trunk/Tools/ChangeLog

    r161490 r161496  
     12014-01-08  Alberto Garcia  <berto@igalia.com>
     2
     3        REGRESSION(r160304): [GTK] Disable libtool fast install
     4        https://bugs.webkit.org/show_bug.cgi?id=126381
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        Disable the libtool fast-install mode in developer/test builds.
     9
     10        In this mode binaries are generated ready to be used directly from
     11        the build tree. Otherwise they would need to be relinked when they
     12        are executed, which can take a lot of resources, particularly in
     13        debug builds.
     14
     15        * Scripts/webkitdirs.pm:
     16        (runAutogenForAutotoolsProjectIfNecessary):
     17
    1182014-01-08  Zan Dobersek  <zdobersek@igalia.com>
    219
  • trunk/Tools/Scripts/webkitdirs.pm

    r161340 r161496  
    17851785    unshift(@buildArgs, "--enable-developer-mode");
    17861786
     1787    # Optimize for running WebKit inside the build tree
     1788    unshift(@buildArgs, "--disable-fast-install");
     1789
    17871790    my $joinedBuildArgs = join(" ", @buildArgs);
    17881791
Note: See TracChangeset for help on using the changeset viewer.