Changeset 161549 in webkit
- Timestamp:
- Jan 9, 2014 12:05:00 AM (10 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r161541 r161549 1 2014-01-08 Carlos Garcia Campos <cgarcia@igalia.com> 2 3 REGRESSION(r161176): http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html is failing on GTK 4 https://bugs.webkit.org/show_bug.cgi?id=126518 5 6 Reviewed by Martin Robinson. 7 8 Unskip 9 http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html 10 and http/tests/security/redirect-BLOCKED-to-localURL.html. 11 12 * platform/gtk/TestExpectations: 13 1 14 2014-01-08 Commit Queue <commit-queue@webkit.org> 2 15 -
trunk/LayoutTests/platform/gtk/TestExpectations
r161503 r161549 1531 1531 webkit.org/b/126425 scrollbars/scrollbar-large-overflow-rectangle.html [ Failure ] 1532 1532 1533 webkit.org/b/126518 http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html [ Failure ]1534 webkit.org/b/126518 http/tests/security/redirect-BLOCKED-to-localURL.html [ Failure ]1535 1536 1533 webkit.org/b/126519 inspector-protocol/model/highlight-shape-outside-margin.html [ Failure ] 1537 1534 -
trunk/Source/WebCore/ChangeLog
r161541 r161549 1 2014-01-08 Carlos Garcia Campos <cgarcia@igalia.com> 2 3 REGRESSION(r161176): http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html is failing on GTK 4 https://bugs.webkit.org/show_bug.cgi?id=126518 5 6 Reviewed by Martin Robinson. 7 8 Clear the credentials before calling willSendRequest on the client 9 to avoid sending the credentials to the API layer, but apply them 10 again to the request right before creating the new SoupRequest. 11 12 * platform/network/soup/ResourceHandleSoup.cpp: 13 (WebCore::continueAfterWillSendRequest): 14 (WebCore::doRedirect): 15 1 16 2014-01-08 Commit Queue <commit-queue@webkit.org> 2 17 -
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
r161338 r161549 456 456 } 457 457 458 static void continueAfterWillSendRequest(ResourceHandle* handle, const ResourceRequest& newRequest)458 static void continueAfterWillSendRequest(ResourceHandle* handle, const ResourceRequest& request) 459 459 { 460 460 // willSendRequest might cancel the load. … … 462 462 return; 463 463 464 ResourceRequest newRequest(request); 465 ResourceHandleInternal* d = handle->getInternal(); 466 if (protocolHostAndPortAreEqual(newRequest.url(), d->m_response.url())) 467 applyAuthenticationToRequest(handle, newRequest, true); 468 464 469 if (!createSoupRequestAndMessageForHandle(handle, newRequest, true)) { 465 handle->getInternal()->client()->cannotShowURL(handle);470 d->client()->cannotShowURL(handle); 466 471 return; 467 472 } … … 514 519 // TODO: We are losing any username and password specified in the redirect URL, as this is the 515 520 // same behavior as the CFNet port. We should investigate if this is really what we want. 516 } else 517 applyAuthenticationToRequest(handle, newRequest, true); 518 519 // If we sent credentials with this request's URL, we don't want the response to carry them to 520 // the WebKit layer. They were only placed in the URL for the benefit of libsoup. 521 newRequest.removeCredentials(); 521 } 522 522 523 523 cleanupSoupRequestOperation(handle);
Note: See TracChangeset
for help on using the changeset viewer.