Changeset 161878 in webkit


Ignore:
Timestamp:
Jan 13, 2014 8:15:46 AM (10 years ago)
Author:
commit-queue@webkit.org
Message:

REGRESSION(r161715): Use of uninitialized value $ENV{"PLATFORM_NAME"}
https://bugs.webkit.org/show_bug.cgi?id=126873

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-01-13
Reviewed by Csaba Osztrogonác.

  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r161877 r161878  
     12014-01-13  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
     2
     3        REGRESSION(r161715): Use of uninitialized value $ENV{"PLATFORM_NAME"}
     4        https://bugs.webkit.org/show_bug.cgi?id=126873
     5
     6        Reviewed by Csaba Osztrogonác.
     7
     8        * bindings/scripts/CodeGeneratorObjC.pm:
     9        * bindings/scripts/preprocessor.pm:
     10        (applyPreprocessor):
     11
    1122014-01-13  Andreas Kling  <akling@apple.com>
    213
  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm

    r161692 r161878  
    112112
    113113# Constants
    114 my $buildingForIPhone = ($ENV{PLATFORM_NAME} eq "iphoneos" or $ENV{PLATFORM_NAME} eq "iphonesimulator");
     114my $buildingForIPhone = defined $ENV{PLATFORM_NAME} && ($ENV{PLATFORM_NAME} eq "iphoneos" or $ENV{PLATFORM_NAME} eq "iphonesimulator");
    115115my $nullableInit = "bool isNull = false;";
    116116my $exceptionInit = "WebCore::ExceptionCode ec = 0;";
  • trunk/Source/WebCore/bindings/scripts/preprocessor.pm

    r161715 r161878  
    6161        push(@args, "-I" . $ENV{BUILT_PRODUCTS_DIR} . "/usr/local/include") if $ENV{BUILT_PRODUCTS_DIR};
    6262        push(@args, "-isysroot", $ENV{SDKROOT}) if $ENV{SDKROOT};
    63         $defines .= " WTF_PLATFORM_IOS" if $ENV{PLATFORM_NAME} =~ /iphone(os|simulator)/;
     63        $defines .= " WTF_PLATFORM_IOS" if defined $ENV{PLATFORM_NAME} && $ENV{PLATFORM_NAME} =~ /iphone(os|simulator)/;
    6464    }
    6565
Note: See TracChangeset for help on using the changeset viewer.