Changeset 162270 in webkit

Timestamp:

Jan 18, 2014 1:11:56 PM (10 years ago)

Author:

mark.lam@apple.com

Message:

Add a hasBreakpointFlag arg to the op_debug bytecode.
​https://bugs.webkit.org/show_bug.cgi?id=127230.

Reviewed by Geoffrey Garen.

This is in anticipation of upcoming changes to support bytecode level
breakpoints. This patch adds the flag to the op_debug bytecode and
initializes it, but does not use it yet.

• bytecode/Opcode.h:

(JSC::padOpcodeName):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

• llint/LowLevelInterpreter.asm:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecode/Opcode.h (modified) (2 diffs)
• bytecompiler/BytecodeGenerator.cpp (modified) (2 diffs)
• llint/LowLevelInterpreter.asm (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-01-18  Mark Lam  <mark.lam@apple.com>
+
+        Add a hasBreakpointFlag arg to the op_debug bytecode.
+        https://bugs.webkit.org/show_bug.cgi?id=127230.
+
+        Reviewed by Geoffrey Garen.
+
+        This is in anticipation of upcoming changes to support bytecode level
+        breakpoints. This patch adds the flag to the op_debug bytecode and
+        initializes it, but does not use it yet.
+
+        * bytecode/Opcode.h:
+        (JSC::padOpcodeName):
+        * bytecompiler/BytecodeGenerator.cpp:
+        (JSC::BytecodeGenerator::emitDebugHook):
+        * llint/LowLevelInterpreter.asm:
+
 2014-01-18  Alberto Garcia  <berto@igalia.com>
 

trunk/Source/JavaScriptCore/bytecode/Opcode.h

@@ -1 +1 @@
 /*
- * Copyright (C) 2008, 2009, 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2008, 2009, 2013, 2014 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Cameron Zwarich <cwzwarich@uwaterloo.ca>
  *
@@ -186 +186 @@
     macro(op_throw_static_error, 3) \
     \
-    macro(op_debug, 2) \
+    macro(op_debug, 3) \
     macro(op_profile_will_call, 2) \
     macro(op_profile_did_call, 2) \

trunk/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp

@@ -1 +1 @@
 /*
- * Copyright (C) 2008, 2009, 2012, 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2008, 2009, 2012, 2013, 2014 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Cameron Zwarich <cwzwarich@uwaterloo.ca>
  * Copyright (C) 2012 Igalia, S.L.
@@ -1951 +1951 @@
     emitOpcode(op_debug);
     instructions().append(debugHookID);
+    instructions().append(false);
 }
 

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.asm

@@ -1 @@
-# Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.
+# Copyright (C) 2011, 2012, 2013, 2014 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
@@ -845 +845 @@
     callSlowPath(_llint_slow_path_debug)
 .opDebugDone:                    
-    dispatch(2)
+    dispatch(3)