Changeset 162272 in webkit


Ignore:
Timestamp:
Jan 18, 2014 1:15:19 PM (10 years ago)
Author:
andersca@apple.com
Message:

Remove support for the viewsource attribute
​https://bugs.webkit.org/show_bug.cgi?id=127232

Reviewed by Andreas Kling.

Source/WebCore:

The 'viewsource' attribute on frames is nonstandard, not used by anyone (the inspector has
its own syntax highlighting) and not audited.

This patch removes parsing of the viewsource attribute and the associated tests. A subsequent
patch will remove the code as well.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):

Source/WTF:

  • wtf/FeatureDefines.h:

LayoutTests:

  • .gitattributes:
  • fast/frames/resources/viewsource-fake-image-file.png: Removed.
  • fast/frames/resources/viewsource-frame-1.html: Removed.
  • fast/frames/resources/viewsource-frame-2.html: Removed.
  • fast/frames/resources/viewsource-frame-3.html: Removed.
  • fast/frames/resources/viewsource-frame-4.html: Removed.
  • fast/frames/resources/viewsource-frame-5.html: Removed.
  • fast/frames/resources/viewsource-frame-unfinished-script.html: Removed.
  • fast/frames/resources/viewsource-frame-unfinished-textarea.html: Removed.
  • fast/frames/viewsource-attribute.html: Removed.
  • fast/frames/viewsource-empty-attribute-value-expected.txt: Removed.
  • fast/frames/viewsource-empty-attribute-value.html: Removed.
  • fast/frames/viewsource-linebreak-expected.txt: Removed.
  • fast/frames/viewsource-linebreak.html: Removed.
  • fast/frames/viewsource-link-on-href-value-expected.txt: Removed.
  • fast/frames/viewsource-link-on-href-value.html: Removed.
  • fast/frames/viewsource-on-image-file.html: Removed.
  • fast/frames/viewsource-plain-text-tags-expected.txt: Removed.
  • fast/frames/viewsource-plain-text-tags.html: Removed.
  • fast/frames/viewsource-unfinished-tags-expected.txt: Removed.
  • fast/frames/viewsource-unfinished-tags.html: Removed.
  • fast/frames/viewsource-xml-expected.txt: Removed.
  • fast/frames/viewsource-xml.html: Removed.
  • http/tests/security/resources/view-source-no-refresh.php: Removed.
  • http/tests/security/view-source-javascript-url-in-document-expected.txt: Removed.
  • http/tests/security/view-source-javascript-url-in-document.html: Removed.
  • http/tests/security/view-source-no-javascript-url-expected.txt: Removed.
  • http/tests/security/view-source-no-javascript-url.html: Removed.
  • http/tests/security/view-source-no-refresh-expected.txt: Removed.
  • http/tests/security/view-source-no-refresh.html: Removed.
  • platform/efl/fast/frames/viewsource-attribute-expected.png: Removed.
  • platform/efl/fast/frames/viewsource-attribute-expected.txt: Removed.
  • platform/efl/fast/frames/viewsource-on-image-file-expected.png: Removed.
  • platform/efl/fast/frames/viewsource-on-image-file-expected.txt: Removed.
  • platform/mac/fast/frames/viewsource-attribute-expected.png: Removed.
  • platform/mac/fast/frames/viewsource-attribute-expected.txt: Removed.
  • platform/mac/fast/frames/viewsource-on-image-file-expected.png: Removed.
  • platform/mac/fast/frames/viewsource-on-image-file-expected.txt: Removed.
  • platform/win/TestExpectations:
Location:
trunk
Files:
37 deleted
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/.gitattributes

    r113047 r162272  
    105105fast/frames/resources/iframe-scroll-page-up-down-1.html -crlf
    106106fast/frames/resources/iframe-scroll-page-up-down-2.html -crlf
    107 fast/frames/viewsource-attribute.html -crlf
    108107fast/inline/inline-padding-disables-text-quirk.html -crlf
    109108fast/loader/submit-form-while-parsing-1.xhtml -crlf

  • trunk/LayoutTests/ChangeLog

    r162262 r162272  
     12014-01-18  Anders Carlsson  <andersca@apple.com>
     2
     3        Remove support for the viewsource attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=127232
     5
     6        Reviewed by Andreas Kling.
     7
     8        * .gitattributes:
     9        * fast/frames/resources/viewsource-fake-image-file.png: Removed.
     10        * fast/frames/resources/viewsource-frame-1.html: Removed.
     11        * fast/frames/resources/viewsource-frame-2.html: Removed.
     12        * fast/frames/resources/viewsource-frame-3.html: Removed.
     13        * fast/frames/resources/viewsource-frame-4.html: Removed.
     14        * fast/frames/resources/viewsource-frame-5.html: Removed.
     15        * fast/frames/resources/viewsource-frame-unfinished-script.html: Removed.
     16        * fast/frames/resources/viewsource-frame-unfinished-textarea.html: Removed.
     17        * fast/frames/viewsource-attribute.html: Removed.
     18        * fast/frames/viewsource-empty-attribute-value-expected.txt: Removed.
     19        * fast/frames/viewsource-empty-attribute-value.html: Removed.
     20        * fast/frames/viewsource-linebreak-expected.txt: Removed.
     21        * fast/frames/viewsource-linebreak.html: Removed.
     22        * fast/frames/viewsource-link-on-href-value-expected.txt: Removed.
     23        * fast/frames/viewsource-link-on-href-value.html: Removed.
     24        * fast/frames/viewsource-on-image-file.html: Removed.
     25        * fast/frames/viewsource-plain-text-tags-expected.txt: Removed.
     26        * fast/frames/viewsource-plain-text-tags.html: Removed.
     27        * fast/frames/viewsource-unfinished-tags-expected.txt: Removed.
     28        * fast/frames/viewsource-unfinished-tags.html: Removed.
     29        * fast/frames/viewsource-xml-expected.txt: Removed.
     30        * fast/frames/viewsource-xml.html: Removed.
     31        * http/tests/security/resources/view-source-no-refresh.php: Removed.
     32        * http/tests/security/view-source-javascript-url-in-document-expected.txt: Removed.
     33        * http/tests/security/view-source-javascript-url-in-document.html: Removed.
     34        * http/tests/security/view-source-no-javascript-url-expected.txt: Removed.
     35        * http/tests/security/view-source-no-javascript-url.html: Removed.
     36        * http/tests/security/view-source-no-refresh-expected.txt: Removed.
     37        * http/tests/security/view-source-no-refresh.html: Removed.
     38        * platform/efl/fast/frames/viewsource-attribute-expected.png: Removed.
     39        * platform/efl/fast/frames/viewsource-attribute-expected.txt: Removed.
     40        * platform/efl/fast/frames/viewsource-on-image-file-expected.png: Removed.
     41        * platform/efl/fast/frames/viewsource-on-image-file-expected.txt: Removed.
     42        * platform/mac/fast/frames/viewsource-attribute-expected.png: Removed.
     43        * platform/mac/fast/frames/viewsource-attribute-expected.txt: Removed.
     44        * platform/mac/fast/frames/viewsource-on-image-file-expected.png: Removed.
     45        * platform/mac/fast/frames/viewsource-on-image-file-expected.txt: Removed.
     46        * platform/win/TestExpectations:
     47
    1482014-01-18  Alexey Proskuryakov  <ap@apple.com>
    249

  • trunk/LayoutTests/platform/win/TestExpectations

    r161417 r162272  
    377377fast/encoding/frame-default-enc.html
    378378http/tests/misc/frame-default-enc-same-domain.html
    379 
    380 #<rdar://problem/5829328> REGRESSION: fast/frames/viewsource-empty-attribute-value.html fails on Windows intermittently
    381 fast/frames/viewsource-empty-attribute-value.html
    382379
    383380# <rdar://problem/5539822> REGRESSION (Leopard): svg/custom/stroke-width-click.svg test failing
    … …  
    20312028fast/css/acid2-pixel.html
    20322029fast/css/border-height.html
    2033 fast/frames/viewsource-attribute.html
    2034 fast/frames/viewsource-on-image-file.html
    20352030fast/inline/inline-padding-disables-text-quirk.html
    20362031fast/inline/inline-text-quirk-bpm.html

  • trunk/Source/WTF/ChangeLog

    r162260 r162272  
     12014-01-18  Anders Carlsson  <andersca@apple.com>
     2
     3        Remove support for the viewsource attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=127232
     5
     6        Reviewed by Andreas Kling.
     7
     8        * wtf/FeatureDefines.h:
     9
    1102014-01-18  Anders Carlsson  <andersca@apple.com>
    211

  • trunk/Source/WTF/wtf/FeatureDefines.h

    r162260 r162272  
    831831#endif
    832832
    833 #if !defined(ENABLE_VIEWSOURCE_ATTRIBUTE)
    834 #define ENABLE_VIEWSOURCE_ATTRIBUTE 1
    835 #endif
    836 
    837833#if !defined(ENABLE_VIEW_MODE_CSS_MEDIA)
    838834#define ENABLE_VIEW_MODE_CSS_MEDIA 1

  • trunk/Source/WebCore/ChangeLog

    r162269 r162272  
     12014-01-18  Anders Carlsson  <andersca@apple.com>
     2
     3        Remove support for the viewsource attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=127232
     5
     6        Reviewed by Andreas Kling.
     7
     8        The 'viewsource' attribute on frames is nonstandard, not used by anyone (the inspector has
     9        its own syntax highlighting) and not audited.
     10
     11        This patch removes parsing of the viewsource attribute and the associated tests. A subsequent
     12        patch will remove the code as well.
     13
     14        * html/HTMLFrameElementBase.cpp:
     15        (WebCore::HTMLFrameElementBase::parseAttribute):
     16
    1172014-01-18  Anders Carlsson  <andersca@apple.com>
    218

  • trunk/Source/WebCore/html/HTMLFrameElementBase.cpp

    r160908 r162272  
    120120            m_scrolling = ScrollbarAlwaysOff;
    121121        // FIXME: If we are already attached, this has no effect.
    122 #if ENABLE(VIEWSOURCE_ATTRIBUTE)
    123     } else if (name == viewsourceAttr) {
    124         m_viewSource = !value.isNull();
    125         if (contentFrame())
    126             contentFrame()->setInViewSourceMode(viewSourceMode());
    127 #endif
    128122    } else if (name == onbeforeloadAttr)
    129123        setAttributeEventListener(eventNames().beforeloadEvent, name, value);
Note: See TracChangeset for help on using the changeset viewer.