Changeset 162376 in webkit

Timestamp:

Jan 20, 2014 2:05:08 PM (10 years ago)

Author:

zandobersek@gmail.com

Message:

Replace uses of std::forward<T>(), std::unique_ptr<T>::clear() that landed in r162368
​https://bugs.webkit.org/show_bug.cgi?id=127306

Reviewed by Darin Adler.

Address the post-landing reviews of the r162368 commit that moved WebAudio source code to using std::unique_ptr.
std::move() should be used instead of std::forward<T>() in HRTFKernel::create().
Instead of calling std::unique_ptr<T>::reset(), nullptr should be assigned to that smart pointer to reset it.

• Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::uninitialize):

• Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::uninitialize):

• Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::setFormat):

• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::uninitialize):

• platform/audio/AudioChannel.h:

(WebCore::AudioChannel::set):

• platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):

• platform/audio/HRTFKernel.h:

(WebCore::HRTFKernel::create):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webaudio/ConvolverNode.cpp (modified) (1 diff)
• Modules/webaudio/DynamicsCompressorNode.cpp (modified) (1 diff)
• Modules/webaudio/MediaElementAudioSourceNode.cpp (modified) (1 diff)
• Modules/webaudio/PannerNode.cpp (modified) (1 diff)
• platform/audio/AudioChannel.h (modified) (1 diff)
• platform/audio/HRTFDatabaseLoader.cpp (modified) (1 diff)
• platform/audio/HRTFKernel.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-01-20  Zan Dobersek  <zdobersek@igalia.com>
+
+        Replace uses of std::forward<T>(), std::unique_ptr<T>::clear() that landed in r162368
+        https://bugs.webkit.org/show_bug.cgi?id=127306
+
+        Reviewed by Darin Adler.
+
+        Address the post-landing reviews of the r162368 commit that moved WebAudio source code to using std::unique_ptr.
+        std::move() should be used instead of std::forward<T>() in HRTFKernel::create().
+        Instead of calling std::unique_ptr<T>::reset(), nullptr should be assigned to that smart pointer to reset it.
+
+        * Modules/webaudio/ConvolverNode.cpp:
+        (WebCore::ConvolverNode::uninitialize):
+        * Modules/webaudio/DynamicsCompressorNode.cpp:
+        (WebCore::DynamicsCompressorNode::uninitialize):
+        * Modules/webaudio/MediaElementAudioSourceNode.cpp:
+        (WebCore::MediaElementAudioSourceNode::setFormat):
+        * Modules/webaudio/PannerNode.cpp:
+        (WebCore::PannerNode::uninitialize):
+        * platform/audio/AudioChannel.h:
+        (WebCore::AudioChannel::set):
+        * platform/audio/HRTFDatabaseLoader.cpp:
+        (WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):
+        * platform/audio/HRTFKernel.h:
+        (WebCore::HRTFKernel::create):
+
 2014-01-20  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/Modules/webaudio/ConvolverNode.cpp

@@ -112 +112 @@
         return;
 
-    m_reverb.reset();
+    m_reverb = nullptr;
     AudioNode::uninitialize();
 }

trunk/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.cpp

@@ -104 +104 @@
         return;
 
-    m_dynamicsCompressor.reset();
+    m_dynamicsCompressor = nullptr;
     AudioNode::uninitialize();
 }

trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp

@@ -88 +88 @@
         } else {
             // Bypass resampling.
-            m_multiChannelResampler.reset();
+            m_multiChannelResampler = nullptr;
         }
 

trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp

@@ -155 +155 @@
         return;
         
-    m_panner.reset();
+    m_panner = nullptr;
     AudioNode::uninitialize();
 }

trunk/Source/WebCore/platform/audio/AudioChannel.h

@@ -71 +71 @@
     void set(float* storage, size_t length)
     {
-        m_memBuffer.reset(); // cleanup managed storage
+        m_memBuffer = nullptr; // cleanup managed storage
         m_rawPointer = storage;
         m_length = length;

trunk/Source/WebCore/platform/audio/HRTFDatabaseLoader.cpp

@@ -78 +78 @@
 
     waitForLoaderThreadCompletion();
-    m_hrtfDatabase.reset();
+    m_hrtfDatabase = nullptr;
 
     // Remove ourself from the map.

trunk/Source/WebCore/platform/audio/HRTFKernel.h

@@ -58 +58 @@
     static PassRefPtr<HRTFKernel> create(std::unique_ptr<FFTFrame> fftFrame, float frameDelay, float sampleRate)
     {
-        return adoptRef(new HRTFKernel(std::forward<std::unique_ptr<FFTFrame>>(fftFrame), frameDelay, sampleRate));
+        return adoptRef(new HRTFKernel(std::move(fftFrame), frameDelay, sampleRate));
     }