Changeset 162377 in webkit

Timestamp:

Jan 20, 2014 2:17:22 PM (10 years ago)

Author:

mhahnenberg@apple.com

Message:

CodeBlockSet::traceMarked doesn't need to visit the ownerExecutable
​https://bugs.webkit.org/show_bug.cgi?id=127301

Reviewed by Oliver Hunt.

We used to just call CodeBlock::visitAggregate, but now we call visitChildren
on the ownerExecutable, which is unnecessary.

• heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::traceMarked):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• heap/CodeBlockSet.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-01-20  Mark Hahnenberg  <mhahnenberg@apple.com>
+
+        CodeBlockSet::traceMarked doesn't need to visit the ownerExecutable
+        https://bugs.webkit.org/show_bug.cgi?id=127301
+
+        Reviewed by Oliver Hunt.
+
+        We used to just call CodeBlock::visitAggregate, but now we call visitChildren 
+        on the ownerExecutable, which is unnecessary. 
+
+        * heap/CodeBlockSet.cpp:
+        (JSC::CodeBlockSet::traceMarked):
+
 2014-01-20  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/JavaScriptCore/heap/CodeBlockSet.cpp

@@ -103 +103 @@
         if (!codeBlock->m_mayBeExecuting)
             continue;
-        codeBlock->ownerExecutable()->methodTable()->visitChildren(codeBlock->ownerExecutable(), visitor);
+        codeBlock->visitAggregate(visitor);
     }
 }