Changeset 162382 in webkit


Ignore:
Timestamp:
Jan 20, 2014 3:39:14 PM (10 years ago)
Author:
thiago.lacerda@openbossa.org
Message:

[WK2] Setting m_pageScaleFactor directly in WebPageProxy::scalePage
https://bugs.webkit.org/show_bug.cgi?id=127090

Reviewed by Simon Fraser.

When the client side sets the scale factor, the UIProcess will send the message to WebProcess and only after
WebPageProxy::pageScaleFactorDidChange is called the desired scale factor is returned correctly by
WebPageProxy::pageScaleFactor.
This will avoid the client side retrieve a wrong scale factor while UIProcess and WebProcess gets synchronized.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::scalePage):

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r162370 r162382  
     12014-01-20  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
     2
     3        [WK2] Setting m_pageScaleFactor directly in WebPageProxy::scalePage
     4        https://bugs.webkit.org/show_bug.cgi?id=127090
     5
     6        Reviewed by Simon Fraser.
     7
     8        When the client side sets the scale factor, the UIProcess will send the message to WebProcess and only after
     9        WebPageProxy::pageScaleFactorDidChange is called the desired scale factor is returned correctly by
     10        WebPageProxy::pageScaleFactor.
     11        This will avoid the client side retrieve a wrong scale factor while UIProcess and WebProcess gets synchronized.
     12
     13        * UIProcess/WebPageProxy.cpp:
     14        (WebKit::WebPageProxy::scalePage):
     15
    1162014-01-20  Zan Dobersek  <zdobersek@igalia.com>
    217
  • trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

    r162271 r162382  
    15961596        return;
    15971597
     1598    m_pageScaleFactor = scale;
    15981599    m_process->send(Messages::WebPage::ScalePage(scale, origin), m_pageID);
    15991600}
Note: See TracChangeset for help on using the changeset viewer.