Changeset 162386 in webkit

Timestamp:

Jan 20, 2014 4:27:22 PM (10 years ago)

Author:

eunmi15.lee@samsung.com

Message:

[EFL][WK2] Amount of scrolling is different from movement of touch when device pixel ratio is not 1.
​https://bugs.webkit.org/show_bug.cgi?id=127268

Reviewed by Gyuyoung Kim.

Amount of scrolling should be same with movement of touch even though
device pixel ratio is not 1, so apply device pixel ratio to the new
position of scrollBy().

• UIProcess/API/efl/EwkView.cpp:

(EwkView::scrollBy):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/efl/EwkView.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-01-20  Eunmi Lee  <eunmi15.lee@samsung.com>
+
+        [EFL][WK2] Amount of scrolling is different from movement of touch when device pixel ratio is not 1.
+        https://bugs.webkit.org/show_bug.cgi?id=127268
+
+        Reviewed by Gyuyoung Kim.
+
+        Amount of scrolling should be same with movement of touch even though
+        device pixel ratio is not 1, so apply device pixel ratio to the new
+        position of scrollBy().
+
+        * UIProcess/API/efl/EwkView.cpp:
+        (EwkView::scrollBy):
+
 2014-01-20  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
 

trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp

@@ -1416 +1416 @@
     float contentScale = WKViewGetContentScaleFactor(wkView());
 
-    FloatPoint newPosition(oldPosition.x + offset.width() / contentScale, oldPosition.y + offset.height() / contentScale);
+    float effectiveScale = contentScale * deviceScaleFactor();
+    FloatPoint newPosition(oldPosition.x + offset.width() / effectiveScale, oldPosition.y + offset.height() / effectiveScale);
 
     // Update new position to the PageViewportController.