Changeset 162474 in webkit


Ignore:
Timestamp:
Jan 21, 2014 2:14:37 PM (10 years ago)
Author:
ap@apple.com
Message:

platform/mac/accessibility/iframe-aria-hidden.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=127323

Reviewed by Chris Fleizach.

This test got de-flaked on bots by rolling out r162354. But there was still
a potential race in it, which this change fixes.

  • platform/mac-wk2/TestExpectations: Removed expectation.
  • platform/mac/accessibility/iframe-aria-hidden.html: Run the test in onload, as

frames load asynchronously.

Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r162466 r162474  
     12014-01-21  Alexey Proskuryakov  <ap@apple.com>
     2
     3        platform/mac/accessibility/iframe-aria-hidden.html is flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=127323
     5
     6        Reviewed by Chris Fleizach.
     7
     8        This test got de-flaked on bots by rolling out r162354. But there was still
     9        a potential race in it, which this change fixes.
     10
     11        * platform/mac-wk2/TestExpectations: Removed expectation.
     12
     13        * platform/mac/accessibility/iframe-aria-hidden.html: Run the test in onload, as
     14        frames load asynchronously.
     15
    1162014-01-21  Chris Fleizach  <cfleizach@apple.com>
    217

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r162392 r162474  
    452452webkit.org/b/127316 svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html [ Pass Timeout ]
    453453
    454 webkit.org/b/127323 platform/mac/accessibility/iframe-aria-hidden.html [ Pass Failure ]
    455 
    456454### END OF (3) Unclassified failures
    457455########################################

  • trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html

    r155423 r162474  
    1515
    1616<script>
     17description("This tests that aria-hidden will affect the visibility of the web area and scroll view.");
    1718
    18     description("This tests that aria-hidden will affect the visibility of the web area and scroll view.");
     19if (window.accessibilityController) {
     20    jsTestIsAsync = true;
    1921
    20     if (window.accessibilityController) {
     22    // Get the iframe reference.
     23    document.getElementById("body").focus();
     24    var body = accessibilityController.focusedElement;
    2125
    22         document.getElementById("body").focus();
    23 
    24         // Get the iframe reference.
    25         var body = accessibilityController.focusedElement;
     26    window.onload = function() {
    2627        shouldBe("body.childrenCount", "3");
    2728        shouldBe("body.childAtIndex(0).childrenCount", "0");
    … …  
    3031        shouldBe("body.childrenCount", "4");
    3132        shouldBe("body.childAtIndex(0).childAtIndex(0).childAtIndex(0).role", "'AXRole: AXWebArea'");
     33
     34        finishJSTest();
    3235    }
     36} else
     37    testFailed("This test relies on accessibilityController, please use run-webkit-tests to run it.")
    3338
    34     successfullyParsed = true;
     39successfullyParsed = true;
    3540</script>
    3641
Note: See TracChangeset for help on using the changeset viewer.