Changeset 162786 in webkit


Ignore:
Timestamp:
Jan 25, 2014 3:04:54 PM (10 years ago)
Author:
andersca@apple.com
Message:

Remove an unused FrameLoaderClient function
​https://bugs.webkit.org/show_bug.cgi?id=127628

Reviewed by Andreas Kling.

Source/WebCore:

All implementations of FrameLoaderClient::shouldStopLoadingForHistoryItem return true and this function
was only used by Chromium so we can get rid of it.

  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:
  • loader/HistoryController.cpp:

(WebCore::HistoryController::shouldStopLoadingForHistoryItem):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:
  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Location:
trunk/Source
Files:
22 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r162784 r162786  
     12014-01-25  Anders Carlsson  <andersca@apple.com>
     2
     3        Remove an unused FrameLoaderClient function
     4        https://bugs.webkit.org/show_bug.cgi?id=127628
     5
     6        Reviewed by Andreas Kling.
     7
     8        All implementations of FrameLoaderClient::shouldStopLoadingForHistoryItem return true and this function
     9        was only used by Chromium so we can get rid of it.
     10
     11        * loader/EmptyClients.h:
     12        * loader/FrameLoaderClient.h:
     13        * loader/HistoryController.cpp:
     14        (WebCore::HistoryController::shouldStopLoadingForHistoryItem):
     15
    1162014-01-25  Darin Adler  <darin@apple.com>
    217

  • trunk/Source/WebCore/loader/EmptyClients.h

    r162451 r162786  
    367367    virtual void updateGlobalHistoryRedirectLinks() override { }
    368368    virtual bool shouldGoToHistoryItem(HistoryItem*) const override { return false; }
    369     virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const override { return false; }
    370369    virtual void updateGlobalHistoryItemForPage() override { }
    371370    virtual void saveViewStateToItem(HistoryItem*) override { }

  • trunk/Source/WebCore/loader/FrameLoaderClient.h

    r162227 r162786  
    202202
    203203        virtual bool shouldGoToHistoryItem(HistoryItem*) const = 0;
    204         virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const = 0;
    205204        virtual void updateGlobalHistoryItemForPage() { }
    206205

  • trunk/Source/WebCore/loader/HistoryController.cpp

    r162234 r162786  
    254254        return false;
    255255
    256     return m_frame.loader().client().shouldStopLoadingForHistoryItem(targetItem);
     256    return true;
    257257}
    258258

  • trunk/Source/WebKit/efl/ChangeLog

    r162762 r162786  
     12014-01-25  Anders Carlsson  <andersca@apple.com>
     2
     3        Remove an unused FrameLoaderClient function
     4        https://bugs.webkit.org/show_bug.cgi?id=127628
     5
     6        Reviewed by Andreas Kling.
     7
     8        * WebCoreSupport/FrameLoaderClientEfl.cpp:
     9        * WebCoreSupport/FrameLoaderClientEfl.h:
     10
    1112014-01-25  Ryuan Choi  <ryuan.choi@samsung.com>
    212

  • trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp

    r162227 r162786  
    539539}
    540540
    541 bool FrameLoaderClientEfl::shouldStopLoadingForHistoryItem(HistoryItem*) const
    542 {
    543     return true;
    544 }
    545 
    546541void FrameLoaderClientEfl::didDisplayInsecureContent()
    547542{

  • trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h

    r162227 r162786  
    151151    virtual void updateGlobalHistoryRedirectLinks();
    152152    virtual bool shouldGoToHistoryItem(HistoryItem*) const;
    153     virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const;
    154153    virtual void didDisplayInsecureContent();
    155154    virtual void didRunInsecureContent(SecurityOrigin*, const URL&);

  • trunk/Source/WebKit/gtk/ChangeLog

    r162751 r162786  
     12014-01-25  Anders Carlsson  <andersca@apple.com>
     2
     3        Remove an unused FrameLoaderClient function
     4        https://bugs.webkit.org/show_bug.cgi?id=127628
     5
     6        Reviewed by Andreas Kling.
     7
     8        * WebCoreSupport/FrameLoaderClientGtk.cpp:
     9        * WebCoreSupport/FrameLoaderClientGtk.h:
     10
    1112014-01-24  Anders Carlsson  <andersca@apple.com>
    212

  • trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp

    r162599 r162786  
    622622}
    623623
    624 bool FrameLoaderClient::shouldStopLoadingForHistoryItem(HistoryItem* item) const
    625 {
    626     return true;
    627 }
    628 
    629624void FrameLoaderClient::didDisplayInsecureContent()
    630625{

  • trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h

    r162227 r162786  
    138138        virtual void updateGlobalHistoryRedirectLinks();
    139139        virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
    140         virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
    141140
    142141        virtual void didDisplayInsecureContent();

  • trunk/Source/WebKit/mac/ChangeLog

    r162775 r162786  
     12014-01-25  Anders Carlsson  <andersca@apple.com>
     2
     3        Remove an unused FrameLoaderClient function
     4        https://bugs.webkit.org/show_bug.cgi?id=127628
     5
     6        Reviewed by Andreas Kling.
     7
     8        * WebCoreSupport/WebFrameLoaderClient.h:
     9        * WebCoreSupport/WebFrameLoaderClient.mm:
     10
    1112014-01-25  Anders Carlsson  <andersca@apple.com>
    212

  • trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h

    r162227 r162786  
    148148
    149149    virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const override;
    150     virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const override;
    151150    virtual void updateGlobalHistoryItemForPage() override;
    152151

  • trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm

    r162764 r162786  
    11351135}
    11361136
    1137 bool WebFrameLoaderClient::shouldStopLoadingForHistoryItem(HistoryItem* item) const
    1138 {
    1139     return true;
    1140 }
    1141 
    11421137void WebFrameLoaderClient::updateGlobalHistoryItemForPage()
    11431138{

  • trunk/Source/WebKit/win/ChangeLog

    r162774 r162786  
     12014-01-25  Anders Carlsson  <andersca@apple.com>
     2
     3        Remove an unused FrameLoaderClient function
     4        https://bugs.webkit.org/show_bug.cgi?id=127628
     5
     6        Reviewed by Andreas Kling.
     7
     8        * WebCoreSupport/WebFrameLoaderClient.cpp:
     9        * WebCoreSupport/WebFrameLoaderClient.h:
     10
    1112014-01-25  Anders Carlsson  <andersca@apple.com>
    212

  • trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp

    r162234 r162786  
    815815}
    816816
    817 bool WebFrameLoaderClient::shouldStopLoadingForHistoryItem(HistoryItem*) const
    818 {
    819     return true;
    820 }
    821 
    822817void WebFrameLoaderClient::updateGlobalHistoryItemForPage()
    823818{

  • trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h

    r162227 r162786  
    133133    virtual void updateGlobalHistoryRedirectLinks() override;
    134134    virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const override;
    135     virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const override;
    136135    virtual void updateGlobalHistoryItemForPage() override;
    137136

  • trunk/Source/WebKit/wince/ChangeLog

    r162227 r162786  
     12014-01-25  Anders Carlsson  <andersca@apple.com>
     2
     3        Remove an unused FrameLoaderClient function
     4        https://bugs.webkit.org/show_bug.cgi?id=127628
     5
     6        Reviewed by Andreas Kling.
     7
     8        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
     9        * WebCoreSupport/FrameLoaderClientWinCE.h:
     10
    1112014-01-17  Anders Carlsson  <andersca@apple.com>
    212

  • trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp

    r162227 r162786  
    244244}
    245245
    246 bool FrameLoaderClientWinCE::shouldStopLoadingForHistoryItem(HistoryItem* item) const
    247 {
    248     return true;
    249 }
    250 
    251246void FrameLoaderClientWinCE::didDisplayInsecureContent()
    252247{

  • trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h

    r162227 r162786  
    131131    virtual void updateGlobalHistoryRedirectLinks() override;
    132132    virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const override;
    133     virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const override;
    134133
    135134    virtual void didDisplayInsecureContent() override;

  • trunk/Source/WebKit2/ChangeLog

    r162777 r162786  
     12014-01-25  Anders Carlsson  <andersca@apple.com>
     2
     3        Remove an unused FrameLoaderClient function
     4        https://bugs.webkit.org/show_bug.cgi?id=127628
     5
     6        Reviewed by Andreas Kling.
     7
     8        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
     9        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
     10
    1112014-01-25  Anders Carlsson  <andersca@apple.com>
    212

  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

    r162653 r162786  
    947947}
    948948
    949 bool WebFrameLoaderClient::shouldStopLoadingForHistoryItem(HistoryItem*) const
    950 {
    951     return true;
    952 }
    953 
    954949void WebFrameLoaderClient::didDisplayInsecureContent()
    955950{

  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h

    r162229 r162786  
    130130   
    131131    virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const override;
    132     virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const override;
    133132
    134133    virtual void didDisplayInsecureContent() override;
Note: See TracChangeset for help on using the changeset viewer.