Changeset 162876 in webkit

Timestamp:

Jan 27, 2014 3:39:47 PM (10 years ago)

Author:

andersca@apple.com

Message:

Move underlying C++ objects to class extensions
​https://bugs.webkit.org/show_bug.cgi?id=127716

Reviewed by Tim Horton.

This allows us to get at the internals without calling any Obj-C methods.

• UIProcess/API/Cocoa/WKProcessClass.mm:
• UIProcess/API/Cocoa/WKProcessClassInternal.h:
• UIProcess/API/ios/WKContentView.mm:
• UIProcess/API/ios/WKContentViewInternal.h:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKProcessClass.mm (modified) (1 diff)
• UIProcess/API/Cocoa/WKProcessClassInternal.h (modified) (1 diff)
• UIProcess/API/ios/WKContentView.mm (modified) (1 diff)
• UIProcess/API/ios/WKContentViewInternal.h (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-01-27  Anders Carlsson  <andersca@apple.com>
+
+        Move underlying C++ objects to class extensions
+        https://bugs.webkit.org/show_bug.cgi?id=127716
+
+        Reviewed by Tim Horton.
+
+        This allows us to get at the internals without calling any Obj-C methods.
+
+        * UIProcess/API/Cocoa/WKProcessClass.mm:
+        * UIProcess/API/Cocoa/WKProcessClassInternal.h:
+        * UIProcess/API/ios/WKContentView.mm:
+        * UIProcess/API/ios/WKContentViewInternal.h:
+
 2014-01-27  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm

@@ -38 +38 @@
 #endif
 
-@implementation WKProcessClass {
-    RetainPtr<WKProcessClassConfiguration> _configuration;
-
-    API::ObjectStorage<WebKit::WebContext> _context;
-}
+@implementation WKProcessClass
 
 - (instancetype)init

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassInternal.h

@@ -41 +41 @@
 }
 
-@interface WKProcessClass () <WKObject>
+@interface WKProcessClass () <WKObject> {
+@package
+    RetainPtr<WKProcessClassConfiguration> _configuration;
+
+    API::ObjectStorage<WebKit::WebContext> _context;
+}
 @end
 

trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm

@@ -58 +58 @@
 @implementation WKContentView {
     std::unique_ptr<PageClientImpl> _pageClient;
-    RefPtr<WebPageProxy> _page;
     RetainPtr<WKBrowsingContextController> _browsingContextController;
 

trunk/Source/WebKit2/UIProcess/API/ios/WKContentViewInternal.h

@@ -40 +40 @@
 class LayerTreeContext;
 class WebFrameProxy;
+class WebPageProxy;
 class WebSecurityOrigin;
 struct InteractionInformationAtPosition;
@@ -46 +47 @@
 @class WebIOSEvent;
 
-@interface WKContentView ()
+@interface WKContentView () {
+@package
+    RefPtr<WebKit::WebPageProxy> _page;
+}
 
 - (std::unique_ptr<WebKit::DrawingAreaProxy>)_createDrawingAreaProxy;