Changeset 163335 in webkit


Ignore:
Timestamp:
Feb 3, 2014 3:39:53 PM (10 years ago)
Author:
jer.noble@apple.com
Message:

[WK2] Remove the VideoPluginProxyEnabled preference in WK2
​https://bugs.webkit.org/show_bug.cgi?id=128128

Reviewed by Brady Eidson.

The plugin proxy is iOS WK1 only, and has no meaning in WebKit2. Just set the preference to false.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:
  • UIProcess/API/C/WKPreferencesRef.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Location:
trunk/Source/WebKit2
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r163333 r163335  
     12014-02-03  Jer Noble  <jer.noble@apple.com>
     2
     3        [WK2] Remove the VideoPluginProxyEnabled preference in WK2
     4        https://bugs.webkit.org/show_bug.cgi?id=128128
     5
     6        Reviewed by Brady Eidson.
     7
     8        The plugin proxy is iOS WK1 only, and has no meaning in WebKit2. Just set the preference to false.
     9
     10        * Shared/WebPreferencesStore.h:
     11        * UIProcess/API/C/WKPreferences.cpp:
     12        * UIProcess/API/C/WKPreferencesRef.h:
     13        * WebProcess/WebPage/WebPage.cpp:
     14        (WebKit::WebPage::updatePreferences):
     15
    1162014-02-03  Dean Jackson  <dino@apple.com>
    217

  • trunk/Source/WebKit2/Shared/WebPreferencesStore.h

    r162853 r163335  
    175175    macro(BackgroundShouldExtendBeyondPage, backgroundShouldExtendBeyondPage, Bool, bool, false) \
    176176    macro(MediaStreamEnabled, mediaStreamEnabled, Bool, bool, false) \
    177     macro(VideoPluginProxyEnabled, isVideoPluginProxyEnabled, Bool, bool, DEFAULT_VIDEO_PLUGIN_PROXY_ENABLED) \
    178177    macro(UseLegacyTextAlignPositionedElementBehavior, useLegacyTextAlignPositionedElementBehavior, Bool, bool, false) \
    179178    macro(SpatialNavigationEnabled, spatialNavigationEnabled, Bool, bool, false) \

  • trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp

    r162853 r163335  
    12071207}
    12081208
    1209 void WKPreferencesSetVideoPluginProxyEnabled(WKPreferencesRef preferencesRef, bool enabled)
    1210 {
    1211     toImpl(preferencesRef)->setVideoPluginProxyEnabled(enabled);
    1212 }
    1213 
    1214 bool WKPreferencesGetVideoPluginProxyEnabled(WKPreferencesRef preferencesRef)
    1215 {
    1216     return toImpl(preferencesRef)->isVideoPluginProxyEnabled();
    1217 }
    1218 
    12191209void WKPreferencesSetSpatialNavigationEnabled(WKPreferencesRef preferencesRef, bool enabled)
    12201210{

  • trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRef.h

    r162650 r163335  
    245245WK_EXPORT bool WKPreferencesGetMediaStreamEnabled(WKPreferencesRef preferencesRef);
    246246
    247 // Defaults to true.
    248 WK_EXPORT void WKPreferencesSetVideoPluginProxyEnabled(WKPreferencesRef preferencesRef, bool enabled);
    249 WK_EXPORT bool WKPreferencesGetVideoPluginProxyEnabled(WKPreferencesRef preferencesRef);
    250 
    251247// Defaults to false.
    252248WK_EXPORT void WKPreferencesSetSpatialNavigationEnabled(WKPreferencesRef preferencesRef, bool enabled);

  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

    r163232 r163335  
    25312531
    25322532#if USE(PLUGIN_PROXY_FOR_VIDEO)
    2533     settings->setVideoPluginProxyEnabled(store.getBoolValueForKey(WebPreferencesKey::isVideoPluginProxyEnabledKey()));
     2533    settings->setVideoPluginProxyEnabled(false);
    25342534#endif
    25352535
Note: See TracChangeset for help on using the changeset viewer.