Changeset 163404 in webkit

Timestamp:

Feb 4, 2014 2:41:13 PM (10 years ago)

Author:

andersca@apple.com

Message:

Add back/forward related methods to WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=128209

Reviewed by Dan Bernstein.

• UIProcess/API/Cocoa/WKWebView.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView canGoBack]):
(-[WKWebView canGoForward]):
(-[WKWebView goBack]):
(-[WKWebView goForward]):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKWebView.h (modified) (1 diff)
• UIProcess/API/Cocoa/WKWebView.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-02-04  Anders Carlsson  <andersca@apple.com>
+
+        Add back/forward related methods to WKWebView
+        https://bugs.webkit.org/show_bug.cgi?id=128209
+
+        Reviewed by Dan Bernstein.
+
+        * UIProcess/API/Cocoa/WKWebView.h:
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView canGoBack]):
+        (-[WKWebView canGoForward]):
+        (-[WKWebView goBack]):
+        (-[WKWebView goForward]):
+
 2014-02-04  Enrica Casucci  <enrica@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h

@@ -82 +82 @@
 @property (nonatomic, readonly) BOOL hasOnlySecureContent;
 
+@property(readonly) BOOL canGoBack;
+@property(readonly) BOOL canGoForward;
+
+- (void)goBack;
+- (void)goForward;
+
 @end
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm

@@ -34 +34 @@
 #import "WKProcessClass.h"
 #import "WKWebViewConfiguration.h"
+#import "WebBackForwardList.h"
 #import "WebPageProxy.h"
 #import <wtf/RetainPtr.h>
@@ -154 +155 @@
 {
     return _page->pageLoadState().hasOnlySecureContent();
+}
+
+// FIXME: This should be KVO compliant.
+- (BOOL)canGoBack
+{
+    return !!_page->backForwardList().backItem();
+}
+
+// FIXME: This should be KVO compliant.
+- (BOOL)canGoForward
+{
+    return !!_page->backForwardList().forwardItem();
+}
+
+// FIXME: This should return a WKNavigation object.
+- (void)goBack
+{
+    _page->goBack();
+}
+
+// FIXME: This should return a WKNavigation object.
+- (void)goForward
+{
+    _page->goForward();
 }