Changeset 163567 in webkit


Ignore:
Timestamp:
Feb 6, 2014 3:29:43 PM (10 years ago)
Author:
andersca@apple.com
Message:

Add preferences property to WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=128337

Reviewed by Sam Weinig.

Also use RetainPtr for processClass and preferences so we won't leak them.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.h:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration processClass]):
(-[WKWebViewConfiguration setProcessClass:]):
(-[WKWebViewConfiguration preferences]):
(-[WKWebViewConfiguration setPreferences:]):

Location:
trunk/Source/WebKit2
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r163564 r163567  
     12014-02-06  Anders Carlsson  <andersca@apple.com>
     2
     3        Add preferences property to WKWebViewConfiguration
     4        https://bugs.webkit.org/show_bug.cgi?id=128337
     5
     6        Reviewed by Sam Weinig.
     7
     8        Also use RetainPtr for processClass and preferences so we won't leak them.
     9
     10        * UIProcess/API/Cocoa/WKWebViewConfiguration.h:
     11        * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
     12        (-[WKWebViewConfiguration copyWithZone:]):
     13        (-[WKWebViewConfiguration processClass]):
     14        (-[WKWebViewConfiguration setProcessClass:]):
     15        (-[WKWebViewConfiguration preferences]):
     16        (-[WKWebViewConfiguration setPreferences:]):
     17
    1182014-02-06  Anders Carlsson  <andersca@apple.com>
    219
  • trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.h

    r162547 r163567  
    2929#if WK_API_ENABLED
    3030
     31@class WKPreferences;
    3132@class WKProcessClass;
    3233
     
    4849@property (nonatomic, strong) WKProcessClass *processClass;
    4950
     51@property (nonatomic, strong) WKPreferences *preferences;
     52
    5053@end
    5154
  • trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm

    r162549 r163567  
    2929#if WK_API_ENABLED
    3030
    31 @implementation WKWebViewConfiguration
     31#import <wtf/RetainPtr.h>
     32
     33@implementation WKWebViewConfiguration {
     34    RetainPtr<WKProcessClass> _processClass;
     35    RetainPtr<WKPreferences> _preferences;
     36}
    3237
    3338- (id)copyWithZone:(NSZone *)zone
     
    3540    WKWebViewConfiguration *configuration = [[[self class] allocWithZone:zone] init];
    3641
    37     configuration.processClass = _processClass;
     42    configuration.processClass = _processClass.get();
     43    configuration.preferences = _preferences.get();
    3844
    3945    return configuration;
     46}
     47
     48- (WKProcessClass *)processClass
     49{
     50    return _processClass.get();
     51}
     52
     53- (void)setProcessClass:(WKProcessClass *)processClass
     54{
     55    _processClass = processClass;
     56}
     57
     58- (WKPreferences *)preferences
     59{
     60    return _preferences.get();
     61}
     62
     63- (void)setPreferences:(WKPreferences *)preferences
     64{
     65    _preferences = preferences;
    4066}
    4167
Note: See TracChangeset for help on using the changeset viewer.