Changeset 163603 in webkit


Ignore:
Timestamp:
Feb 6, 2014 6:41:10 PM (10 years ago)
Author:
andersca@apple.com
Message:

Crash in MiniBrowser when using Command-W to close a WK2 window
https://bugs.webkit.org/show_bug.cgi?id=128355
<rdar://problem/16008531>

Reviewed by Simon Fraser.

Don't set the API clients to nullptr when closing the page, just create new empty ones instead.
Too much code depends on the clients never being null.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r163602 r163603  
     12014-02-06  Anders Carlsson  <andersca@apple.com>
     2
     3        Crash in MiniBrowser when using Command-W to close a WK2 window
     4        https://bugs.webkit.org/show_bug.cgi?id=128355
     5        <rdar://problem/16008531>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Don't set the API clients to nullptr when closing the page, just create new empty ones instead.
     10        Too much code depends on the clients never being null.
     11
     12        * UIProcess/WebPageProxy.cpp:
     13        (WebKit::WebPageProxy::close):
     14
    1152014-02-03  Tim Horton  <timothy_horton@apple.com>
    216
  • trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

    r163600 r163603  
    579579    resetState();
    580580
    581     m_loaderClient = nullptr;
    582     m_policyClient = nullptr;
     581    m_loaderClient = std::make_unique<API::LoaderClient>();
     582    m_policyClient = std::make_unique<API::PolicyClient>();
    583583    m_formClient.initialize(0);
    584     m_uiClient = nullptr;
     584    m_uiClient = std::make_unique<API::UIClient>();
    585585#if PLATFORM(EFL)
    586586    m_uiPopupMenuClient.initialize(0);
Note: See TracChangeset for help on using the changeset viewer.